From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9FDBC433E0 for ; Thu, 4 Feb 2021 02:34:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81B2D64F41 for ; Thu, 4 Feb 2021 02:34:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81B2D64F41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=19fJ6mDvSllq2dWEo62ckBf8ULGkCQrtqNJcKFdCHfA=; b=cS/FiWSE//LFWdnl53zDem7dK 4lb2+E8+5Bcu7tPmtVOknKe3a1ccTfDFOGT65uP0wrYF6cdVUvgQSOFreyQTL6Taj+9ECh3Ips22D ZaaD/+OQNzmkbqRZP7jWcXcn8W5MvK8VLdp6/vz4jgoZeQismj35gTJv0AXBgsjx/g9clC3os+U6X aXa/2JRtaYUql7KBPb+Bi5exoPJX7NGEZCnb8YSYDt5qMNAo+kHzKMqwIYA5zLRSbiuZRVaOMUI9T hNHhjkb0Kb2lSOosAMHS6NtuDnc/Trn73oIAyjfc8LpWiMziMa2A/OVGVXdb+GS/be6M13mC/20zP nla171l9w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7US2-00044V-SV; Thu, 04 Feb 2021 02:32:59 +0000 Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7US0-00043c-Pw for linux-arm-kernel@lists.infradead.org; Thu, 04 Feb 2021 02:32:57 +0000 Received: by mail-qk1-x72e.google.com with SMTP id u20so1996221qku.7 for ; Wed, 03 Feb 2021 18:32:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=MJioKdNVOEvo/KsyqvjYGpC+hN5xTn7omYEUx0bMXvA=; b=pHBuobSKILbJhuLLcc/3hth4BHKUubli9fuZUhZC+rObDP8cZ8bgoJmT3tzjw2EIg8 epntF8Yw9jYjZ0p3PZ8Aub5vPEkryWi29byJhQzH8Fn6PVBgQTIh5Iia20YZDOEs+udO WelxyU/fEXLkjepwX1O4YkQUvFUErIANe2fGgIWWrimjEE1Qen3bLyvdHvFAoSyVKNXe uwikz2zf6rUJvOrsRDPYUQMxbK/DcPK9+q34NsRcDDzpmZuzlM+AsIF8b10yNWpCzHdL 4kRKJPGbw+gQXjiiQCX9iulrmlR+Lr8OmjGRy8YeGGZemxroN9bKnm/im9h2PUzPWqb8 8BaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=MJioKdNVOEvo/KsyqvjYGpC+hN5xTn7omYEUx0bMXvA=; b=KHJT+j1vwqvXPrW477NeweSkN1OzWKhlPP2g0lOU5uw8lR8DeWKHOpxKzXIaqVk6c4 e+lQIVaVjd4cfjtYBpmrfFvIFTQ7ToC4/GbuBL4rPl42n/wl2sOzE0B+8ZBlsNTPXJZz hB/8OjRHmWxNQ+E36yixqoLRqpLIPQ7mQru7Uq8D2hTxv2E3OR4SAos2BHvTi81SNKmY E9So1sQfh9wd3FuWj4AvmCteRxYFmtzJqe1JyICR7MgcvSYnOJQ7TFIvQ3k/B0LNvxau jgtA1iZr23zrEtcrsRqfFu7fkcvuyQB4ieuwosO/S+pR1SebLj/6ifrYdn4/9WHc3eaZ v6mQ== X-Gm-Message-State: AOAM531dpW+D6atGH5T9nVaVkOJqVzHKArErb6OIjCUwwD4RYnYUBeWt OzUPZoo9nYcDvMyiwOjRtdWhcE/GldqjZPVB X-Google-Smtp-Source: ABdhPJx8lCqzRhCNeQl1whuWue+5WRmG99XC7j3zoNvxdquVVyaGP6f4KGPx5SJ4mJazMH/jozA0bQ== X-Received: by 2002:a05:620a:2239:: with SMTP id n25mr5605909qkh.46.1612405974819; Wed, 03 Feb 2021 18:32:54 -0800 (PST) Received: from Gentoo ([138.199.13.179]) by smtp.gmail.com with ESMTPSA id n78sm3818564qkn.22.2021.02.03.18.32.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 18:32:53 -0800 (PST) Date: Thu, 4 Feb 2021 08:02:43 +0530 From: Bhaskar Chowdhury To: Randy Dunlap Subject: Re: [PATCH V2] drivers: net: ethernet: i825xx: Fix couple of spellings and get rid of blank lines too in the file ether1.c Message-ID: Mail-Followup-To: Bhaskar Chowdhury , Randy Dunlap , linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210204011821.18356-1-unixbhaskar@gmail.com> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210203_213256_947171_DDB7F77D X-CRM114-Status: GOOD ( 17.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, kuba@kernel.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============8837306610223260503==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8837306610223260503== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Dz9hAsEg3MNNcKsb" Content-Disposition: inline --Dz9hAsEg3MNNcKsb Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline On 18:09 Wed 03 Feb 2021, Randy Dunlap wrote: >On 2/3/21 5:18 PM, Bhaskar Chowdhury wrote: >> >> s/initialsation/initialisation/ >> s/specifiing/specifying/ >> >> Plus get rid of few blank lines. >> >> Signed-off-by: Bhaskar Chowdhury >> --- >> Changes from V1: >> Fix typo in the subject line >> Give explanation of all the changes in changelog text >> >> drivers/net/ethernet/i825xx/ether1.c | 9 +++------ >> 1 file changed, 3 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/net/ethernet/i825xx/ether1.c b/drivers/net/ethernet/i825xx/ether1.c >> index a0bfb509e002..850ea32091ed 100644 >> --- a/drivers/net/ethernet/i825xx/ether1.c >> +++ b/drivers/net/ethernet/i825xx/ether1.c > >a. don't delete the blank lines >b. the change below is not described and does not change any whitespace AFAICT. > I.e., DDT [don't do that]. > But what do you do when things getting automatically inducted in the patch???(You got to believe me) I haven't had touch that bloody function with my keystroke and it gets it on its own! Bemusing! Those blank lines too inducted from the fresh file(means in pristine form) ,so thought pruning would be good..hence the decision to get rid of those. Wondering what the fuck is going on.... >> @@ -1047,7 +1044,7 @@ static void ether1_remove(struct expansion_card *ec) >> { >> struct net_device *dev = ecard_get_drvdata(ec); >> >> - ecard_set_drvdata(ec, NULL); >> + ecard_set_drvdata(ec, NULL); >> >> unregister_netdev(dev); >> free_netdev(dev); > > >-- >~Randy > --Dz9hAsEg3MNNcKsb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEnwF+nWawchZUPOuwsjqdtxFLKRUFAmAbXMcACgkQsjqdtxFL KRXE3wgA08qhl3UlYZ5F03/kEOuJVrzbjZ27P2zjgZmen5iEaTN2Jlc/VjMe/tI0 B97nAdg8pPmTtBpSS0e7Fc7W0t5y3/FOazlV/86V7fiEov3grjhJl+tzt4NfwxXL Mlhn3+8aL0Kui1YEKqKJuwYFwRO+ZaiqOFVi28VyT7ZcZDscXOXDmyR2tzfNFLl/ HtPl6rO8nXBpoI6Af0hl2pcNFIP0WDKXsy6lOiCNLHPMEHZLceVpuzuFupx4eXXg qfZPnWDEA6MOGIt1INSdI/yZndi2eRnTVjPnRD6fRp+J4kiNyQrmnlnxLyJWZRF1 5pwZRSn3pCRybvO+htN137Yi86zLsw== =gNBU -----END PGP SIGNATURE----- --Dz9hAsEg3MNNcKsb-- --===============8837306610223260503== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8837306610223260503==--