From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEFFDC433E0 for ; Thu, 4 Feb 2021 14:54:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5AC5F64F4D for ; Thu, 4 Feb 2021 14:54:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AC5F64F4D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6RCnefsQJ0Xu2N1AK1CAYyafY5jLaD87nok6MgeXJ4s=; b=FsmFlMnzRVcap7Dzp7FslR6Xm lTr87eu0eW4ydARtfHssH5yyChgRWLWKuLPX05OfC5bJrsQhKvgQb9ca3pEp8wL27ERJHaljfwlMO oDmF71GSTRJdyXggQL2e1YeuimXehDRHOmBaFK70W2S1jmluc9QwYZQLr+Xp8ko1MfLeudII9Bddt on+WUfeY8KzPeb4rE3Qek9g+62jDIMkIRpHWEYGcop5yZRBFzwYI3TMdStd7840aMtjKMe+Et8ujS 4D+0fvqj49QB7/h6nOkH8f5PR0hrCsNy9JuhPiyQauYcvu3heee9/fDNYui0gFaMJTca+yYSAIJIK ss1JsxqKg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7g0C-0005EB-2Q; Thu, 04 Feb 2021 14:53:00 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7g09-0005DV-98 for linux-arm-kernel@lists.infradead.org; Thu, 04 Feb 2021 14:52:58 +0000 Received: by mail-wm1-x333.google.com with SMTP id i9so3240360wmq.1 for ; Thu, 04 Feb 2021 06:52:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GmzDwYCwB3ACF6L8pkrzfaM1KU2/zTHOCAwwjAAIW1c=; b=T4n7B/HDfO8GLn9RDv5a9Mnd7w6QzC1CmmDAy2dGrwaoMO/jJ9ye68xPKJXV0LUP0g HMI9KaeCJNVypsn0VcgiXF0nahQXoHOgDKN4FwRWRycbYlkqaH9q1rmG+kRJ8FGQJ1TS KQOwwrHclrlRKXj4BjzWTg9Tds6QLnXBGQlVYn2K5UHD2lSJLkgLXYfczlptpwyjMoni lRVSC4FnURwvgkpAlTUnIrGGVyJXCmGFRKRzLAt1vP7qj8FHDEynp0phez5v1FcB62jo bg9FLizdXkt4a8l65wUYQQXLTkD0GdTnUAlZekz6904IYqEVSUDgLLvEPRXk+a/P6Ta/ bNSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GmzDwYCwB3ACF6L8pkrzfaM1KU2/zTHOCAwwjAAIW1c=; b=kUCMvywA2r3XSWLm0eks+G1wRozVuxppyi97biGCDqRx1dGLGTBM2TPKa5KrdpNX8U AXxgGDhQ+3jEdpT7kZaEBjtzQkpuzJe7pK0I08sqL5LVYZsuw33G0l+kS25cdKjEKG7S rgqrcryVbIYBrUpm/fmm5/kbZF2t1L4Kbm0GnaYZoSF8b3Ew5IeDrw/IFZdcZzH9S1BX wzO0nfbO+UHOe1hRtAIAOJDDghRU0SplaDc4kqu/PEvFTMoejmOLfhNYVOGORFOCh0db W6MX3BCl8DwEe1MpREDa6Re+MLf4uG5ujAlvZO3fJ9+8woFjRJfv+9mUS7yR7lEI/iqX kG5g== X-Gm-Message-State: AOAM533mv1IqnFn2mwsQ3TyV1PG1beOln7RQPEFUbKEDvBhDFYfB/Zcg WJ08EU/XHrhD9kIj1TdwhL8sJg== X-Google-Smtp-Source: ABdhPJytkpleb2goc1M1MLDTsD+ny4hCYPN6kmBxFpTwEmpJaqq+R5jrD51y1ejkMwjS5CKoxfmVRw== X-Received: by 2002:a05:600c:ce:: with SMTP id u14mr7866356wmm.10.1612450375861; Thu, 04 Feb 2021 06:52:55 -0800 (PST) Received: from google.com (230.69.233.35.bc.googleusercontent.com. [35.233.69.230]) by smtp.gmail.com with ESMTPSA id y63sm6195028wmd.21.2021.02.04.06.52.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 06:52:55 -0800 (PST) Date: Thu, 4 Feb 2021 14:52:52 +0000 From: Quentin Perret To: Will Deacon Subject: Re: [RFC PATCH v2 12/26] KVM: arm64: Introduce a Hyp buddy page allocator Message-ID: References: <20210108121524.656872-1-qperret@google.com> <20210108121524.656872-13-qperret@google.com> <20210202181307.GA17311@willie-the-truck> <20210204143106.GA20792@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210204143106.GA20792@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210204_095257_384222_2A12CD38 X-CRM114-Status: GOOD ( 21.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, kernel-team@android.com, Suzuki K Poulose , android-kvm@google.com, Catalin Marinas , Fuad Tabba , linux-kernel@vger.kernel.org, Rob Herring , James Morse , linux-arm-kernel@lists.infradead.org, Marc Zyngier , David Brazdil , Frank Rowand , kvmarm@lists.cs.columbia.edu, Julien Thierry Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thursday 04 Feb 2021 at 14:31:08 (+0000), Will Deacon wrote: > On Wed, Feb 03, 2021 at 06:33:30PM +0000, Quentin Perret wrote: > > On Tuesday 02 Feb 2021 at 18:13:08 (+0000), Will Deacon wrote: > > > On Fri, Jan 08, 2021 at 12:15:10PM +0000, Quentin Perret wrote: > > > > + * __find_buddy(pool, page 0, order 0) => page 1 > > > > + * __find_buddy(pool, page 0, order 1) => page 2 > > > > + * __find_buddy(pool, page 1, order 0) => page 0 > > > > + * __find_buddy(pool, page 2, order 0) => page 3 > > > > + */ > > > > +static struct hyp_page *__find_buddy(struct hyp_pool *pool, struct hyp_page *p, > > > > + unsigned int order) > > > > +{ > > > > + phys_addr_t addr = hyp_page_to_phys(p); > > > > + > > > > + addr ^= (PAGE_SIZE << order); > > > > + if (addr < pool->range_start || addr >= pool->range_end) > > > > + return NULL; > > > > > > Are these range checks only needed because the pool isn't required to be > > > an exact power-of-2 pages in size? If so, maybe it would be more > > > straightforward to limit the max order on a per-pool basis depending upon > > > its size? > > > > More importantly, it is because pages outside of the pool are not > > guaranteed to be covered by the hyp_vmemmap, so I really need to make > > sure I don't dereference them. > > Wouldn't having a per-pool max order help with that? The issue is, I have no alignment guarantees for the pools, so I may end up with max_order = 0 ... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel