From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7429CC433E0 for ; Sun, 7 Feb 2021 21:33:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36AB064E15 for ; Sun, 7 Feb 2021 21:33:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36AB064E15 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=x9usOdrdh1CgK8W02dxMRW1GhfzkElfymtlIq5lTDlU=; b=R72Jj/dOw2VtiZA+d6pvf3i/N OJGvJ3kRm1PSRK9l8KNO+BqEvuFuDH1obPAQQYGyvp4OJvfvaVrsPeu9w3arUp75nwneUWnOlH9iV 949orFepSLq1Z4281YfN+RA+Sfw2J1b72XMhCqKd87ZK65LWKZkFt3xp4+Q3fTCzwUJ5RcnlomzXB /hQwKxfBOWkaQwDDTq4/L91P2R2W/kNWxFHpUIb8HW66sjrXqp2SIzMBWOGZiCJnPW+yTkHP3LOdT DYN42ke98AuNJX0whDwbtIfqucVZiHEA/vmWVAXoNxAnD4EIzb/56WCq3nKvqcvzLptZDVfATDI4Z 2UhU61+WQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l8rfN-0001j6-EK; Sun, 07 Feb 2021 21:32:25 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l8rfK-0001iU-DT for linux-arm-kernel@lists.infradead.org; Sun, 07 Feb 2021 21:32:23 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1l8rf7-004iGX-8h; Sun, 07 Feb 2021 22:32:09 +0100 Date: Sun, 7 Feb 2021 22:32:09 +0100 From: Andrew Lunn To: stefanc@marvell.com Subject: Re: [PATCH v9 net-next 03/15] net: mvpp2: add CM3 SRAM memory map Message-ID: References: <1612723137-18045-1-git-send-email-stefanc@marvell.com> <1612723137-18045-4-git-send-email-stefanc@marvell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1612723137-18045-4-git-send-email-stefanc@marvell.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210207_163222_508444_A00B49AD X-CRM114-Status: UNSURE ( 8.58 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, ymarkman@marvell.com, gregory.clement@bootlin.com, netdev@vger.kernel.org, atenart@kernel.org, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, nadavh@marvell.com, rmk+kernel@armlinux.org.uk, robh+dt@kernel.org, thomas.petazzoni@bootlin.com, kuba@kernel.org, mw@semihalf.com, davem@davemloft.net, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > +static int mvpp2_get_sram(struct platform_device *pdev, > + struct mvpp2 *priv) > +{ > + struct resource *res; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 2); > + if (!res) { > + if (has_acpi_companion(&pdev->dev)) > + dev_warn(&pdev->dev, "ACPI is too old, Flow control not supported\n"); > + else > + dev_warn(&pdev->dev, "DT is too old, Flow control not supported\n"); > + return 0; > + } > + > + priv->cm3_base = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(priv->cm3_base)) > + return PTR_ERR(priv->cm3_base); > + > + return 0; > +} This looks much better. Thanks Reviewed-by: Andrew Lunn Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel