From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53BF9C433DB for ; Mon, 8 Feb 2021 11:05:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D268464E54 for ; Mon, 8 Feb 2021 11:05:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D268464E54 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tG1oQ3qA5/HmoiwfadU7sc/aS4J9AxXXYpoRCq4WW7Y=; b=DoFpHegODn7oflWPILatCMwUO LJIllrsBO9lAtibqPytRvYBYZDOzp73Ua2KJxR7cVvm5DwbRHzu2QHZcvo5FgEATTsbEMrEHwiwmF IiDuUNdp2vqk3/DSou2BORsCiVwM4C846KUnNIUERZnOD2ssijdZrq8IvkYYH2KIUAq7LQao2OfqD S88YMCHuyx7+X+YX8pMN2eDQUGtjAQgsrRkVTM2j9iC2lk9tTWGB14zug8N0dsl010HENmGE+0V83 UFqRXdl+exPbRd/Z1i0LDeT9zj/+OXVPt8TJadGbFjDK7E3KocDAksP2hrH0U/WJIz+G0OTRdzxo1 p0IHLjS9A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l94L1-0003cb-1m; Mon, 08 Feb 2021 11:04:15 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l94Kw-0003bf-KJ for linux-arm-kernel@lists.infradead.org; Mon, 08 Feb 2021 11:04:11 +0000 Received: by mail-wr1-x42b.google.com with SMTP id l12so16582701wry.2 for ; Mon, 08 Feb 2021 03:04:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pufLM1lgk30Z0xNUrr/sKibBHabmfyHL7QD1WY1Y8VI=; b=iniQAbHQgxYyxXrODcz5H25no50robM+BRmtay9TDQp3GkR61GWi+tMIeRE+l+BwlF htSJGAWcO4ZhGi6H1KpZalqoHbgu5gAGQq3qBOVFj6ypipvAtSIdeGz+dGj/WkvMZR/z RKJP/FCxsrt1uxui0UJE5ztr8C4ajgkvawLkrsOMZh7qChLKx6SANqyWJLT135jItsVz ketpYksjvR1NBhuFuJqgrPfEBK//yDMhN8H9ieg3Aol/Q5zo0xGwRWypit1E7FR8ak33 W9/Oyz5zbfACKhHz/qYEkII58OB/MGQBH/fhhsax7nl0HD4e0yDXcZX0qmEq9f1uVwHE Ex/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pufLM1lgk30Z0xNUrr/sKibBHabmfyHL7QD1WY1Y8VI=; b=ONxnmVvDM2/CxVb2i2o6wGVT8dQeQdrQot00shraj8CI7Ui/Z45R62sFQdQIeH2t40 Opm2DoRbQfJS3BDTIsCFpDeykV2KGYOh+lkfceiPLyc/tno8yoITw5Ki3BoApIxg1WvT dLNjstKC1W4qLF0+YT9fh4Cfwkm7W3l4enT6atXIfimIMPR8YENjm77VL0rm5j6Q/E5b MDnrjmNu/gfm9urMCVSIL3v9FBOm4gwwI5lOeHJATDCUcXFT5odZ8CsWYnLtUo7BHaon lMtYSxkv7RFa5k7wRjG9tgJ9laVkmsSBRsX3UvLRTZJn00KoYrP6CvOao6LdrgaWjYig 54GQ== X-Gm-Message-State: AOAM533a5EkFAEnWYhS0gtzbi+6h2lTq/g28ykbJR8Hk2FMyx11+xoPa 4tIoc8GyjXbhzbh9VW/X2SQFVg== X-Google-Smtp-Source: ABdhPJxsmyLQVX4sWX2FYBfjZz5gROTDQRFioLFhFldnjYhL3QwGKQjxhinXI80+MX13RPN0toHgaQ== X-Received: by 2002:a05:6000:192:: with SMTP id p18mr19149327wrx.69.1612782249203; Mon, 08 Feb 2021 03:04:09 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:497f:76ef:2e62:d028]) by smtp.gmail.com with ESMTPSA id x82sm14752706wmg.31.2021.02.08.03.04.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 03:04:08 -0800 (PST) Date: Mon, 8 Feb 2021 12:04:02 +0100 From: Marco Elver To: Andrey Konovalov Subject: Re: [PATCH v3 mm 11/13] kasan: inline HW_TAGS helper functions Message-ID: References: <2c94a2af0657f2b95b9337232339ff5ffa643ab5.1612546384.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2c94a2af0657f2b95b9337232339ff5ffa643ab5.1612546384.git.andreyknvl@google.com> User-Agent: Mutt/2.0.2 (2020-11-20) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210208_060410_796513_AEEFA0EA X-CRM114-Status: GOOD ( 19.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Branislav Rankov , Catalin Marinas , Kevin Brodsky , Will Deacon , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Peter Collingbourne , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 05, 2021 at 06:34PM +0100, Andrey Konovalov wrote: > Mark all static functions in common.c and kasan.h that are used for > hardware tag-based KASAN as inline to avoid unnecessary function calls. > > Signed-off-by: Andrey Konovalov Reviewed-by: Marco Elver > --- > mm/kasan/common.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index 7ffb1e6de2ef..7b53291dafa1 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -279,7 +279,8 @@ void __kasan_poison_object_data(struct kmem_cache *cache, void *object) > * based on objects indexes, so that objects that are next to each other > * get different tags. > */ > -static u8 assign_tag(struct kmem_cache *cache, const void *object, bool init) > +static inline u8 assign_tag(struct kmem_cache *cache, > + const void *object, bool init) > { > if (IS_ENABLED(CONFIG_KASAN_GENERIC)) > return 0xff; > @@ -321,8 +322,8 @@ void * __must_check __kasan_init_slab_obj(struct kmem_cache *cache, > return (void *)object; > } > > -static bool ____kasan_slab_free(struct kmem_cache *cache, void *object, > - unsigned long ip, bool quarantine) > +static inline bool ____kasan_slab_free(struct kmem_cache *cache, > + void *object, unsigned long ip, bool quarantine) > { > u8 tag; > void *tagged_object; > @@ -366,7 +367,7 @@ bool __kasan_slab_free(struct kmem_cache *cache, void *object, unsigned long ip) > return ____kasan_slab_free(cache, object, ip, true); > } > > -static bool ____kasan_kfree_large(void *ptr, unsigned long ip) > +static inline bool ____kasan_kfree_large(void *ptr, unsigned long ip) > { > if (ptr != page_address(virt_to_head_page(ptr))) { > kasan_report_invalid_free(ptr, ip); > @@ -461,8 +462,8 @@ void * __must_check __kasan_slab_alloc(struct kmem_cache *cache, > return tagged_object; > } > > -static void *____kasan_kmalloc(struct kmem_cache *cache, const void *object, > - size_t size, gfp_t flags) > +static inline void *____kasan_kmalloc(struct kmem_cache *cache, > + const void *object, size_t size, gfp_t flags) > { > unsigned long redzone_start; > unsigned long redzone_end; > -- > 2.30.0.365.g02bc693789-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel