From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E116C433DB for ; Tue, 9 Feb 2021 17:21:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5F9B64E54 for ; Tue, 9 Feb 2021 17:21:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5F9B64E54 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lxrpy9H4aVRNLkZWMUXicjxd6fEXRg4hViQhn1WAEtE=; b=MqsurZKYJnM5a2D1CNQMlK978 beDFs+D3FrBAchW4oN0XZ2M2sxVukisRolYJsOtphcGGW4mbQgY5xtj58entdXgbxSHm/SLxKft1D UEEdF2D5GGJH+hNQGi0I8nnMF3ET0tHlAsERXNna08SFAAOXO84ToaQ0hheua+0XCrLJ/4HlAN2Ci KRDoap1gfYfYMFTyjaShfi3cSSMqH9maMVAX4k1Kchh7qHv00K1CqyitmoYuy1GxqLhFxDuX0q4vz L6j3IUKhYVwSa81OR60fecdyAAs3eKq5C5NB+ftzWoZtRNGnILftAemXfXH8eE6vKHhVizkKAS44i DzM25rsmw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9Wg1-0005lk-Ni; Tue, 09 Feb 2021 17:19:49 +0000 Received: from mail-oo1-xc36.google.com ([2607:f8b0:4864:20::c36]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9Wfx-0005kf-0a for linux-arm-kernel@lists.infradead.org; Tue, 09 Feb 2021 17:19:47 +0000 Received: by mail-oo1-xc36.google.com with SMTP id x23so4437797oop.1 for ; Tue, 09 Feb 2021 09:19:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F3Bq4AlUrdrosw0AiiaEx5S72sFr2hrQxQwbM2DUyVM=; b=jF5KpzKj2SCQPLubuGJH4OLS0x8ZKXJ5PF9EbaYmUES2u4qDd3DCjM/6nCJ7D8BMAy or6pwP9IZVf3tzjdMaGZqT/4NceSqTNLY8UdephdzFzn9jwNlL0/8TuPMPWUU8+VSFfr bsEZqEfEmlArNO2sKerWObRG1l9uXiHjSptixq3ZzwdAqZpNHu2VSFOTDlfZCjGRfyzh RZJjlzjYz5STL02287Aks9TwnGE5y55ioKZHU+jvqY82qvVaApxeJk3xkxEUCbXJYlTX zc3gwK+tG3mA6e1q0/Cnfk4vlcD5tCKisJy1fSzM7EUPjA1BYBeEtJaGPsJ1ga7DQPiU 6PCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F3Bq4AlUrdrosw0AiiaEx5S72sFr2hrQxQwbM2DUyVM=; b=fyt5/HEsYwjVLM+nOYDbKpo+7EAQ5g0l8zIVvi3TboiGWJAtMgvwzoKoRJx7AnyiNJ mrdikGQ1RKbAO4JoXPjcwV3y3gB4pVH1zJDT4CEc/eMtguMtd3m7LiPNpQJVDhYqh7gZ Zk+YfKlUXBOn5ElQo0jB90mx8fFehj2d1Nq5pj4JBRo9uQd7YDuEjRtUqOzir/PDZqja Ch+LZiFN+epXyxMhxuCNSneZg8q7dZs7od1YKjQAp2wLjAo438zetZQP1byVcuKtdJLi BEmgnTMFJBYTtbEZ6DFa+Cn/pru8ZC0Bqir9Bo6WNlgjzx8k8M0ZgPSaUaLyyPa/FLIg +2Mw== X-Gm-Message-State: AOAM533Lxi6HXoCTTfnrkdCY+GmW40eifNOQHOwnCpNkEipZ7ECfdjHJ WWB+ouu8epqsXNynErs7UB9Z0w== X-Google-Smtp-Source: ABdhPJzePQ1pKEKY1wfXkp3t+2w73TUAvt/dL+kKd60u3tlPQjDwvza13HVj2BAF6VL+H6EXphHMKQ== X-Received: by 2002:a4a:e14f:: with SMTP id p15mr16587495oot.25.1612891182717; Tue, 09 Feb 2021 09:19:42 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id z8sm4287543oon.10.2021.02.09.09.19.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 09:19:42 -0800 (PST) Date: Tue, 9 Feb 2021 11:19:40 -0600 From: Bjorn Andersson To: Suman Anna Subject: Re: [PATCH 1/2] dt-bindings: hwlock: Update OMAP HwSpinlock binding for AM64x SoCs Message-ID: References: <20210125235653.24385-1-s-anna@ti.com> <20210125235653.24385-2-s-anna@ti.com> <20210209170025.GA3927023@robh.at.kernel.org> <48f25fc0-5131-9821-d50d-7f4f7ef5815e@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <48f25fc0-5131-9821-d50d-7f4f7ef5815e@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210209_121945_386839_D4CCF779 X-CRM114-Status: GOOD ( 25.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , linux-omap@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue 09 Feb 11:09 CST 2021, Suman Anna wrote: > Hi Rob, > > On 2/9/21 11:00 AM, Rob Herring wrote: > > On Mon, Jan 25, 2021 at 05:56:52PM -0600, Suman Anna wrote: > >> Update the existing OMAP HwSpinlock binding to include the info for > >> AM64x SoCs. There are some minor IP integration differences between > >> the AM64x SoCs and the previous AM65x and J721E SoC families. A new > >> example is also added showcasing the difference in the IP's presence > >> on the interconnect. > >> > >> Signed-off-by: Suman Anna > >> --- > >> .../bindings/hwlock/ti,omap-hwspinlock.yaml | 26 +++++++++++++++++++ > >> 1 file changed, 26 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml > >> index ac35491a6f65..ac146c0d628f 100644 > >> --- a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml > >> +++ b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml > >> @@ -14,6 +14,7 @@ properties: > >> enum: > >> - ti,omap4-hwspinlock # for OMAP44xx, OMAP54xx, AM33xx, AM43xx, DRA7xx SoCs > >> - ti,am654-hwspinlock # for K3 AM65x, J721E and J7200 SoCs > >> + - ti,am64-hwspinlock # for K3 AM64x SoCs > >> > >> reg: > >> maxItems: 1 > >> @@ -74,3 +75,28 @@ examples: > >> }; > >> }; > >> }; > >> + > >> + - | > >> + / { > >> + /* K3 AM64x SoCs */ > >> + model = "Texas Instruments K3 AM642 SoC"; > >> + compatible = "ti,am642-evm", "ti,am642"; > >> + #address-cells = <2>; > >> + #size-cells = <2>; > >> + > >> + bus@f4000 { > >> + compatible = "simple-bus"; > >> + #address-cells = <2>; > >> + #size-cells = <2>; > >> + ranges = <0x00 0x000f4000 0x00 0x000f4000 0x00 0x000002d0>, /* PINCTRL */ > >> + <0x00 0x01000000 0x00 0x01000000 0x00 0x02330400>, /* First peripheral window */ > >> + <0x00 0x0f000000 0x00 0x0f000000 0x00 0x00c44200>, /* Second peripheral window */ > >> + <0x00 0x20000000 0x00 0x20000000 0x00 0x0a008000>; /* Third peripheral window */ > >> + > >> + spinlock@2a000000 { > > > > Why are you doing the whole hierarchy here? Don't do that. > > I added it because it's integration is slightly different and to help our > downstream consumers. > > > > > In any case, a new compatible doesn't warrant a whole new example, so > > drop the example. > > Yeah ok, will drop the example. > I was just waiting for my build test to pass before pushing this and a few other patches out, will drop the example from the patch here. No need to resend. Thanks, Bjorn > regards > Suman > > > > >> + compatible = "ti,am64-hwspinlock"; > >> + reg = <0x00 0x2a000000 0x00 0x1000>; > >> + #hwlock-cells = <1>; > >> + }; > >> + }; > >> + }; > >> -- > >> 2.29.2 > >> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel