From: Daniel Vetter <daniel@ffwll.ch>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: "Jernej Skrabec" <jernej.skrabec@siol.net>,
"Heiko Stübner" <heiko@sntech.de>,
linux-aspeed@lists.ozlabs.org,
"Neil Armstrong" <narmstrong@baylibre.com>,
"David Airlie" <airlied@linux.ie>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Jonas Karlman" <jonas@kwiboo.se>,
kernel-janitors@vger.kernel.org,
"Sandy Huang" <hjc@rock-chips.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Andrzej Hajda" <a.hajda@samsung.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
linux-rockchip@lists.infradead.org,
"Sam Ravnborg" <sam@ravnborg.org>,
linux-arm-kernel@lists.infradead.org,
"Joel Stanley" <joel@jms.id.au>
Subject: Re: [PATCH] drm: use getter/setter functions
Date: Wed, 10 Feb 2021 14:11:14 +0100 [thread overview]
Message-ID: <YCPbctaFCApnwOmT@phenom.ffwll.local> (raw)
In-Reply-To: <20210209211304.1261740-1-Julia.Lawall@inria.fr>
On Tue, Feb 09, 2021 at 10:13:04PM +0100, Julia Lawall wrote:
> Use getter and setter functions, for platform_device structures and a
> mipi_dsi_device structure.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Applied to drm-misc-next, thanks for the patch.
-Daniel
>
> ---
> drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 2 +-
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 2 +-
> drivers/gpu/drm/panel/panel-lvds.c | 2 +-
> drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 4 ++--
> drivers/gpu/drm/panel/panel-simple.c | 2 +-
> drivers/gpu/drm/rockchip/rockchip_lvds.c | 2 +-
> 6 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 4e2dad314c79..9858079f9e14 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -4800,7 +4800,7 @@ static int panel_simple_dsi_probe(struct mipi_dsi_device *dsi)
>
> err = mipi_dsi_attach(dsi);
> if (err) {
> - struct panel_simple *panel = dev_get_drvdata(&dsi->dev);
> + struct panel_simple *panel = mipi_dsi_get_drvdata(dsi);
>
> drm_panel_remove(&panel->base);
> }
> diff --git a/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c b/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c
> index 0ee508576231..3939b25e6666 100644
> --- a/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c
> +++ b/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c
> @@ -267,7 +267,7 @@ static int seiko_panel_probe(struct device *dev,
>
> static int seiko_panel_remove(struct platform_device *pdev)
> {
> - struct seiko_panel *panel = dev_get_drvdata(&pdev->dev);
> + struct seiko_panel *panel = platform_get_drvdata(pdev);
>
> drm_panel_remove(&panel->base);
> drm_panel_disable(&panel->base);
> @@ -277,7 +277,7 @@ static int seiko_panel_remove(struct platform_device *pdev)
>
> static void seiko_panel_shutdown(struct platform_device *pdev)
> {
> - struct seiko_panel *panel = dev_get_drvdata(&pdev->dev);
> + struct seiko_panel *panel = platform_get_drvdata(pdev);
>
> drm_panel_disable(&panel->base);
> }
> diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c
> index 654bc52d9ff3..bd5ba10822c2 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_lvds.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c
> @@ -725,7 +725,7 @@ static int rockchip_lvds_probe(struct platform_device *pdev)
>
> static int rockchip_lvds_remove(struct platform_device *pdev)
> {
> - struct rockchip_lvds *lvds = dev_get_drvdata(&pdev->dev);
> + struct rockchip_lvds *lvds = platform_get_drvdata(pdev);
>
> component_del(&pdev->dev, &rockchip_lvds_component_ops);
> clk_unprepare(lvds->pclk);
> diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
> index 457ec04950f7..c7707338bfdb 100644
> --- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
> +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
> @@ -284,7 +284,7 @@ static int aspeed_gfx_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - dev_set_drvdata(&pdev->dev, priv);
> + platform_set_drvdata(pdev, priv);
>
> ret = sysfs_create_group(&pdev->dev.kobj, &aspeed_sysfs_attr_group);
> if (ret)
> diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
> index d0c65610ebb5..989a05bc8197 100644
> --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
> +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
> @@ -2457,7 +2457,7 @@ static int cdns_mhdp_probe(struct platform_device *pdev)
>
> static int cdns_mhdp_remove(struct platform_device *pdev)
> {
> - struct cdns_mhdp_device *mhdp = dev_get_drvdata(&pdev->dev);
> + struct cdns_mhdp_device *mhdp = platform_get_drvdata(pdev);
> unsigned long timeout = msecs_to_jiffies(100);
> bool stop_fw = false;
> int ret;
> diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c
> index 66c7d765b8f7..59a8d99e777d 100644
> --- a/drivers/gpu/drm/panel/panel-lvds.c
> +++ b/drivers/gpu/drm/panel/panel-lvds.c
> @@ -244,7 +244,7 @@ static int panel_lvds_probe(struct platform_device *pdev)
>
> static int panel_lvds_remove(struct platform_device *pdev)
> {
> - struct panel_lvds *lvds = dev_get_drvdata(&pdev->dev);
> + struct panel_lvds *lvds = platform_get_drvdata(pdev);
>
> drm_panel_remove(&lvds->panel);
>
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-02-10 13:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 21:13 [PATCH] drm: use getter/setter functions Julia Lawall
2021-02-10 13:11 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCPbctaFCApnwOmT@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Julia.Lawall@inria.fr \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=andrew@aj.id.au \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jernej.skrabec@siol.net \
--cc=joel@jms.id.au \
--cc=jonas@kwiboo.se \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=narmstrong@baylibre.com \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).