From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8EBFC433DB for ; Fri, 12 Feb 2021 12:23:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5818264E2A for ; Fri, 12 Feb 2021 12:23:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5818264E2A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=d1OMgy+Ee4y1QS9O+XcAW4Xbz2UfuUTzSMcAhQpQ27U=; b=T64kdCx7RZh1feF6WJNbjQO/8 euKloej4HJiMBzJClSy5OUED+YqIod7W2QE3SVZSj/o/nYmzgJY2hDqPdjgu5UyATMp8vlIi5SB+C nZcZDU6yqbAZ4kltmDdKMgSVQS5MessYZcDzMCUOxWkM3UPlwllG0A9oGOXMO2IRML9B9roZRBpEd wI2814AcIYpU9l8RXNG9KqZP356jCRHt3o4OeXuBUI+5jyIHH+YdGP2RdEaHktuIWXo/Ei6faFYd2 bycLUCfra5CT4smCgR3kD1p4uVJS9Pf/wAsZ48n4zTm377BJPOB9WD6d7QFrgqsOs9zpgZQxyYg6P psmha4pNw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAXSo-0001js-A4; Fri, 12 Feb 2021 12:22:22 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAXSj-0001hP-JF for linux-arm-kernel@lists.infradead.org; Fri, 12 Feb 2021 12:22:18 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4366364E08; Fri, 12 Feb 2021 12:22:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613132535; bh=kL29m8B0BlKb4QIpXdEX+ADv5B/oc9gQuw1FfsQLD9w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U+dgREgRgSE8KbbgP9crNtAgqGKxU6y26G/RPkFQlbX0sd1F0ba0mGsQ3NZ+Nh04k pPVOI7qtYe+QKH2I8GwccmNx9iU9wGHr8Xmn+Yku6OD3XBZqCXpOT7aVKHbgeDKnVu V+YzGwm1doa07j7en/GB9Pexa9dwU1jFVD7BZ5rB8Mc18PmgYBRnnqsR27FgA/+7lE wrqrNPBBXHeRZACL7Dgc0e9paAcNgqpAEMgPPg+XQMIO3Kugb+2Si7u+yjKPCzqsO1 N0fb5aqh92Gl1y3FJAbbOz7+RwKqKhzxDbMVDK/kMbGsJNz08149OemyiAdZqF7ooX xpwybHFk4/3Gw== Date: Fri, 12 Feb 2021 14:22:06 +0200 From: Jarkko Sakkinen To: Ahmad Fatoum Subject: Re: [PATCH v8 1/4] KEYS: trusted: Add generic trusted keys framework Message-ID: References: <1604419306-26105-1-git-send-email-sumit.garg@linaro.org> <1604419306-26105-2-git-send-email-sumit.garg@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210212_072217_746761_EFAEE372 X-CRM114-Status: GOOD ( 17.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sumit Garg , daniel.thompson@linaro.org, corbet@lwn.net, jejb@linux.ibm.com, janne.karhunen@gmail.com, linux-doc@vger.kernel.org, jmorris@namei.org, zohar@linux.ibm.com, linux-kernel@vger.kernel.org, dhowells@redhat.com, casey@schaufler-ca.com, linux-security-module@vger.kernel.org, op-tee@lists.trustedfirmware.org, keyrings@vger.kernel.org, jarkko.sakkinen@linux.intel.com, Markus.Wamser@mixed-mode.de, lhinds@redhat.com, linux-integrity@vger.kernel.org, jens.wiklander@linaro.org, linux-arm-kernel@lists.infradead.org, serge@hallyn.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 11, 2021 at 11:34:21AM +0100, Ahmad Fatoum wrote: > Hello Jarkko, > > On 10.02.21 18:00, Jarkko Sakkinen wrote: > > On Tue, Nov 03, 2020 at 09:31:43PM +0530, Sumit Garg wrote: > >> + case Opt_new: > >> + key_len = payload->key_len; > >> + ret = static_call(trusted_key_get_random)(payload->key, > >> + key_len); > >> + if (ret != key_len) { > >> + pr_info("trusted_key: key_create failed (%d)\n", ret); > >> + goto out; > >> + } > > > > This repeats a regression in existing code, i.e. does not check > > "ret < 0" condition. I noticed this now when I rebased the code > > on top of my fixes. > > > > I.e. it's fixed in my master branch, which caused a merge conflict, > > and I found this. > > Does that mean this series will go out for the next merge window? > Can you point me where your git tree is, so I can rebase on top? No I mean the bug that is propagated here is fixed in my master branch, i.e. get_random() should check also '< 0' condition. /Jarkko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel