From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52277C433DB for ; Mon, 15 Feb 2021 12:35:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C79F64DEC for ; Mon, 15 Feb 2021 12:35:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C79F64DEC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JD4lLYKfJsB7v4UkC5+zBuzr4CUpu2/il/b+F1Dal9A=; b=cfDMkTEL6iWPy2EFUCw0s32QV eDuEq7Vb/vJeQOrp5/OypyT3yqhc8Nb/BGxduqC17GkaSM9QhVcTx96JrhcwzsAMD9PYkzYig9oj0 S/HfamE6neX8EHWHm//adWZDAU7lGdUJUqYfEY3Ras0sPiRgSAOnbJbXR15V/VJexWfzDX5JWp+ij mgYS2mhF2GMrUQ9t2VCU/9R8isWUU4XLTCIXradSQuj3rWnoJWmQcrADSUEJqmxKQzi1BU9mSbAFo ac9S3WAZ9lG6pV77pQhwuWoL7y/LiLt4aCa9730MQGjLQwQgipoPRRmfs8t+7rZKl5/eqf7UBJtmP e489H8Eew==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lBd5Q-0002cO-Eq; Mon, 15 Feb 2021 12:34:44 +0000 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lBd5L-0002b7-7s for linux-arm-kernel@lists.infradead.org; Mon, 15 Feb 2021 12:34:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613392478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v3v4gzqGCLWwc72/ZmFhajN3/IbvocJsej92j7sOSm8=; b=QP5aOjWkSNWTidxuFGE8sIuwvQYbeu/MS+9nUxZyOQr7KazYJn6mL235KNY7RxNZW+tJ2s +eJENnOrM39qscoZtphKozmRyk7pBwhjYFLk2hdQBVE+T+87ceFpH+mlkmk8fp9u5womt0 +wizO98x4DZcrOXbJKHSLgZQGuuS060= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-86-5cdKoN1WNhiffgIsjL3VVg-1; Mon, 15 Feb 2021 07:34:36 -0500 X-MC-Unique: 5cdKoN1WNhiffgIsjL3VVg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6798C1937FC0; Mon, 15 Feb 2021 12:34:34 +0000 (UTC) Received: from krava (unknown [10.40.195.239]) by smtp.corp.redhat.com (Postfix) with SMTP id 7BD3B19CAB; Mon, 15 Feb 2021 12:34:31 +0000 (UTC) Date: Mon, 15 Feb 2021 13:34:30 +0100 From: Jiri Olsa To: Shunsuke Nakamura Subject: Re: [PATCH v6 2/3] perf tools: Add lexical definition of event name Message-ID: References: <20210212090318.1522292-1-nakamura.shun@jp.fujitsu.com> <20210212090318.1522292-3-nakamura.shun@jp.fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210212090318.1522292-3-nakamura.shun@jp.fujitsu.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210215_073439_315012_B1873866 X-CRM114-Status: GOOD ( 17.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, mathieu.poirier@linaro.org, peterz@infradead.org, john.garry@huawei.com, linux-kernel@vger.kernel.org, acme@kernel.org, alexander.shishkin@linux.intel.com, mingo@redhat.com, leo.yan@linaro.org, namhyung@kernel.org, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 12, 2021 at 06:03:17PM +0900, Shunsuke Nakamura wrote: > Add the lexical definition of event name so that the numbers are recognizable. > > A64FX defines an event name that starts with a number. > - 0inst_commit > - 1inst_commit > - 2inst_commit > - 3inst_commit > - 4inst_commit > > Signed-off-by: Shunsuke Nakamura > --- > tools/perf/util/parse-events.l | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l > index 0b36285a9435..33f627187415 100644 > --- a/tools/perf/util/parse-events.l > +++ b/tools/perf/util/parse-events.l > @@ -205,7 +205,7 @@ bpf_source [^,{}]+\.c[a-zA-Z0-9._]* > num_dec [0-9]+ > num_hex 0x[a-fA-F0-9]+ > num_raw_hex [a-fA-F0-9]+ > -name [a-zA-Z_*?\[\]][a-zA-Z0-9_*?.\[\]]* > +name [a-zA-Z0-9_*?\[\]][a-zA-Z0-9_*?.\[\]]* I can't see anything broken because of this change, also numbers are defined few lines before so we should be fine but please add test for this to tests/parse-events.c, if you could also add test for 'VALUE:VALUE' event, that'd be fantastic ;-) thanks, jirka > name_tag [\'][a-zA-Z_*?\[\]][a-zA-Z0-9_*?\-,\.\[\]:=]*[\'] > name_minus [a-zA-Z_*?][a-zA-Z0-9\-_*?.:]* > drv_cfg_term [a-zA-Z0-9_\.]+(=[a-zA-Z0-9_*?\.:]+)? > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel