From: Thierry Reding <thierry.reding@gmail.com>
To: Jitao Shi <jitao.shi@mediatek.com>
Cc: linux-pwm@vger.kernel.org, srv_heupstream@mediatek.com,
huijuan.xie@mediatek.com, stonea168@163.com,
linux-kernel@vger.kernel.org, cawa.cheng@mediatek.com,
ck.hu@mediatek.com, linux-mediatek@lists.infradead.org,
bibby.hsieh@mediatek.com,
Matthias Brugger <matthias.bgg@gmail.com>,
yingjoe.chen@mediatek.com, eddie.huang@mediatek.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] pwm: mtk_disp: clear the clock operations
Date: Mon, 22 Feb 2021 15:29:36 +0100 [thread overview]
Message-ID: <YDO/0Onf6a09YRsP@ulmo.localdomain> (raw)
In-Reply-To: <20210130141226.25357-2-jitao.shi@mediatek.com>
[-- Attachment #1.1: Type: text/plain, Size: 802 bytes --]
On Sat, Jan 30, 2021 at 10:12:24PM +0800, Jitao Shi wrote:
> Remove the clk_prepare from mtk_disp_pwm_probe.
> Remove the clk_unprepare from mtk_disp_pwm_remove.
>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> ---
> drivers/pwm/pwm-mtk-disp.c | 23 ++---------------------
> 1 file changed, 2 insertions(+), 21 deletions(-)
It's not clear *why* you're doing this change. It's already obvious from
the changes in this patch that you're removing the calls to
clk_prepare() and clk_unprepare(), so instead of duplicating that
information in the commit message, take this opportunity to describe why
this change is needed. Without any further context, this would seem to
just break operation of this chip because now these clocks are never
enabled in the first place.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-22 14:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-30 14:12 [PATCH v2 0/3] Convert the mtk_disp driver to aotmic API Jitao Shi
2021-01-30 14:12 ` [PATCH v2 1/3] pwm: mtk_disp: clear the clock operations Jitao Shi
2021-02-22 14:29 ` Thierry Reding [this message]
2021-05-26 1:54 ` Jitao Shi
2021-01-30 14:12 ` [PATCH v2 2/3] pwm: mtk_disp: convert the driver to atomic API Jitao Shi
2021-01-30 14:12 ` [PATCH v2 3/3] pwm: mtk_disp: implement .get_state() Jitao Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDO/0Onf6a09YRsP@ulmo.localdomain \
--to=thierry.reding@gmail.com \
--cc=bibby.hsieh@mediatek.com \
--cc=cawa.cheng@mediatek.com \
--cc=ck.hu@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=huijuan.xie@mediatek.com \
--cc=jitao.shi@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=srv_heupstream@mediatek.com \
--cc=stonea168@163.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox