From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAAD0C433E0 for ; Mon, 22 Feb 2021 18:40:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C44964DF2 for ; Mon, 22 Feb 2021 18:40:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C44964DF2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sigxcpu.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Hw+MLvyjlIY0vXa2zHLitHo2G1pxY/pdWFSysYNtC9I=; b=LLzUsP/JhWn5IzjlW+ShKLMCS iDU1/I0+CIDC8bC3p0LYoyIctqntV5nPhjVdDTWyGw4iYP4j6fm1MF1axmdB+iRCNHAesc5csCUw1 Vku8wZAektLEpf6RDCSMa3/jbXAAohTeq+VdzBPMS4oew/SzckyBcoP1i6QGxOj/05wA/VvM/2J0m Fr8V0ZfCRnP8Ioyx4oMDp8bTVEUV+xtpfs/7767euLFo/vIcoi3XSbd/rE3v29VGutcR8qDd9ECfW 3YBfftz17XjvIFpCX/mjH7jql0Dl1DzXRBg5mskgbSC+7WaLM8bW7nNnTfXds1ppD4ph6fatMYIPx zglUFlILA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEG6z-0002Vh-To; Mon, 22 Feb 2021 18:39:14 +0000 Received: from honk.sigxcpu.org ([24.134.29.49]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEG6w-0002UE-Oh for linux-arm-kernel@lists.infradead.org; Mon, 22 Feb 2021 18:39:11 +0000 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id 9D595FB05; Mon, 22 Feb 2021 19:39:09 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KYsFArh9S4Nr; Mon, 22 Feb 2021 19:39:07 +0100 (CET) Date: Mon, 22 Feb 2021 19:39:06 +0100 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Liu Ying Subject: Re: [PATCH v2 1/1] phy: fsl-imx8-mipi-dphy: Hook into runtime pm Message-ID: References: <424af315b677934fe6a91cee5a0a7aee058245a9.camel@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <424af315b677934fe6a91cee5a0a7aee058245a9.camel@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210222_133910_956253_177DAD10 X-CRM114-Status: GOOD ( 25.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sam Ravnborg , Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , NXP Linux Team , Pengutronix Kernel Team , Robert Chiras , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Liu, On Sat, Feb 20, 2021 at 01:37:29PM +0800, Liu Ying wrote: > Hi Guido, > = > On Wed, 2020-12-16 at 12:27 +0100, Guido G=FCnther wrote: > > This allows us to shut down the mipi power domain on the imx8. The > > alternative would be to drop the dphy from the mipi power domain in the > > SOCs device tree and only have the DSI host controller visible there but > > since the PD is mostly about the PHY that would defeat it's purpose. > > = > > This allows to shut off the power domain hen blanking the LCD panel: > > = > > pm_genpd_summary before: > > = > > domain status slaves > > /device runtime status > > ---------------------------------------------------------------------- > > mipi on > > /devices/platform/soc@0/soc@0:bus@30800000/30a00300.dphy unsupport= ed > > /devices/platform/soc@0/soc@0:bus@30800000/30a00000.mipi_dsi suspe= nded > > = > > after: > > = > > mipi off-0 > > /devices/platform/soc@0/soc@0:bus@30800000/30a00300.dphy suspended > > /devices/platform/soc@0/soc@0:bus@30800000/30a00000.mipi_dsi suspe= nded > > = > > Signed-off-by: Guido G=FCnther > > --- > > .../phy/freescale/phy-fsl-imx8-mipi-dphy.c | 22 ++++++++++++++++++- > > 1 file changed, 21 insertions(+), 1 deletion(-) > > = > > diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c b/drivers/p= hy/freescale/phy-fsl-imx8-mipi-dphy.c > > index a95572b397ca..34e2d801e520 100644 > > --- a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > > +++ b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > > @@ -14,6 +14,7 @@ > > #include > > #include > > #include > > +#include > > #include > > = > > /* DPHY registers */ > > @@ -93,6 +94,7 @@ struct mixel_dphy_cfg { > > }; > > = > > struct mixel_dphy_priv { > > + struct device *dev; > > struct mixel_dphy_cfg cfg; > > struct regmap *regmap; > > struct clk *phy_ref_clk; > > @@ -382,6 +384,7 @@ static int mixel_dphy_power_on(struct phy *phy) > > ret =3D clk_prepare_enable(priv->phy_ref_clk); > > if (ret < 0) > > return ret; > > + pm_runtime_get_sync(priv->dev); > > = > > phy_write(phy, PWR_ON, DPHY_PD_PLL); > > ret =3D regmap_read_poll_timeout(priv->regmap, DPHY_LOCK, locked, > > @@ -395,6 +398,7 @@ static int mixel_dphy_power_on(struct phy *phy) > > = > > return 0; > > clock_disable: > > + pm_runtime_put(priv->dev); > > clk_disable_unprepare(priv->phy_ref_clk); > > return ret; > > } > > @@ -406,6 +410,7 @@ static int mixel_dphy_power_off(struct phy *phy) > > phy_write(phy, PWR_OFF, DPHY_PD_PLL); > > phy_write(phy, PWR_OFF, DPHY_PD_DPHY); > > = > > + pm_runtime_put(priv->dev); > > clk_disable_unprepare(priv->phy_ref_clk); > > = > > return 0; > > @@ -467,6 +472,7 @@ static int mixel_dphy_probe(struct platform_device = *pdev) > > dev_dbg(dev, "phy_ref clock rate: %lu\n", > > clk_get_rate(priv->phy_ref_clk)); > > = > > + priv->dev =3D dev; > > dev_set_drvdata(dev, priv); > > = > > phy =3D devm_phy_create(dev, np, &mixel_dphy_phy_ops); > > @@ -477,12 +483,26 @@ static int mixel_dphy_probe(struct platform_devic= e *pdev) > > phy_set_drvdata(phy, priv); > > = > > phy_provider =3D devm_of_phy_provider_register(dev, of_phy_simple_xla= te); > > + if (IS_ERR(phy_provider)) > > + return PTR_ERR(phy_provider); > > = > > - return PTR_ERR_OR_ZERO(phy_provider); > > + pm_runtime_enable(dev); > = > If this enablement is done prior to devm_phy_create(), then the > phy-core will manage runtime PM for this device. This way, this driver > doesn't have to manage it by itself. That makes things simpler indeed. Fixed in v4 together with your other comment. Thanks! -- Guido > = > Regards, > Liu Ying > = > > + > > + return 0; > > +} > > + > > +static int mixel_dphy_remove(struct platform_device *pdev) > > +{ > > + struct mixel_dphy_priv *priv =3D platform_get_drvdata(pdev); > > + > > + pm_runtime_disable(priv->dev); > > + > > + return 0; > > } > > = > > static struct platform_driver mixel_dphy_driver =3D { > > .probe =3D mixel_dphy_probe, > > + .remove =3D mixel_dphy_remove, > > .driver =3D { > > .name =3D "mixel-mipi-dphy", > > .of_match_table =3D mixel_dphy_of_match, > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel