From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19FC4C433DB for ; Sun, 14 Mar 2021 16:48:46 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEB2E64DE8 for ; Sun, 14 Mar 2021 16:48:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEB2E64DE8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SZtu5hUmedgqIwylQZZ9+B2tRgYtUzXBq1K91nWtKUU=; b=MevH7HuzLhFbbb6Zu2yFUUZCJ i0QQldZDuJqGbtMejTKBNxi5gFj3hjHkizmsNFRKXjMwF5FPrH25oMXSYnKu8CcgwkCLksW4WSjUC pb1kwQ5MbQjBvI2aIdQfB1hjPgT2xMXO/jTMfzCo/0kU3+JkxQzzNTdUDjCU6XqloI9hEl3SaE90R 7gaoF2+or+W6YZKkNZN9Q7I2i0QxMEmEmrvJUtXXl+2Jbh5F26wQeXynga7vzg/VJlxOovgnRSOrN gBfKfrse3DP/UPWqn9pH7/aqwsvCCyqthFTWw4FC/y4qU6TYDFf+P2yEtHmqNEXf+o8DzTQ+j/20I H6SqLDCBw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lLTtf-00EM2e-7r; Sun, 14 Mar 2021 16:47:19 +0000 Received: from muru.com ([72.249.23.125]) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lLTta-00EM2I-QS for linux-arm-kernel@lists.infradead.org; Sun, 14 Mar 2021 16:47:16 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 1804580B4; Sun, 14 Mar 2021 16:48:00 +0000 (UTC) Date: Sun, 14 Mar 2021 18:47:10 +0200 From: Tony Lindgren To: linux-omap@vger.kernel.org Cc: Carl Philipp Klemm , Ivan Jelincic , Merlijn Wajer , Sebastian Reichel , Pavel Machek , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: OMAP4: Fix cpu_pm handling for HS/EMU interrupt save Message-ID: References: <20210225121612.18818-1-tony@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210225121612.18818-1-tony@atomide.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210314_164715_127297_76A23A4C X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Tony Lindgren [210225 14:22]: > Since commit 55be2f50336f ("ARM: OMAP2+: Handle errors for cpu_pm") we > allow the drivers to block deeper idle states with cpu_pm notifiers. > Turns out this change causes random hangs on a mostly idle droid4. > > The hang seems to be caused by reconfiguring the MPUSS domain registers > after we have already called irq_save_secure_context(). This happens > on the cpu_pm notifier error path if a driver is busy and returns > NOTIFY_BAD in CPU_CLUSTER_PM_ENTER handling to block the deeper idle > states. Note that this issue does not exist for the GP SoCs, for them > we just save and restore the context in the cpu_pm notifier. > > Let's fix the issue by calling omap4_irq_save_secure_context() later on > after the cpu_pm notifiers are done. And since we have omap-secure.c, > let's move omap4_irq_save_secure_context() there. FYI, this is not the right fix and won't really help it turns out. Based on testing for about a week on two devices, looks like the right fix is: [PATCH] ARM: OMAP4: PM: update ROM return address for OSWR and OFF Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel