From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58B03C433E0 for ; Fri, 5 Mar 2021 17:31:25 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0106C6507A for ; Fri, 5 Mar 2021 17:31:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0106C6507A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=e2j4D9p9WSU7AMjSnX2ynGm7uS4VVDhUwFcsNCWywNY=; b=WBEj3RMk3In2wpTPID7Z7yOri 3JbplavmOHSmXm4y5TsJ+/qWV8oX/Xz2ka5lU2frhXZzhBTY4t14jlx15lDv7nsgwOC9pctzXt95n tfgSs1uqbRLfPyjHBbfYn2woUWsq1x1gE/1Ix7GNCs78m1AexzcvCx7Ljg9YtRctDw5UYOIKtoNDu 9qPd0qHT32ZYha+Hb6Nf1qPnbvOVjkvgansKBWpu2apMZ5p4gxsXytkWUuMjKXpRzEk+7lX4+Vws6 Z1IWmtLGvEtZvFqF7khK2YQc857Y5m0A5rr56UNCj8DioWAxZdPbN5ioWvK3cJx8o+jk9Ub9OJ224 TIi8omqjA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lIEGw-00Fn9x-7E; Fri, 05 Mar 2021 17:29:54 +0000 Received: from [177.35.17.230] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lIEGr-00Fn8E-48; Fri, 05 Mar 2021 17:29:49 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 6AC4040647; Fri, 5 Mar 2021 14:29:44 -0300 (-03) Date: Fri, 5 Mar 2021 14:29:44 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Mathieu Poirier , Suzuki K Poulose , Mike Leach , Jonathan Corbet , John Garry , Will Deacon , Peter Zijlstra , Ingo Molnar , Mark Rutland , Jiri Olsa , Namhyung Kim , Daniel Kiss , Denis Nikitin , Al Grant , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/8] perf cs-etm: Fix bitmap for option Message-ID: References: <20210206150833.42120-1-leo.yan@linaro.org> <20210206150833.42120-5-leo.yan@linaro.org> <20210208204641.GE2077938@xps15> <20210209015855.GA54680@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210209015855.GA54680@leoy-ThinkPad-X240s> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Tue, Feb 09, 2021 at 09:58:55AM +0800, Leo Yan escreveu: > On Mon, Feb 08, 2021 at 01:46:41PM -0700, Mathieu Poirier wrote: > > On Sat, Feb 06, 2021 at 11:08:29PM +0800, Leo Yan wrote: > > > From: Suzuki K Poulose > > > > > > When set option with macros ETM_OPT_CTXTID and ETM_OPT_TS, it wrongly > > > takes these two values (14 and 28 prespectively) as bit masks, but > > > actually both are the offset for bits. But this doesn't lead to > > > further failure due to the AND logic operation will be always true for > > > ETM_OPT_CTXTID / ETM_OPT_TS. > > > > > > This patch defines new independent macros (rather than using the > > > "config" bits) for requesting the "contextid" and "timestamp" for > > > cs_etm_set_option(). > > > > > > [leoy: Extract the change as a separate patch for easier review] > > > > This should go just above your name - see below. I fixed this up and added this patch to my perf/urgent branch, for v5.12, since the kernel bits are upstream and this is a fix. Looking at the other patches in the series. - Arnaldo > > > Signed-off-by: Suzuki K Poulose > > > Signed-off-by: Leo Yan > > > Reviewed-by: Mike Leach > > > > Signed-off-by: Suzuki K Poulose > > [Extract the change as a separate patch for easier review] > > Signed-off-by: Leo Yan > > Reviewed-by: Mike Leach > > > > > --- > > > tools/perf/arch/arm/util/cs-etm.c | 12 ++++++++---- > > > 1 file changed, 8 insertions(+), 4 deletions(-) > > > > > > diff --git a/tools/perf/arch/arm/util/cs-etm.c b/tools/perf/arch/arm/util/cs-etm.c > > > index bd446aba64f7..c25c878fd06c 100644 > > > --- a/tools/perf/arch/arm/util/cs-etm.c > > > +++ b/tools/perf/arch/arm/util/cs-etm.c > > > @@ -156,6 +156,10 @@ static int cs_etm_set_timestamp(struct auxtrace_record *itr, > > > return err; > > > } > > > > > > +#define ETM_SET_OPT_CTXTID (1 << 0) > > > +#define ETM_SET_OPT_TS (1 << 1) > > > +#define ETM_SET_OPT_MASK (ETM_SET_OPT_CTXTID | ETM_SET_OPT_TS) > > > + > > > > I would much rather see this fixed with the BIT() macro as it is done in the > > rest of this set than defining new constant. > > > > With the above: > > > > Reviewed-by: Mathieu Poirier > > > > I have picked up the kernel portion of this set. I suggest you fix the above > > and send another revision to Arnaldo with my RBs. > > Will do this. Thanks for suggestion, Mathieu. > > Leo > > [...] -- - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel