From: Jiri Olsa <jolsa@redhat.com>
To: "nakamura.shun@fujitsu.com" <nakamura.shun@fujitsu.com>
Cc: John Garry <john.garry@huawei.com>,
"will@kernel.org" <will@kernel.org>,
"mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>,
"leo.yan@linaro.org" <leo.yan@linaro.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"acme@kernel.org" <acme@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 2/4] perf tools: Add lexical definition of event name
Date: Sat, 6 Mar 2021 20:14:13 +0100 [thread overview]
Message-ID: <YEPUhZPoUZrzGvaJ@krava> (raw)
In-Reply-To: <OSBPR01MB4600C6910F2AFFC5819C8145F7969@OSBPR01MB4600.jpnprd01.prod.outlook.com>
On Fri, Mar 05, 2021 at 10:09:20AM +0000, nakamura.shun@fujitsu.com wrote:
> Hi, John
>
> > > From: Shunsuke Nakamura <nakamura.shun@jp.fujitsu.com>
> > >
> > > Add the lexical definition of event name so that the numbers are recognizable.
> > >
> >
> > Sorry for the hassle, but it's not clear that we got a definitive
> > conclusion on this patch from v6 series:
> >
> > https://lore.kernel.org/lkml/YCuo01Wxxe%2FMCrC5@krava/
> >
> > Would it be so much worse for you to change format of these event names
> > to not start with a numberic?
> I was trying to match the specifications published by Fujitsu exactly.
> We also thought that being able to parse event names starting with a number would be an improvement for perf.
> We've discussed it with the team, but we decided to change the event name.
hum, I'm not sure what's the final decision in here.. are you keeping
numbers in the start? would be much easier if you did not ;-)
jirka
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-06 19:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 3:26 [PATCH v7 0/4] perf vendor events: Support PMU events for A64FX Shunsuke Nakamura
2021-03-04 3:26 ` [PATCH v7 1/4] perf vendor events arm64: Add more common and uarch events Shunsuke Nakamura
2021-03-04 3:26 ` [PATCH v7 2/4] perf tools: Add lexical definition of event name Shunsuke Nakamura
2021-03-04 9:34 ` John Garry
2021-03-05 10:09 ` nakamura.shun
2021-03-06 19:14 ` Jiri Olsa [this message]
2021-03-08 3:19 ` nakamura.shun
2021-03-04 3:26 ` [PATCH v7 3/4] perf vendor events arm64: Add Fujitsu A64FX pmu event Shunsuke Nakamura
2021-03-04 3:26 ` [PATCH v7 4/4] perf test: Add test for event name starting with a number Shunsuke Nakamura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEPUhZPoUZrzGvaJ@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=john.garry@huawei.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=nakamura.shun@fujitsu.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).