From: "Krzysztof Wilczyński" <kw@linux.com>
To: 'Wei Yongjun <weiyongjun1@huawei.com>
Cc: "Nicolas Saenz Julienne" <nsaenzjulienne@suse.de>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Bjorn Helgaas" <helgaas@kernel.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Rafał Miłecki" <rafal@milecki.pl>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
kernel-janitors@vger.kernel.org, "Hulk Robot" <hulkci@huawei.com>
Subject: Re: [PATCH -next] PCI: brcmstb: Fix error return code in brcm_pcie_probe()
Date: Mon, 8 Mar 2021 15:49:40 +0100 [thread overview]
Message-ID: <YEY5hLEAqnI23DSW@rocinante> (raw)
In-Reply-To: <20210308135619.19133-1-weiyongjun1@huawei.com>
Hi,
[...]
> if (pcie->type == BCM4908 && pcie->hw_rev >= BRCM_PCIE_HW_REV_3_20) {
> dev_err(pcie->dev, "hardware revision with unsupported PERST# setup\n");
> + ret = -ENODEV;
> goto fail;
[...]
Nice catch!
Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
Thank you!
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-08 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 13:56 [PATCH -next] PCI: brcmstb: Fix error return code in brcm_pcie_probe() 'Wei Yongjun
2021-03-08 14:49 ` Krzysztof Wilczyński [this message]
2021-03-08 16:34 ` Florian Fainelli
2021-03-22 17:50 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEY5hLEAqnI23DSW@rocinante \
--to=kw@linux.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=helgaas@kernel.org \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=nsaenzjulienne@suse.de \
--cc=p.zabel@pengutronix.de \
--cc=rafal@milecki.pl \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox