From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41E64C433E0 for ; Mon, 8 Mar 2021 23:37:46 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8E8F65290 for ; Mon, 8 Mar 2021 23:37:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8E8F65290 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P6MlzshoKTTRNsBkv5wcfiNWh7MLiLZ1j5ReY/IuFqg=; b=mDkfhuNtsyy334L0X3NBMxs2F NS7fUV8q0lZLf+WIoVvNvbdmGDD1F2X4mMNDcApAQtF8seCzPmqFMVwASTCMtNpN4otuAE6UUyqAQ yYZMYubt+jF5Y8q3Dec/ll/AhQtZdbKeq7COqxSZXqYZXDY+dU99G25YhDwZZXR2e7gGb/4My5J7w F0BJjGQXjPyTdt4iEPx5vwZlD7DvQDz6E+v86dUvPBwYEf/A56dJFE2iLidF3Ct2SoIkgMP0BBAu4 NB1jpGH96sgO5vFmAcRrL+ZjXemku6NazhJk2sD60dNmgQ7wI/mdZHyyiwoHogGkRWzlZV0YOOT+3 A73RLl1eQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJPPu-003Njx-DG; Mon, 08 Mar 2021 23:36:02 +0000 Received: from mail-wr1-f49.google.com ([209.85.221.49]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJPPp-003NjN-JA; Mon, 08 Mar 2021 23:35:59 +0000 Received: by mail-wr1-f49.google.com with SMTP id h98so13212994wrh.11; Mon, 08 Mar 2021 15:35:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=K67rR2cz1Q7CfHsvPx+dMATB9DP+9YT/J61wglUubUU=; b=Om2TXl82Kwx0GJMOAtsmmWF6Gpt8u0PE8ag4GnoQpWjXhbL4ZQbTynlASMSvG7sQv3 4KKdG1N5DHkLXLG5It74mVsPVAXLWYfBIKlsXBooq5U2/EQUdwim3RWRH6op1W/koyXk scTj6LhwB4vdBJOxBMNGx3RALa1qj+r28X0WoPUgcjtn/IgYbzep5HrZkolAbCNtOYc+ Hc8lRPaerB+H++83TbAyB3KhfI+JXIJ8mBd45Vr9yuzEfjg54LMA99r7XXCZ2rx3JS+s PefY81y2igWj0x4ZTj+FYd1OPTxRcXGWlsYFyua6mwc29hnEwqUjQp3oPTrTOyhVuasf 1LwA== X-Gm-Message-State: AOAM531L7X/Ait5c/Fohh1fSFhHPGywaC4Uj/X8lfKf/1UBXGWTMmmXy 1VMViD/84/D+tD7WxySGapQ= X-Google-Smtp-Source: ABdhPJxIo5ED286zGo5sDuM1NNSlbW7hAT37M57yIHfxV5NJ+vlrAPXSTvl4w23Q5VzJFHh51Jut6A== X-Received: by 2002:adf:fb05:: with SMTP id c5mr5345694wrr.302.1615246556238; Mon, 08 Mar 2021 15:35:56 -0800 (PST) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id u3sm20897860wrt.82.2021.03.08.15.35.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 15:35:55 -0800 (PST) Date: Tue, 9 Mar 2021 00:35:54 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Jim Quinlan Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Florian Fainelli , Philipp Zabel , Jim Quinlan , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v4 2/2] nPCI: brcmstb: Use reset/rearm instead of deassert/assert Message-ID: References: <20210308195037.1503-1-jim2101024@gmail.com> <20210308195037.1503-3-jim2101024@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210308195037.1503-3-jim2101024@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210308_233557_726381_B05DAF7A X-CRM114-Status: UNSURE ( 9.57 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Thank you for sending the patches over! > The Brcmstb PCIe RC uses a reset control "rescal" for certain chips. This [...] A small suggestion: it would be nicer to mention "Broadcom STB" rather than "Brcmstb" in the sentence above. [...] > +err1: > + reset_control_rearm(pcie->rescal); > +err0: > clk_disable_unprepare(pcie->clk); > return ret; [...] A small nitpick. Now that there are two labels on the error recovery path, it might be better to name both of these labels a little bit better. Some examples from the PCI tree: error_clock_unprepare err_disable_clock err_disable_clk err_clk_disable So it could be: err_reset: <-- or err_rearm or even err_reset_rearm, etc. reset_control_rearm(pcie->rescal); err_disable_clk: clk_disable_unprepare(pcie->clk); What do you think? Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel