From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85F9AC433E1 for ; Fri, 26 Mar 2021 07:47:10 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 09ADE61992 for ; Fri, 26 Mar 2021 07:47:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 09ADE61992 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4eHNXRfuc8jlOLKDo7q5D/phhu2yd8mIlW1qgpjunVo=; b=WHvoSGH0ZbEiRdQkD/g1Iry0f ALJAkxPsx39/x+Bf8o6OwPnAKQQ3jqlyuh2pcHMGNy7SwX/ZCITbkTXYNmh044uFGTr4MhTnU1EQt +wqX7fIFxYVChEQmGKp6XUElUVV3mN32VIdDPMLzRfT8yG+PPlrnyUimSI+49XiCz761QKM1+pibU lxL+wpOFpovXg1ayPla6PzTKSjCP8tYIPn+lBXIvetrgE35AihBkivU3vH2ItnQ9yhxIgiMd+geGT KzeR1nCwWi/gsCe3AdnH6NYE+WF5ye1lUeAW1mPUFnZDmYYzoFmqB9aASXu5NnBVHNJBHUmoui5R9 ++JbtNp5w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPhAD-002yaT-0L; Fri, 26 Mar 2021 07:45:49 +0000 Received: from mail-lj1-f182.google.com ([209.85.208.182]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPhA9-002yZz-9k for linux-arm-kernel@lists.infradead.org; Fri, 26 Mar 2021 07:45:46 +0000 Received: by mail-lj1-f182.google.com with SMTP id u10so6313840lju.7 for ; Fri, 26 Mar 2021 00:45:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ywvkB00IvDFZV6YQmhIhOKybvJUh+b6uDebafNOLRY4=; b=KfWURlZ6It6cOVU7L9HEOtmBdmCVZEg/caVn3AuJJpx1UzHkee/fviPh7+yHoAeJo5 i46Wyy15U/HbyUg6uS5LN9tNymsivSCvROQDJyRQ2uD4TbCSB7FXhnNX/Qsi6tsSmQ9J /Nl0ABeIUaRAM88pPhlOJZZ+0b7tlPI3ox+wp2DblIAeBoK6lqPY0FbhVMKNDRcSzYsr l17Rxabb/mAwoguNTEe/Tju2J1LWHPYqGjK1ksKu2gTqKC3dGggNqes9ruNNaYc7Jmjk Q/uZrm0Z7xdGQOS+h+5c6QZp9iSVM6WaUmOetr+xTFvAD4bNHJZ2sOEjWNR71aJwINN+ m6CA== X-Gm-Message-State: AOAM533x40Wzygafo5zRt7xtdevOCKvj4nodskjBit297wG/qzI4wZ1a uhhhS5/NZrOVhEIFXL3CDoM= X-Google-Smtp-Source: ABdhPJwb3jQF3cra0pp3V4N320JYWJhuowVizCovesrIxUIVKTNdHrrBqTXg/XyD25OMivTB6AbI8g== X-Received: by 2002:a2e:9bd0:: with SMTP id w16mr8167587ljj.465.1616744743808; Fri, 26 Mar 2021 00:45:43 -0700 (PDT) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id o82sm784730lfa.21.2021.03.26.00.45.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 00:45:43 -0700 (PDT) Date: Fri, 26 Mar 2021 08:45:42 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Richard Zhu Cc: l.stach@pengutronix.de, andrew.smirnov@gmail.com, shawnguo@kernel.org, bhelgaas@google.com, stefan@agner.ch, lorenzo.pieralisi@arm.com, linux-pci@vger.kernel.org, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH v3 3/3] PCI: imx: clear vreg bypass when pcie vph voltage is 3v3 Message-ID: References: <1616661882-26487-1-git-send-email-hongxing.zhu@nxp.com> <1616661882-26487-4-git-send-email-hongxing.zhu@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1616661882-26487-4-git-send-email-hongxing.zhu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210326_074545_429531_85113B9F X-CRM114-Status: UNSURE ( 8.71 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, > + /* > + * Regarding to the datasheet, the PCIE_VPH is suggested > + * to be 1.8V. If the PCIE_VPH is supplied by 3.3V, the > + * VREG_BYPASS should be cleared to zero. > + */ [...] A small nitpick here. What about the following: Regarding the data sheet, the PCIE_VPH is suggested to be 1.8V. If the PCIE_VPH is supplied with 3.3V, the VREG_BYPASS should be cleared to zero. What do you think? Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel