From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A66DBC433DB for ; Tue, 16 Mar 2021 11:32:57 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A7AE64ED2 for ; Tue, 16 Mar 2021 11:32:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A7AE64ED2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fTHeTKrqlWLBIid9hUU4yodkWjSUNPl99NuF7Bk/lVc=; b=jkVXxB3HNKebhNTj4IbgUryb0 TTkXbeesv9Dxd62K3+6Tu0uF6qbiAywf4iatNXItbfHuHzHUKQsxXXeQQFwv2WlXSv5HxdkLuyuuJ 3GPUwOEG6mifQCm0TrYtZYegcmBImgv9qHFDfVkeNrp86Da92OAtykYxF9wrZJmtFnoRwKf7Zgt+E /VfyxvTM4qYyJfSPDCcrVjYOjLkWCrI58mhah8NjTAJNzAhjiVRKTpkhlhX08o8x4qEhn+vhgBFsy KbojdF7t8g6Wv5kRhTaZSph/xCAulo8OxXmlrBmgrdX22gujNJffFm1TVsG54gKqNS292ZjthYjyh YF+qerlTA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lM7vM-000aTk-3s; Tue, 16 Mar 2021 11:31:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lM7v4-000aP6-1N for linux-arm-kernel@lists.infradead.org; Tue, 16 Mar 2021 11:31:39 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id AB4B564ED2; Tue, 16 Mar 2021 11:31:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615894284; bh=/1wbkg2dCZqybDXCZgAdrsXjyaUVO/A5ZZTYvmkn8Ck=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fwAx788MXiFEsTW2UdN5X899XiI1QvdHGG+mozrxIlelVHZVlT1j6FtVkhYv1SU5V IpU5cgmYCyxXP5ITvP3C8lGm+DEZthd2rkFgKbuHZ/BD9tpnnjz3vrvubnqjI7QNYY BrR4UCTh30E7uJZYw9xJY5aMZPUIygo7/L+DZin8= Date: Tue, 16 Mar 2021 12:31:21 +0100 From: Greg KH To: Vladimir Murzin Cc: linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, maz@kernel.org, dbrazdil@google.com Subject: Re: [PATCH][for-stable-v5.11]] arm64: Unconditionally set virtual cpu id registers Message-ID: References: <20210316112500.85268-1-vladimir.murzin@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210316112500.85268-1-vladimir.murzin@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210316_113126_387093_218C983B X-CRM114-Status: UNSURE ( 8.74 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 16, 2021 at 11:25:00AM +0000, Vladimir Murzin wrote: > Commit 78869f0f0552 ("arm64: Extract parts of el2_setup into a macro") > reorganized el2 setup in such way that virtual cpu id registers set > only in nVHE, yet they used (and need) to be set irrespective VHE > support. Lack of setup causes 32-bit guest stop booting due to MIDR > stay undefined. > > Fixes: 78869f0f0552 ("arm64: Extract parts of el2_setup into a macro") > Signed-off-by: Vladimir Murzin > --- > > There is no upstream fix since issue went away due to code there has > been reworked in 5.12: nVHE comes first, so virtual cpu id register > are always set. > > Maintainers, please, Ack. Why not just use the "rework" patch instead that fixes this issue? that's always preferred instead of one-off patches. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel