From: Sasha Levin <sashal@kernel.org>
To: Will Deacon <will@kernel.org>
Cc: Vladimir Murzin <vladimir.murzin@arm.com>,
linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org,
catalin.marinas@arm.com, maz@kernel.org, dbrazdil@google.com
Subject: Re: [PATCH v2][for-stable-v5.11] arm64: Unconditionally set virtual cpu id registers
Date: Thu, 18 Mar 2021 08:57:00 -0400 [thread overview]
Message-ID: <YFNOHKX6V4dkwWIp@sashalap> (raw)
In-Reply-To: <20210317132614.GB5225@willie-the-truck>
On Wed, Mar 17, 2021 at 01:26:15PM +0000, Will Deacon wrote:
>On Tue, Mar 16, 2021 at 01:43:19PM +0000, Vladimir Murzin wrote:
>> Commit 78869f0f0552 ("arm64: Extract parts of el2_setup into a macro")
>> reorganized el2 setup in such way that virtual cpu id registers set
>> only in nVHE, yet they used (and need) to be set irrespective VHE
>> support.
>>
>> Fixes: 78869f0f0552 ("arm64: Extract parts of el2_setup into a macro")
>> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
>> ---
>> Changelog
>>
>> v1 -> v2
>> - Drop the reference to 32bit guests from commit message (per Marc)
>>
>> There is no upstream fix since issue went away due to code there has
>> been reworked in 5.12: nVHE comes first, so virtual cpu id register
>> are always set.
>>
>> Maintainers, please, Ack.
>>
>> arch/arm64/include/asm/el2_setup.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>Acked-by: Will Deacon <will@kernel.org>
>
>It's a bit weird to have a patch in stable that isn't upstream, but I don't
>see a better option here.
Yes, I'd agree here - the commits that would need to be backported look
way too invasive.
I've queued it up, thanks.
--
Thanks,
Sasha
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-18 13:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 13:43 [PATCH v2][for-stable-v5.11] arm64: Unconditionally set virtual cpu id registers Vladimir Murzin
2021-03-16 13:52 ` Marc Zyngier
2021-03-17 13:26 ` Will Deacon
2021-03-18 12:57 ` Sasha Levin [this message]
2021-03-19 9:45 ` Greg KH
2021-03-19 9:45 ` Patch "arm64: Unconditionally set virtual cpu id registers" has been added to the 5.11-stable tree gregkh
2021-03-19 9:52 ` Patch "arm64: Unconditionally set virtual cpu id registers" has been added to the 4.14-stable tree gregkh
2021-03-19 9:58 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFNOHKX6V4dkwWIp@sashalap \
--to=sashal@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dbrazdil@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vladimir.murzin@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).