From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F9BBC433DB for ; Thu, 25 Mar 2021 07:32:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8AC4619BA for ; Thu, 25 Mar 2021 07:32:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8AC4619BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Xvvuq/V2OWJDW9arnMHSLoEBm3GWD/Nhk+e27qf0NzI=; b=hFZsGdqKlr6A5Ao6aRoDPxAIQ flQa92EN/MgUSEnuG/ukqb870KMxhPuE8RvOt0/cDy2nC+7+5Ham4SG5yEV09JVq1GlNjDzquruel mTwh0Gvo3br56GeZ3Ja0o98URSG4gUPYreEsrm5eTLtMu51ygyEMadAHnFcxGSjImArFSBzmNhpVF rTyskmM0MzHUuZr9+85sslfKoxbwhdwv49gzVoNYTVsUNr732QsteSGa9Y8+qI/WjgHpFLIhXORw0 VnWTpMkHNHlHGn5mTNLCzl7mWVBI/bWpjPGRiPcZOJjx+TaItNZ7cSY12+UwhBeJcZKfAR/3g9QA9 oFgWEwHcw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPKQY-000nLs-EJ; Thu, 25 Mar 2021 07:29:10 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPKQR-000nJu-6s for linux-arm-kernel@lists.infradead.org; Thu, 25 Mar 2021 07:29:07 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id B80A861554; Thu, 25 Mar 2021 07:29:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616657341; bh=Mr+BDr76BpJXyUusio9MRTC9Cg69ld5vy7wOR2RmRsM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T7atfcBnwjv20i25mhZKHFRB7JQGurVZ2sjsGo6k4fQUQFbzNzhnNsaj9Z1lbDVtl KBNgs1u48j0yPUjp0yTIYN5GUaZ4LnzLQ7rYSW4kN7b1/3lTMtM9ZCa0gZhvMJUJ2g y4NSX1F1mGZDbp+PGqwHP0uNQOCkL6WMgCfltuf8HSPqdg3UMK+vI746ZGSJ/XD3mn wdBc02PZFjSlH2zPRLroJeyOOCgIuFTGJtB0P7u6JlMYi8L6rCZ8qvL2SmLJUOmCpL hdVPO6vvMq6CZsbAsLTd+aAOvCI4KXcEhql7m+Pf9/AY9w8golgBD2YY0cuZRY0Uok lFYF/6rLBY4dA== Date: Thu, 25 Mar 2021 12:58:57 +0530 From: Vinod Koul To: Liu Ying Cc: Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, a.hajda@samsung.com, narmstrong@baylibre.com, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@siol.net, airlied@linux.ie, daniel@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, agx@sigxcpu.org, robert.chiras@nxp.com, martin.kepplinger@puri.sm, robert.foss@linaro.org Subject: Re: [PATCH v4 2/5] phy: Add LVDS configuration options Message-ID: References: <1615175541-29009-1-git-send-email-victor.liu@nxp.com> <1615175541-29009-3-git-send-email-victor.liu@nxp.com> <6c52ebc6a027cbe309ed2c8848f2ae8cfa6e15f4.camel@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6c52ebc6a027cbe309ed2c8848f2ae8cfa6e15f4.camel@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210325_072905_542315_7F36AA2A X-CRM114-Status: GOOD ( 13.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18-03-21, 10:22, Liu Ying wrote: > > Can we have these in kernel-doc style please, similar to style in linux/phy/phy.h > > I take this way of in-line member documentation comment for the below 3 > reasons: > > 1) Members of struct phy_configure_opts_mipi_dphy and > struct phy_configure_opts_dp use the same way of comment. > The structures are defined in linux/phy/phy-mipi-dphy.h and > linux/phy/phy-dp.h respectively. > Aligning to them makes a bit sense, IMHO. > > 2) In-line member documentation comments[1] are mentioned in kernel-doc > guide. It says 'The structure members may also be documented in-line > within the definition.'. > > 3) Even the 'configure' and 'validate' members of struct phy_ops use > the same way of comment. struct phy_ops is defined in linux/phy/phy.h. > > [1] > https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html#in-line-member-documentation-comments It 'may be' but I would like all headers of a subsystem to display one style. As I said linux/phy/phy.h use a style which we should use everywhere. Thanks -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel