From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DE2BC433ED for ; Wed, 7 Apr 2021 13:13:08 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CA2B6103E for ; Wed, 7 Apr 2021 13:13:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CA2B6103E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=x+JEGwRP34Jc27M55bmG9SOQZXiIiDL9GsRndrStsBI=; b=ZbZ/00N3QFw9kexieTL1px4xH hcK43OcXe4yyNbQLdbaFKBxVi3gWOE5L/yVdtJKimToLXdD+OcfjS0BQGeYcswp6niLlDw5CxBSuP aBt0AdwwEBafNMzr6qPXxRUSKWLyBgOUeD5dfBL7uWRNpa01mvUJpMZYeqhNIDS/mZCN3RFlbVtnF NdZBfbNMgGSCCEcFPC3Xj7rGvJdvRpRhTqnl2TcsHLD7/huK3NLiod8OwTBm4diJdBOesSMRXIXGh fqBKSv3xxXXtoFmyH6fETZgImi9A9BFUMfgCP/JK7XZzbJdID3bgmI4bRNOapCP/15ItN8EZo9Fu7 FMoKcUP1g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lU7xw-0050yh-HY; Wed, 07 Apr 2021 13:11:28 +0000 Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lU7xu-0050y1-1z; Wed, 07 Apr 2021 13:11:26 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id D42DB40647; Wed, 7 Apr 2021 10:11:23 -0300 (-03) Date: Wed, 7 Apr 2021 10:11:23 -0300 From: Arnaldo Carvalho de Melo To: John Garry Cc: will@kernel.org, mathieu.poirier@linaro.org, leo.yan@linaro.org, peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, irogers@google.com, linuxarm@huawei.com, kjain@linux.ibm.com, kan.liang@linux.intel.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, zhangshaokun@hisilicon.com, pc@us.ibm.com Subject: Re: [PATCH v3 0/6] perf arm64 metricgroup support Message-ID: References: <1617791570-165223-1-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1617791570-165223-1-git-send-email-john.garry@huawei.com> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Wed, Apr 07, 2021 at 06:32:44PM +0800, John Garry escreveu: > This series contains support to get basic metricgroups working for > arm64 CPUs. > > Initial support is added for HiSilicon hip08 platform. > > Some sample usage on Huawei D06 board: > > $ ./perf list metric Thanks, applied. - Arnaldo > List of pre-defined events (to be used in -e): > > Metrics: > > bp_misp_flush > [BP misp flush L3 topdown metric] > branch_mispredicts > [Branch mispredicts L2 topdown metric] > core_bound > [Core bound L2 topdown metric] > divider > [Divider L3 topdown metric] > exe_ports_util > [EXE ports util L3 topdown metric] > fetch_bandwidth_bound > [Fetch bandwidth bound L2 topdown metric] > fetch_latency_bound > [Fetch latency bound L2 topdown metric] > fsu_stall > [FSU stall L3 topdown metric] > idle_by_icache_miss > > $ sudo ./perf stat -v -M core_bound sleep 1 > Using CPUID 0x00000000480fd010 > metric expr (exe_stall_cycle - (mem_stall_anyload + armv8_pmuv3_0@event\=0x7005@)) / cpu_cycles for core_bound > found event cpu_cycles > found event armv8_pmuv3_0/event=0x7005/ > found event exe_stall_cycle > found event mem_stall_anyload > adding {cpu_cycles -> armv8_pmuv3_0/event=0x7001/ > mem_stall_anyload -> armv8_pmuv3_0/event=0x7004/ > Control descriptor is not initialized > cpu_cycles: 989433 385050 385050 > armv8_pmuv3_0/event=0x7005/: 19207 385050 385050 > exe_stall_cycle: 900825 385050 385050 > mem_stall_anyload: 253516 385050 385050 > > Performance counter stats for 'sleep': > > 989,433 cpu_cycles # 0.63 core_bound > 19,207 armv8_pmuv3_0/event=0x7005/ > 900,825 exe_stall_cycle > 253,516 mem_stall_anyload > > 0.000805809 seconds time elapsed > > 0.000875000 seconds user > 0.000000000 seconds sys > > perf stat --topdown is not supported, as this requires the CPU PMU to > expose (alias) events for the TopDown L1 metrics from sysfs, which arm > does not do. To get that to work, we probably need to make perf use the > pmu-events cpumap to learn about those alias events. > > Metric reuse support is added for pmu-events parse metric testcase. > This had been broken on power9 recently: > https://lore.kernel.org/lkml/20210324015418.GC8931@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com/ > > Differences to v2: > - Add TB and RB tags (Thanks!) > - Rename metricgroup__find_metric() from metricgroup_find_metric() > - Change resolve_metric_simple() to rescan after any insert > > Differences to v1: > - Add pmu_events_map__find() as arm64-specific function > - Fix metric reuse for pmu-events parse metric testcase > > John Garry (6): > perf metricgroup: Make find_metric() public with name change > perf test: Handle metric reuse in pmu-events parsing test > perf pmu: Add pmu_events_map__find() > perf vendor events arm64: Add Hisi hip08 L1 metrics > perf vendor events arm64: Add Hisi hip08 L2 metrics > perf vendor events arm64: Add Hisi hip08 L3 metrics > > tools/perf/arch/arm64/util/Build | 1 + > tools/perf/arch/arm64/util/pmu.c | 25 ++ > .../arch/arm64/hisilicon/hip08/metrics.json | 233 ++++++++++++++++++ > tools/perf/tests/pmu-events.c | 83 ++++++- > tools/perf/util/metricgroup.c | 12 +- > tools/perf/util/metricgroup.h | 3 +- > tools/perf/util/pmu.c | 5 + > tools/perf/util/pmu.h | 1 + > tools/perf/util/s390-sample-raw.c | 4 +- > 9 files changed, 356 insertions(+), 11 deletions(-) > create mode 100644 tools/perf/arch/arm64/util/pmu.c > create mode 100644 tools/perf/pmu-events/arch/arm64/hisilicon/hip08/metrics.json > > -- > 2.26.2 > -- - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel