From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99683C433ED for ; Wed, 7 Apr 2021 16:21:25 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24DA761130 for ; Wed, 7 Apr 2021 16:21:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24DA761130 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dxoSVJqW4/bBKGryyZ4jrywvpUSM8162umdk2tnt19w=; b=od9nppZ0x3pqG3w1Qkl3+3/CQ l6fgb1WEn6Gv+suHRoy3hSAq1WCftjM0DN4GrPVDSz0IcPqrWH9eJyC9r7nAxGUWNVK2l0TGsnb7T f4oBkbAt7IAyLR9t5Xyl7zk3p3y3FbbXgAt8NVBewKEudXUsSxNdf5g9dICY6oyJvctIw7OLXNU1i EzIY5t9zUWAyCU3n3kS2iBu1rRgXSHKRCzxNvkBWp3aYw9q9cnWjGx9Oh6vB/2XbNejNZs0Ad4lUm JwRA8Z4/KuC3zooTq3z4w/56Uh8V4qWVBuhQZ05eXejXPRf5Ae8vjKG403cb0eMvwjyv5QtO3KsTY rGBIXrEzA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUAuJ-005Rbc-DX; Wed, 07 Apr 2021 16:19:55 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUAuC-005RaC-KV for linux-arm-kernel@lists.infradead.org; Wed, 07 Apr 2021 16:19:52 +0000 X-Originating-IP: 90.65.108.55 Received: from localhost (lfbn-lyo-1-1676-55.w90-65.abo.wanadoo.fr [90.65.108.55]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 4FFBBC000C; Wed, 7 Apr 2021 16:19:45 +0000 (UTC) Date: Wed, 7 Apr 2021 18:19:44 +0200 From: Alexandre Belloni To: Krzysztof Kozlowski Subject: Re: [PATCH] memory: atmel-sdramc: check of_device_get_match_data() return value Message-ID: References: <20210407154447.70540-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210407154447.70540-1-krzysztof.kozlowski@canonical.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210407_171950_153398_643FAC8E X-CRM114-Status: GOOD ( 18.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ludovic Desroches , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 07/04/2021 17:44:47+0200, Krzysztof Kozlowski wrote: > If the driver is probed, the of_device_get_match_data() should not > return NULL, however for sanity check its return value. > As you say, there is no way this will ever be the case, I don't see the point of checking the return value, this adds 12 bytes for nothing... Maybe coverity should be fixed as there are many drivers making the same (true) assumption and I don't think this is worth the churn. > Addresses-Coverity: Dereference null return value > Signed-off-by: Krzysztof Kozlowski > --- > drivers/memory/atmel-sdramc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/memory/atmel-sdramc.c b/drivers/memory/atmel-sdramc.c > index 9c49d00c2a96..e09b2617f63d 100644 > --- a/drivers/memory/atmel-sdramc.c > +++ b/drivers/memory/atmel-sdramc.c > @@ -45,6 +45,8 @@ static int atmel_ramc_probe(struct platform_device *pdev) > struct clk *clk; > > caps = of_device_get_match_data(&pdev->dev); > + if (!caps) > + return -EINVAL; > > if (caps->has_ddrck) { > clk = devm_clk_get(&pdev->dev, "ddrck"); > -- > 2.25.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel