From: Petr Mladek <pmladek@suse.com>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Christoph Hellwig <hch@infradead.org>,
peter enderborg <peter.enderborg@sony.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Baoquan He <bhe@redhat.com>, Borislav Petkov <bp@alien8.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Dave Young <dyoung@redhat.com>, Evan Green <evgreen@chromium.org>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Ingo Molnar <mingo@redhat.com>, Jessica Yu <jeyu@kernel.org>,
Jiri Olsa <jolsa@kernel.org>,
kexec@lists.infradead.org,
Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sasha Levin <sashal@kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vivek Goyal <vgoyal@redhat.com>, Will Deacon <will@kernel.org>,
x86@kernel.org
Subject: Re: [PATCH v2 00/12] Add build ID to stacktraces
Date: Tue, 30 Mar 2021 12:59:23 +0200 [thread overview]
Message-ID: <YGMEi6i8ksa9+adD@alley> (raw)
In-Reply-To: <161671450646.3012082.10177164412320557022@swboyd.mtv.corp.google.com>
On Thu 2021-03-25 16:21:46, Stephen Boyd wrote:
> Quoting peter enderborg (2021-03-25 04:06:17)
> > On 3/24/21 9:55 AM, Christoph Hellwig wrote:
> > > On Tue, Mar 23, 2021 at 07:04:31PM -0700, Stephen Boyd wrote:
> > >> x5 : 0000000000000000 x4 : 0000000000000001
> > >> x3 : 0000000000000008 x2 : ffffff93fef25a70
> > >> x1 : ffffff93fef15788 x0 : ffffffe3622352e0
> > >> Call trace:
> > >> lkdtm_WARNING+0x28/0x30 [lkdtm ed5019fdf5e53be37cb1ba7899292d7e143b259e]
> > >> direct_entry+0x16c/0x1b4 [lkdtm ed5019fdf5e53be37cb1ba7899292d7e143b259e]
> > > Yikes. No, please do not make the backtraces a complete mess for
> > > something that serves absolutely no need.
>
> It serves a need. Please look at the patches to understand that I'm
> adding the buildid to automatically find the associated debug
> information on distros.
>
> >
> > Would a "verbose" flag be acceptable solution? Something like write 1 to /sys/kernel/debug/verbose_stack to get the extra info.
> >
> > I think I see a need for it.
> >
>
> Or a kernel config option and a commandline parameter? That would be OK
> for me as I said on v1 of this series. I'll add that in for the next
> patch series given all the distaste for some more hex characters next to
> the module name.
IMHO, a build configure option would fit the best here.
It does not make sense to show the ID when the kernel vendor does
not have a service to download the related binaries. But it makes
sense to show the buildid by default when the provider/distro has
the service and want to use the ID when handling bug reports.
We could always add boot/run time options when people really need it.
Best Regards,
Petr
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-30 11:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 2:04 [PATCH v2 00/12] Add build ID to stacktraces Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 05/12] arm64: stacktrace: Use %pSb for backtrace printing Stephen Boyd
2021-03-24 8:55 ` [PATCH v2 00/12] Add build ID to stacktraces Christoph Hellwig
2021-03-25 11:06 ` peter enderborg
2021-03-25 23:21 ` Stephen Boyd
2021-03-30 10:59 ` Petr Mladek [this message]
[not found] ` <32011616573677@mail.yandex-team.ru>
2021-03-24 19:04 ` Stephen Boyd
2021-03-25 11:14 ` peter enderborg
2021-03-25 23:18 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGMEi6i8ksa9+adD@alley \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ast@kernel.org \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dyoung@redhat.com \
--cc=evgreen@chromium.org \
--cc=hch@infradead.org \
--cc=hsinyi@chromium.org \
--cc=jeyu@kernel.org \
--cc=jolsa@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mingo@redhat.com \
--cc=peter.enderborg@sony.com \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox