From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FDB1C433B4 for ; Fri, 2 Apr 2021 11:20:06 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A09E60FE5 for ; Fri, 2 Apr 2021 11:20:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A09E60FE5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gxDM8jTYrPSkkG03lDf/gK7K0yqXdp+l5OH326DDVzA=; b=iloxiBCs2pfJjRpxvC4E3LjQI BCGtMWHQtqFNmCoO12gxyClHTEtVfhT41NpUj0jl6DskBgF3VJENdNPmVcqNcWz/pR7Y1v0oTYU3M rbvE7lorBD5d91q/J/GhAC9cuMX7uYJhlvL3nVBXKyCXGp1fZzzTBMSW1TWx+oUYdXfkAvZzHa4BA swpJPCcWc+JbPw4sldvAh+q0MCmiNN5/E3zWOoz4jHpPJ8VghMQMkeqiQAOuHvGSBldpwTMuKwNQv tL/wYKGzjIf3yEdMs9jzrbmxs71bfx4vNRgqcgVFQCleg6uSkxior9YTfNyQHDQB3kTckvjlPvEBJ BGNohu6kA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lSHoy-00Csya-O8; Fri, 02 Apr 2021 11:18:36 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lSHos-00Csxp-WC for linux-arm-kernel@lists.infradead.org; Fri, 02 Apr 2021 11:18:32 +0000 Received: by mail-wr1-x42c.google.com with SMTP id v4so4438751wrp.13 for ; Fri, 02 Apr 2021 04:18:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=8E3SEQHWtD9oyxpVQil1WLhWIN1NJ4aU8PFyBCEE/9I=; b=aqP3pMYBFohRF0lJwLR9OejAloqY6YrXbLNGYs9zFLgCv1MCuHZgj+iSPTeNoGQ12w EyDaCkMvX460y0dvE3hkVfUSuIwTGfroRpBN9oog6OWB4hEKvepYFFPE+VeWXB49iqN5 dLgN+ei3rW27jDeJ26Zb4HM1zjaSGDUIkBjN6VeHlwK42H0NEhOg/oAPO2e8+hbrglCe wFD0sJQ9wmT9rP2wWgsZ7iIi1RZNQMheo6Y9xqlezW7Mq2rwjKQKT6byD+VWJGctCxw6 xZcVGeNNDgjZ3a7OBtjjVcklPFudhVTg2Az6gV3ThEHsOoJQhKaV9EFaq/PKuz/32oWj 9MzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=8E3SEQHWtD9oyxpVQil1WLhWIN1NJ4aU8PFyBCEE/9I=; b=e3bumbOClb++8XcaRr8QzsIPdMXmktU9lqYEVySS/Nz4Da1e7j6ZHA9QbNuFIR4z7k 5wU3F2k+R22U3zs42hlpCIik8nedLc2NnpzAoJMrj2tW4C5stF/EmTBxHV4YXRt5n8X7 XNPMttMz1PW1n3eL+fDCVYDtk2udXkQW7aBpRQ/RnAe9VaBztQQcBPHux0PpGAiAauRt 9sgIRFtqB2AEdDWtREg32HMY/CrcWZ5hg1hADXQGE9mmUvmET5QZ+gbHSi7q8daHHXk4 7qdAzZyJxDUR176UvHJspzgWlt7ZtiKMLBXqgpXgbwLKcXx9ptcRYmmGFdKvwqzZCqP6 /Svw== X-Gm-Message-State: AOAM530mqqAeuS8jqP+9Hxot4qaSzgsV/ENwK+bLWNYTGHiyy7z5YT4S /Khpsxj7EY41Z57MCT07OAs= X-Google-Smtp-Source: ABdhPJy/iKJNXmT3yHCYQCxdWaBoVuhIXj+nmkcu/NqP7UPz3sLXzXCR2emtqZGn7Kl5Og+YTtZr2g== X-Received: by 2002:adf:b345:: with SMTP id k5mr15205746wrd.14.1617362308620; Fri, 02 Apr 2021 04:18:28 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id r10sm14279138wmh.45.2021.04.02.04.18.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Apr 2021 04:18:28 -0700 (PDT) Date: Fri, 2 Apr 2021 13:18:25 +0200 From: Corentin Labbe To: Colin King Cc: Herbert Xu , "David S . Miller" , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] crypto: sun8i-ss: Fix memory leak of pad Message-ID: References: <20210401151827.2015960-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210401151827.2015960-1-colin.king@canonical.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210402_121831_201719_B04EC45E X-CRM114-Status: UNSURE ( 9.71 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Le Thu, Apr 01, 2021 at 04:18:27PM +0100, Colin King a =E9crit : > From: Colin Ian King > = > It appears there are several failure return paths that don't seem > to be free'ing pad. Fix these. > = > Addresses-Coverity: ("Resource leak") > Fixes: d9b45418a917 ("crypto: sun8i-ss - support hash algorithms") > Signed-off-by: Colin Ian King > --- Hello Acked-by: Corentin Labbe Tested-by: Corentin Labbe Tested-on: sun8i-a83t-bananapi-m3 Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel