From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3187C433ED for ; Mon, 5 Apr 2021 07:05:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 502206139C for ; Mon, 5 Apr 2021 07:05:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 502206139C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T+JmJ6CYBPoH9baypIfprLoGgZ2PHcaf8yMnjcGd1Sg=; b=VbfDqJnBBjhBfJ78b/6Jm4Pin 3oo8/0C4vgruZ2HGgk6uMLtZObh5pgtIWJ/cF9vxf7ICWAZF28FBOqq9hTorsMzX/dJ/zah0zzlRj wGonGCZ3qtQFHZm+xVuwYkqTbSBMBc97qJSDufItbUyby2t+eCLW0b1yc+qtrxFR0atsoUQJr49xO cUGBnSBlAduVssZDWYy3iPQfwSsn321nCW3mdTpMHUI9O04fdUw2d5pJsmnHcwHTsP0VBDaY3usAB 0oD7OBTvvjyGSBi7N2Jkfd2pu18g5vArz8da0eSLRAJETxaNjvq6CUf3ibqSDkJVhKkgoWHVHMwdH z7SZov6eQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lTJGM-00GrAy-Lq; Mon, 05 Apr 2021 07:03:06 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lTJGI-00GrAO-Bm; Mon, 05 Apr 2021 07:03:04 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8FDC46127A; Mon, 5 Apr 2021 07:02:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617606180; bh=MdliucytokSp3MecjDPnzP9QyqT0IQR2NrcOeaanYOI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AvNnPD7+YSQoJ7H6oIG30ii5ErPrBPyMzYTmhs9zeORFx8KzCgcwYdflq78cZK3DI rLDbow1JAxlJ09qjTMrEUk+yG1qUVLWqrIJqa4BRlM0qd57FLNmNDsrKvUKFjHr7rD 1TiSWGHdiaIcsH/jpBeL5Oq4uhj4jwKugIi6jOmo= Date: Mon, 5 Apr 2021 09:02:57 +0200 From: Greg KH To: Johan Jonker Cc: heiko@sntech.de, robh+dt@kernel.org, balbi@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v6 1/4] usb: dwc3: of-simple: bail probe if no dwc3 child node Message-ID: References: <20210401213652.14676-1-jbx6244@gmail.com> <20210401213652.14676-2-jbx6244@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210401213652.14676-2-jbx6244@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210405_080302_674407_5698AD14 X-CRM114-Status: GOOD ( 18.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 01, 2021 at 11:36:49PM +0200, Johan Jonker wrote: > For some of the dwc3-of-simple compatible SoCs we > don't want to bind this driver to a dwc3 node, > but bind that node to the 'snps,dwc3' driver instead. > The kernel has no logic to decide which driver to bind > to if there are 2 matching drivers, so bail probe if no > dwc3 child node. > > Signed-off-by: Johan Jonker > --- > drivers/usb/dwc3/dwc3-of-simple.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c > index 71fd620c5..8d3baa5df 100644 > --- a/drivers/usb/dwc3/dwc3-of-simple.c > +++ b/drivers/usb/dwc3/dwc3-of-simple.c > @@ -38,6 +38,10 @@ static int dwc3_of_simple_probe(struct platform_device *pdev) > > int ret; > > + /* Bail probe if no dwc3 child node. */ > + if (!of_get_compatible_child(dev->of_node, "snps,dwc3")) > + return -ENODEV; Why is this part of the "convert to yaml" patch series? Shouldn't this be a separate, independant patch? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel