From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74284C433ED for ; Mon, 5 Apr 2021 12:46:05 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7F98613A3 for ; Mon, 5 Apr 2021 12:46:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7F98613A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cdisv2jaKhyH7J15Nz0g2xiI2qArAT5Tzsaj/4zwgKg=; b=abpio+GMBwld0wBm2R1/SC6FS 4VFOPIVG5fhyLlNXWNxih4rAJ3encp385eaU0zhIVfi1ioc4dKqvP2JLoniViNEKTdTAw6il3Sk9u iDFRoQo4NbfU73BnlZatPzfZWUxMT7IVzZBZb80+MYOju2K3GtliyDDp+CVUQl9SFZ2Utxhl9Dg9l kF9Yqzkq6AtSo2D+YioPomsLe6OvkcWaq42ILM/FwnmDYIH7rlANArT9WXilJC2ZL+aKRLpuF96B6 KAlFCB5YWUa2DgjtlHLVB5s8AUpMz3KzRT+dibcnZ8XQwiuIGdocQGueyVZe5ugw7Ro1/UHcHzG6i tzbnmlXCg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lTOZq-00HGYc-Ov; Mon, 05 Apr 2021 12:43:36 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lTOZm-00HGYA-Bk for linux-arm-kernel@lists.infradead.org; Mon, 05 Apr 2021 12:43:32 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lTOZV-00EvHl-4V; Mon, 05 Apr 2021 14:43:13 +0200 Date: Mon, 5 Apr 2021 14:43:13 +0200 From: Andrew Lunn To: "Voon, Weifeng" Cc: Russell King - ARM Linux admin , "Sit, Michael Wei Hong" , "peppe.cavallaro@st.com" , "alexandre.torgue@st.com" , "joabreu@synopsys.com" , "davem@davemloft.net" , "kuba@kernel.org" , "mcoquelin.stm32@gmail.com" , "Ong, Boon Leong" , "qiangqing.zhang@nxp.com" , "Wong, Vee Khee" , "fugang.duan@nxp.com" , "Chuah, Kim Tatt" , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "hkallweit1@gmail.com" Subject: Re: [PATCH net-next 1/2] net: stmmac: enable 2.5Gbps link speed Message-ID: References: <20210401150152.22444-1-michael.wei.hong.sit@intel.com> <20210401150152.22444-2-michael.wei.hong.sit@intel.com> <20210401151044.GZ1463@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210405_134330_510056_B5269750 X-CRM114-Status: GOOD ( 20.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 05, 2021 at 09:07:34AM +0000, Voon, Weifeng wrote: > > On Fri, Apr 02, 2021 at 07:45:04AM +0000, Voon, Weifeng wrote: > > > > > + /* 2.5G mode only support 2500baseT full duplex only */ > > > > > + if (priv->plat->has_gmac4 && priv->plat->speed_2500_en) { > > > > > + phylink_set(mac_supported, 2500baseT_Full); > > > > > + phylink_set(mask, 10baseT_Half); > > > > > + phylink_set(mask, 10baseT_Full); > > > > > + phylink_set(mask, 100baseT_Half); > > > > > + phylink_set(mask, 100baseT_Full); > > > > > + phylink_set(mask, 1000baseT_Half); > > > > > + phylink_set(mask, 1000baseT_Full); > > > > > + phylink_set(mask, 1000baseKX_Full); > > > > > > > > Why? This seems at odds to the comment above? > > > > > > > What about 2500baseX_Full ? > > > > > > The comments explain that the PCS<->PHY link is in 2500BASE-X and why > > > 10/100/1000 link speed is mutually exclusive with 2500. > > > But the connected external PHY are twisted pair cable which only > > > supports 2500baseT_full. > > > > The PHY should indicate what modes its supports. The PHY drivers > > get_features() call should set supported to only 2500baseT_Full, if that is > > all it supports. > > > > What modes are actually used should then be the intersect of what both the > > MAC and the PHY indicate they can do. > > Noted Andrew. Instead of masking the 10/100/1000 mode support in the MAC, we will > set the supported modes in the PCS. PCS? You said: > > > But the connected external PHY are twisted pair cable which only > > > supports 2500baseT_full. So it should be the PHY, not the PCS, which indicates it only supports 2500baseT_full. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel