Re: [PATCH 08/14] irqchip: Add driver for WPCM450 interrupt controller

Jonathan Neuschäfer
2021-04-05T17:28:17Z

[-- Attachment #1.1: Type: text/plain, Size: 675 bytes --]

On Fri, Mar 26, 2021 at 07:52:07PM +0100, Jonathan Neuschäfer wrote:
> On Wed, Mar 24, 2021 at 05:16:35PM +0000, Marc Zyngier wrote:
> > On Sat, 20 Mar 2021 18:16:04 +0000, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote:
[...]
> > > + /* Disable (mask) all interrupts */
> > > + writel(0xffffffff, aic->regs + AIC_MDCR);
> >
> > Consider using relaxed accessors throughout this driver.
>
> I'll read up on how to use them correctly.

Upon further consideration, I decided not to bother with relaxed MMIO
access, because it doesn't make a difference on the target platform —
Nuvoton WPCM450 with ARM926 (ARMv5).

Best regards,
Jonathan Neuschäfer

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]