From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4D46C433B4 for ; Tue, 20 Apr 2021 08:51:30 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8231E61027 for ; Tue, 20 Apr 2021 08:51:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8231E61027 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KA0HnGD5CDthteywkCI3Fyhl2srKn8iCL/dClnp2bvs=; b=KEgH0FjUQhPudpPeUdeGxD+qi /5hf4WwEmEPUg6/Aa66cqsO6CIfcAL/OJbGJsyNU0FDVb2pISXVjf3mSmjifxx6/JrRcJjhO+m2tJ s01E/EPs4glfXS30X3qkx2kD41CWTBgK3GT/0DFcQpe9dyMUwu+Pc3ucp0QIDweAW2Uv7mnVGkNNq IMcQ1Q3tUQZ/i06uv/zTeCfeMVJ7Jabw98tnGORBKV8Dm3nbSIwpxqNhl+UQDYsOpFuMphcPxuqlJ pM6i0hKiGNnRjXmYTwZtvl218UBmr186cbY6kaSwhnPddCCtOAykqZRX7rd9os8QPOuZqwx3zs/+y r10p+vGvQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYm3I-00BdNJ-LA; Tue, 20 Apr 2021 08:48:12 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYm3C-00BdMI-PX for linux-arm-kernel@desiato.infradead.org; Tue, 20 Apr 2021 08:48:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tcUH9BcoI5Si0JZ1eptAqXBWAigQeJ+C3f8VhpJEvVE=; b=OyVRYlDQCGCMp1cGoyT+8DCzDA VxyD/qS6yNBOdnkzpxHNMrFMF+Wk8PCh5ghFWvF7EsycxdWsG+pCfO+Rd5R9RpKBwQ2bJbuszN3Iu mWZcxAWGVy8chArLxQa/F4UFttkYrv9FF3c6T7RmayBChRt+GDupSrX10whTTb49C3BXVmAz5oQif nCCnV6iugfVx5u/4DKaGcUf5K/gGhA7ruJ09KQLX+liH6al98xm9wDVivIZrpiVDYA1h21qQ4qdbz cPv+lZhTpK0Ak9GxgD7dpce0pisDqIVtFm9rp+RQvVP4fPPce7OE4qa1euGdx1H6Te9EzP33b6Ta0 VCWJFFZQ==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYm38-00BwN2-Nf for linux-arm-kernel@lists.infradead.org; Tue, 20 Apr 2021 08:48:05 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7876D61027; Tue, 20 Apr 2021 08:48:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618908482; bh=f260+khxi9MZ5DGVsHjWtuxRuqw8oFO4BOQzbS1x+rI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I/4GMcboS3Qaf6IpCKpYDK+p/Ech95zihdFgi8Fn3Crv6RcIetjhtVTsmlS1Qw7xo 8cs9bzVSWaw9jSQ/mb3MKnLptutvM+mPu3c5ONLkr9yaNlrmrWsuV3USeGidGluAp8 H/bpFNEk5wC9zeySpuc9lF6e8Wv0DWtz7s1DmEJk= Date: Tue, 20 Apr 2021 10:47:58 +0200 From: Greg KH To: Nava kishore Manne Cc: robh+dt@kernel.org, michal.simek@xilinx.com, derek.kiernan@xilinx.com, dragan.cvetic@xilinx.com, arnd@arndb.de, rajan.vaja@xilinx.com, jolly.shah@xilinx.com, tejas.patel@xilinx.com, amit.sunil.dhamne@xilinx.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, chinnikishore369@gmail.com, git@xilinx.com Subject: Re: [PATCH 5/5] misc: zynqmp: Add afi config driver Message-ID: References: <20210420081153.17020-1-nava.manne@xilinx.com> <20210420081153.17020-6-nava.manne@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210420081153.17020-6-nava.manne@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210420_014802_837238_E4581C08 X-CRM114-Status: GOOD ( 18.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 20, 2021 at 01:41:53PM +0530, Nava kishore Manne wrote: > This patch adds zynqmp afi config driver.This is useful for > the configuration of the PS-PL interface on Zynq US+ MPSoC > platform. Again, please spell out what those terms mean, as I have no idea :( > > Signed-off-by: Nava kishore Manne > --- > drivers/misc/Kconfig | 11 ++++++ > drivers/misc/Makefile | 1 + > drivers/misc/zynqmp-afi.c | 83 +++++++++++++++++++++++++++++++++++++++ > 3 files changed, 95 insertions(+) > create mode 100644 drivers/misc/zynqmp-afi.c > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > index 877b43b3377d..d1ea1eeb3ac1 100644 > --- a/drivers/misc/Kconfig > +++ b/drivers/misc/Kconfig > @@ -456,6 +456,17 @@ config ZYNQ_AFI > between PS and PL, the AXI port data path should be configured > with the proper Bus-width values > > +config ZYNQMP_AFI > + tristate "Xilinx ZYNQMP AFI support" > + help > + ZynqMP AFI driver support for writing to the AFI registers for > + configuring PS_PL Bus-width. Xilinx Zynq US+ MPSoC connect the > + PS to the programmable logic (PL) through the AXI port. This AXI > + port helps to establish the data path between the PS and PL. > + In-order to establish the proper communication path between > + PS and PL, the AXI port data path should be configured with > + the proper Bus-width values Please use tabs properly, you mix them above, checkpatch should have caught that. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel