From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FCE6C433B4 for ; Mon, 12 Apr 2021 18:02:41 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EBC861042 for ; Mon, 12 Apr 2021 18:02:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EBC861042 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cs7d/Ps0ZKzEMeHr2KPMBp7GREHaCJHhXEKyEEdMPNE=; b=GNm4OrI3EK2XUDA3aiYTSsKdM BBTNpUovuVfI78Q1lqT7Vr8Cagi4IiBIVzSjazaWUJo4eQuTnQrA8S8CoOfowIBL7bkjmA31c4dIz 7plTje+gJFeiIdB3djytIwpukjASHsBzKRY5zkdqHVPlfuGR/WSpTac1tG+ZcKSn+Kzl9rUSNRXX0 oQAL2OLqDNi0TJyObTlk9HAV2cEEyT6MqstswspCh15s4e4lTcBqB30gB3N3eqNK83GI78BPBv/9E KNOe0KZWWZBaO63N9UKmFWov7DMa+7rE+jpr9R9tmvwo5860xK4rp+U7TuxKu7HspzRRaWUgBVEYP wQZjOpfAg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lW0sA-007P4j-Uv; Mon, 12 Apr 2021 18:01:19 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lW0s8-007P4W-39 for linux-arm-kernel@desiato.infradead.org; Mon, 12 Apr 2021 18:01:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fBrLQlmI4yEOGQkVisFheBSRcrkvWiTXgMrAzhkH4pI=; b=lRpOD7ytiMqlg7RmYxQmf4xMeZ DkjTxUSB90hJomerl6mMVbl9ONve3GY+syefEqJflR1sMg4V7AyVMGCXtbQ/CdS5qPutvVGQFYr9E 8n9ek9gnABgKzk+/kNU3EtnKVK4yF/3difSk2xmfpPh6RIrwKcBLJvR6Unntpv48miRkxrZNuntFM cw+EUEcUhfAsm8LXfKak4yY3r0ghRWeCAo8Vi4yB5kwMh8McbI3EP3DsFFIiTg7fsC6Y7Cekw9fhC sQOF2pV+aYGFiglqsuNhcVjHAbhxSLlDk8jI+v/CAwCftVBElTEknbxJ2Gjr1au8lyJAxfREDnpFh zTjDwn/g==; Received: from heinz.dinsnail.net ([81.169.187.250]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lW0s4-006TAQ-Up for linux-arm-kernel@lists.infradead.org; Mon, 12 Apr 2021 18:01:14 +0000 Received: from heinz.dinsnail.net ([IPv6:0:0:0:0:0:0:0:1]) by heinz.dinsnail.net (8.15.2/8.15.2) with ESMTP id 13CHj9LX011018; Mon, 12 Apr 2021 19:45:09 +0200 Received: from eldalonde.UUCP (uucp@localhost) by heinz.dinsnail.net (8.15.2/8.15.2/Submit) with bsmtp id 13CHj8VK011017; Mon, 12 Apr 2021 19:45:08 +0200 Received: from eldalonde.weiser.dinsnail.net (localhost [IPv6:0:0:0:0:0:0:0:1] (may be forged)) by eldalonde.weiser.dinsnail.net (8.15.2/8.15.2) with ESMTP id 13CHfPTn017403; Mon, 12 Apr 2021 19:41:25 +0200 Received: (from michael@localhost) by eldalonde.weiser.dinsnail.net (8.15.2/8.15.2/Submit) id 13CHfPj2017402; Mon, 12 Apr 2021 19:41:25 +0200 Date: Mon, 12 Apr 2021 19:41:25 +0200 From: Michael Weiser To: Andre Przywara Cc: Chen-Yu Tsai , Rob Herring , Maxime Ripard , Jernej Skrabec , devicetree , linux-arm-kernel , linux-sunxi , Daniel Kulesz Subject: Re: [linux-sunxi] [PATCH] arm64: dts: allwinner: Revert SD card CD GPIO for Pine64-LTS Message-ID: References: <20210412000813.13071-1-andre.przywara@arm.com> <20210412174558.4ba90cf8@slackpad.fritz.box> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210412174558.4ba90cf8@slackpad.fritz.box> X-dinsnail.net-MailScanner-Information: Please contact the ISP for more information X-dinsnail.net-MailScanner-ID: 13CHj9LX011018 X-dinsnail.net-MailScanner: Found to be clean X-dinsnail.net-MailScanner-From: michael@weiser.dinsnail.net X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210412_110113_433098_C169E0D7 X-CRM114-Status: GOOD ( 21.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andre, ChenYu, On Mon, Apr 12, 2021 at 05:45:58PM +0100, Andre Przywara wrote: > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts > > > index e79ce49e7e6a..843338e19694 100644 > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts > > > @@ -21,5 +21,5 @@ > > > }; > > > > > > &mmc0 { > > > - cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 push-push switch */ > > > + non-removable; /* card detect is broken on some boards */ > > > > So a revert is good, but has anyone tried using the "broken-cd" instead? > Ha, that's a good idea, I totally forgot about this property! > > That way, at least on Linux, the mmc core resorts to polling for a card. > > At least this way the card is still removable. > Yes indeed, I tested it on my "stuck at 1" Pine64-LTS, and it works like > a charm! > Daniel, Michael, can you test this on your boards? So removing the > cd-gpios property, and adding "broken-cd;" instead? Yes, it works fine. What flummoxed me at first was that obviously I also have to disable the ACTIVE_LOW definition in sun50i-a64-sopine.dtsi after having added and disabled an ACTIVE_HIGH definition in sun50i-a64-pine64-lts.dts. BTW: My boards have a marking "PINE64-R18-V1_1" and below it "2017-08-03" on their upper side. On the back it says on one sticker "Model:PineA64 2GB LTS" and on another "2O1-PINE64R18-00" and "PINE64-R18-V1.1 2G". Is CD being stuck at 1 a bug of revision 1.0 perhaps? Is there a way to detect this difference in software and add some sort of quirk handler for it? -- Thanks, Michael _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel