From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F35B1C433B4 for ; Wed, 14 Apr 2021 09:12:53 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B10861168 for ; Wed, 14 Apr 2021 09:12:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B10861168 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vc62UcSheyyAqdIP1AZlHH3OCBEZM6V4+CJcPdxJ7fA=; b=KsqbzFGRHFt8HkO+xP4hLedlm 6IWsuPcGWk8ZlcIGw7cqFodQZNDUZ4VRIOKOXD20fnjmH+OBzKMOowF5CH2tmVA3F7DkDAZ4BSBL/ Gage3Fll3GdIxjrvMJEudDdMJ/vyZgiZ13Nlk5VMaWIgZAUn8Lyx+7gowo8jNLHM7Y/e8MHr6dk22 BZDtvEVqC3zyLjW8xEy+FKkhQJLNn9GdKXBto4bdL/u8ZDBd1O2zo18vyrsFyppFNJPahaL492DSr mkjuy3EbFaGYleHnqXyfT32O1fY5hNDh0NWBdhZlKLGtoNjAvXkxbpGk6VphPg3b35zfn4xtRWzVC IiGrGv7XA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWbY4-00C6ON-DC; Wed, 14 Apr 2021 09:11:00 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWbY0-00C6No-5e for linux-arm-kernel@desiato.infradead.org; Wed, 14 Apr 2021 09:10:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xsQYX2UHTRaG1Vym45NrgNrdV4EUKH9oW8JvGS1IMYY=; b=Nr05TUgTi8h8bk8piyfNhe+4k1 rhkSRwXPTgjTI2dO+MTUtUnCDP6DXeEdHvS9iX6CWhyCXbiXAxFK8xhfvm94QfXQ4FWLWEvQDuY2M q1TxTyQXakzKj/ckIHtFmyPOxVfdLJl/cMskns+rI1+KQ+jruztLlZhBaGGYwlQ5YYiKKmVP5imiO 3S7klyOkX9XVP3R8LWANh7WMh+Xm06Ko9DAHoA712k7EAJwEG1moR2J414oOMNzRzJaOhTej3M3WR HIXPdAK74aoM+ZI+89jDR2sjsT+92YNk4glr+rSG3GCgtWJ9HXP7yUma+jziRGKcQV2IcQ5iQjBww yBB69jTw==; Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWbXw-007dv0-92 for linux-arm-kernel@lists.infradead.org; Wed, 14 Apr 2021 09:10:54 +0000 Received: by mail-wm1-x331.google.com with SMTP id w186so5663120wmg.3 for ; Wed, 14 Apr 2021 02:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xsQYX2UHTRaG1Vym45NrgNrdV4EUKH9oW8JvGS1IMYY=; b=aoXau1/tL0UuarbWeJEoRyF7u0YNWsS7WG34VfjL2OsY+mvp6dA2b8ofn7+jT4rAZJ mNlD9nYQyoqJP+Mave/iyaltyaBe0DW3YwUEKSpf797xQVpt776AwFuNHwN9OilD+gXu wW90zgCjrmLsyr7/rPn7mk4NbNHOaS3ksiWfM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xsQYX2UHTRaG1Vym45NrgNrdV4EUKH9oW8JvGS1IMYY=; b=IDAqaN+0zHJtxcIiUccUgBOjUddGJSy9KQcD8839hSMxWJmSHsmQiNsgPZVRppcCOL pcxR7sHwFB4DuSwKKKJN/9rcVgK/CgD3P9QvArCP1wFhNYDUvWDl1QXJGC1YZM1n2qOk GsxbladyKvd5cW6ijt5Fcd4pecmWZB/57Br6Yns978Q1PF8N55C0nYuCeXBihj9ldt4r Tq0QRxElZCVV5A1W1ZdesVU1TKKZH1YeeEOqrTsrjJ3Olg+kJzPBsa/7PI3/j0rhPTxz GSsaOJDzTQv6RgS6mP98RcbqQxPYKhC4YuhmppMRgR1ltsAh6yvt+bVpYlRIbn7Ycg+Q 5UGA== X-Gm-Message-State: AOAM532km+Q8Rwyo35nXd6V1DYb6ghB6B2wkQhfK6WgE4CU1ZCqQtW+B YiMFPiJ0DQMdZ7xO63HBEool7Q== X-Google-Smtp-Source: ABdhPJwmXoRmvMh89AnahmLC2e0I/Y6U+Jr4qUNzw+RsZa37BBNREfDXVI1QrkiIoxUzktM8lukOnQ== X-Received: by 2002:a1c:ac02:: with SMTP id v2mr1975777wme.111.1618391448838; Wed, 14 Apr 2021 02:10:48 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id l9sm4359704wmq.2.2021.04.14.02.10.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Apr 2021 02:10:48 -0700 (PDT) Date: Wed, 14 Apr 2021 11:10:46 +0200 From: Daniel Vetter To: Liu Ying Cc: Lucas Stach , Daniel Vetter , Daniel Vetter , DRI Development , Pengutronix Kernel Team , Intel Graphics Development , NXP Linux Team , Daniel Vetter , Shawn Guo , Sascha Hauer , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly Message-ID: References: <20210413094904.3736372-1-daniel.vetter@ffwll.ch> <20210413094904.3736372-5-daniel.vetter@ffwll.ch> <290aef5ed13749d465eb19235aa87a2cef63dd2a.camel@pengutronix.de> <83a41b2e9636cb6a790b23843c6d2628d02c6997.camel@pengutronix.de> <9395e1fde2725d4fe01c206d9172b8acd7cdf921.camel@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9395e1fde2725d4fe01c206d9172b8acd7cdf921.camel@nxp.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210414_021052_339884_CEBD605D X-CRM114-Status: GOOD ( 37.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 14, 2021 at 10:24:22AM +0800, Liu Ying wrote: > Hi Daniel, > > On Tue, 2021-04-13 at 16:14 +0200, Lucas Stach wrote: > > Am Dienstag, dem 13.04.2021 um 16:04 +0200 schrieb Daniel Vetter: > > > On Tue, Apr 13, 2021 at 01:47:28PM +0200, Lucas Stach wrote: > > > > Am Dienstag, dem 13.04.2021 um 11:48 +0200 schrieb Daniel Vetter: > > > > > Since > > > > > > > > > > commit 890880ddfdbe256083170866e49c87618b706ac7 > > > > > Author: Paul Kocialkowski > > > > > Date: Fri Jan 4 09:56:10 2019 +0100 > > > > > > > > > > drm: Auto-set allow_fb_modifiers when given modifiers at plane init > > > > > > > > > > this is done automatically as part of plane init, if drivers set the > > > > > modifier list correctly. Which is the case here. > > > > > > > > > > This one actually set it twice on top of what drm_plane_init does, so > > > > > double-redundant! > > > > > > > > That's not true. imx-dcss and imx-drm are two totally separate drivers. > > > > Maybe we should move imx-drm into its own ipuv3 directory one day to > > > > make this more clear. Change is still correct, though. > > > > > > Hm I greeped for drm_universal_plane_init and didn't find anythinf for the > > > imx main driver ... where are planes set up for that? Need to review that > > > they have the modifiers listed in all cases. > > > > That's in drivers/gpu/drm/imx/ipuv3-plane.c and modifiers are always > > set on plane init. Oh I didn't grep for the new drmm_universal_plane_alloc. Thanks for pointing this out. > > > > Regards, > > Lucas > > > > > > Reviewed-by: Lucas Stach > > > > > > > > > Signed-off-by: Daniel Vetter > > > > > Cc: Philipp Zabel > > > > > Cc: Shawn Guo > > > > > Cc: Sascha Hauer > > > > > Cc: Pengutronix Kernel Team > > > > > Cc: Fabio Estevam > > > > > Cc: NXP Linux Team > > > > > Cc: linux-arm-kernel@lists.infradead.org > > > > > --- > > > > > drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 - > > > > > drivers/gpu/drm/imx/imx-drm-core.c | 1 - > > Nit: Since this patch touches two totally separate drivers(imx-dcss and > imx-drm), it would be good to split it into two patches. I think if you expect that, then you need to move the imx-drm driver into a subdirectory like dcss. And like e.g. drm/msm works too. As-is this is just kinda confusing for people not involved in imx. -Daniel > > Thanks, > Liu Ying > > > > > > 2 files changed, 2 deletions(-) > > > > > > > > > > diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c > > > > > index b549ce5e7607..37ae68a7fba5 100644 > > > > > --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c > > > > > +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c > > > > > @@ -52,7 +52,6 @@ static void dcss_kms_mode_config_init(struct dcss_kms_dev *kms) > > > > > config->min_height = 1; > > > > > config->max_width = 4096; > > > > > config->max_height = 4096; > > > > > - config->allow_fb_modifiers = true; > > > > > config->normalize_zpos = true; > > > > > > > > > > > > > > > > > > > > > > > > > config->funcs = &dcss_drm_mode_config_funcs; > > > > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c > > > > > index 2ded8e4f32d0..8be4edaec958 100644 > > > > > --- a/drivers/gpu/drm/imx/imx-drm-core.c > > > > > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > > > > > @@ -209,7 +209,6 @@ static int imx_drm_bind(struct device *dev) > > > > > drm->mode_config.max_height = 4096; > > > > > drm->mode_config.funcs = &imx_drm_mode_config_funcs; > > > > > drm->mode_config.helper_private = &imx_drm_mode_config_helpers; > > > > > - drm->mode_config.allow_fb_modifiers = true; > > > > > drm->mode_config.normalize_zpos = true; > > > > > > > > > > > > > > > > > > > > > > > > > ret = drmm_mode_config_init(drm); > > > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel