From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02B8EC433B4 for ; Thu, 15 Apr 2021 01:30:17 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 675F460FF1 for ; Thu, 15 Apr 2021 01:30:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 675F460FF1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atmark-techno.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mqguv7DYe4VdSr290EwYOhemp8CNPWvCtvlN6cgPb2o=; b=k3hkuJ5c6naHetEbOkYO7T5q+ 9eeBajMu88HeNQhFoxTW1VvcwF3bRRa8S0/cm52ImqSglfuNsbp1fKcglXL9tTBP5A1mNXkw3Wxn4 oVm2GIi6Adqk51WAsOfpeGWz/CvG1uARqRN+7AZcdXB4xlhZWOIgNazH//dun8zjKehgxx/Z1RTwu y/xdnXaKxh2LSYNTRf7EOC0IrBqfkXU+11kAq6K975KZ58JvI6NbarsaQlPCBO3kdvz6cYhYCFA9T IGjqxZcuiTTS4tqzy9zNVJJEs1s1Kw5HJvt/iAjpATPTZCD2uO7Ro205+AFq2wRI1Wr94s2c0xTJ7 EvS3us9Sw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWqnv-00EQ9p-SZ; Thu, 15 Apr 2021 01:28:24 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWqnr-00EQ9K-8g for linux-arm-kernel@desiato.infradead.org; Thu, 15 Apr 2021 01:28:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FOM9b0pdtnYk8Fnx4fGxxS9X4Bl0c34VqGJkMkPLCys=; b=NdCItQqVN8F/WikuY7P5oicvg8 uivOe17AdUpigmnRU6fH4CCrA/kgSL54qG7aZ3+dh9K7iVtiEyLAB9P+1s5TOH8H3FLdxvgP8qE+b beFarYTj1byXi8NKBOGmbtaUZoyZQSga4MQdAk0AqRHzdObWhoWsZjlSjAuzfEYnSJ9uYQSa7WNQo ilYrMUiXftEGzCuhFHPmI3a36MPnl2UplUSu10oJvqHOHr99wLHOPbswXTqYgy3X7ytH+Fl9f8avN k2le4EKLgqqBMbqvM25vSjhLKroEKAa++ekHWjX0lqx6uYpfsVDZZtfuUaS93153UYStaZEftpzNC FVNfUXCQ==; Received: from gw.atmark-techno.com ([13.115.124.170]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWqno-008CyQ-2w for linux-arm-kernel@lists.infradead.org; Thu, 15 Apr 2021 01:28:17 +0000 Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by gw.atmark-techno.com (Postfix) with ESMTPS id 99AD080491 for ; Thu, 15 Apr 2021 10:28:12 +0900 (JST) Received: by mail-pg1-f200.google.com with SMTP id x12-20020a63f70c0000b0290202e04d4af8so529322pgh.1 for ; Wed, 14 Apr 2021 18:28:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FOM9b0pdtnYk8Fnx4fGxxS9X4Bl0c34VqGJkMkPLCys=; b=aZfepVyBEgocdkUaAnGZAstIgzOgEupv91vjON8ap1gmeSm/2j8C9Tlb/H87iC3d8U i+qjvv6xx72kBs2o8K1pDEypNbKcyYYN+f5xA4lfKVpzqHQRt8PXBYDMBai4N+9ZQn1E Wh6v42TwGBwrwHitRExJs51fTtkt4X3VCzkX3USbAN2z+4Ozypp6psEQYaCUfnr9e8Ae Qd89D2MqWdZmY88jKhlZjhCAEf+pFh26pMtZsDRYD2Ap4IKmtH9X8rwdqOxuZbNtiTbt fpg423QHBclYYOvNsxLXqYS22aNMVgM7ofKZO5T9VM4IHP6C0uX0v6c1BF9Aq7Ybpkkr Ig/w== X-Gm-Message-State: AOAM531WQ4yMluBa/zanK7LkG6svP5djlL/3VsYTnSaiVgh4G5uZ24Z+ /Xi8ygEGdl+79mO8uaYiGDllG0FFr0/ZfVIy2JEY1hBgSnh2bbaowgifH+aFaaUnSsUu09wKjGZ t1hhH+bCKIUMEIJ71niFpOYkt9f26EJK2dRHXXI0= X-Received: by 2002:aa7:9299:0:b029:21d:7ad1:2320 with SMTP id j25-20020aa792990000b029021d7ad12320mr936596pfa.22.1618450091301; Wed, 14 Apr 2021 18:28:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOS8ZF+FYzG7w9Mf8YFdOFOmZ/r+RgZwkgg5u3LbU7N9Rak2ehntN57YQtvkLegkVtKjlWww== X-Received: by 2002:aa7:9299:0:b029:21d:7ad1:2320 with SMTP id j25-20020aa792990000b029021d7ad12320mr936569pfa.22.1618450090996; Wed, 14 Apr 2021 18:28:10 -0700 (PDT) Received: from pc-0115 (178.101.200.35.bc.googleusercontent.com. [35.200.101.178]) by smtp.gmail.com with ESMTPSA id e1sm643595pgl.25.2021.04.14.18.28.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Apr 2021 18:28:10 -0700 (PDT) Received: from martinet by pc-0115 with local (Exim 4.94) (envelope-from ) id 1lWqng-004w4O-Qv; Thu, 15 Apr 2021 10:28:08 +0900 Date: Thu, 15 Apr 2021 10:27:58 +0900 From: Dominique MARTINET To: "Alice Guo (OSS)" Cc: Shawn Guo , Krzysztof Kozlowski , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , Peng Fan , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [EXT] regression due to soc_device_match not handling defer (Was: [PATCH v4 4/4] soc: imx8m: change to use platform driver) Message-ID: References: <20201120101112.31819-4-alice.guo@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210414_182816_282325_EC2181F0 X-CRM114-Status: GOOD ( 18.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Alice Guo (OSS) wrote on Tue, Mar 30, 2021 at 02:41:23AM +0000: > Thanks for reporting this issue, I'll check and add a fix to handle defer probe. I haven't seen any follow up on this, have you had a chance to take a look? If this won't make it for 5.12 (in a couple of week probably?) would it make sense to revert 7d981405d0fd ("soc: imx8m: change to use platform driver") for now? While looking at the code earlier I also have an unrelated, late-review on the patch itself: > +static u32 __init imx8mq_soc_revision(struct device *dev) > [...] > @@ -191,8 +223,16 @@ static int __init imx8_soc_init(void) > data = id->data; > if (data) { > soc_dev_attr->soc_id = data->name; > - if (data->soc_revision) > - soc_rev = data->soc_revision(); > + if (data->soc_revision) { > + if (pdev) { > + soc_rev = data->soc_revision(&pdev->dev); > + ret = soc_rev; > + if (ret < 0) I appreciate current soc_revision are "small enough" (looking at include/soc/imx/revision.h we're talking < 256) so this actually works, but would it make sense to either make soc_rev signed, or to have soc_revision() return a s64, or have the revision filled in another *u32 argument to make sure the error is an error and not just a large rev? This is most definitely fine for now but that kind of code patterns can lead to weird errors down the road. Thanks, -- Dominique _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel