From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62788C433ED for ; Thu, 15 Apr 2021 11:37:34 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C7768611CD for ; Thu, 15 Apr 2021 11:37:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7768611CD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LNrbOkNbdX4yKLQJiqR+5b52zI3V1S33Qx8QyNFcshY=; b=P6ksIMg4EVKwDzCcY/T0UrBwz 9vvqFsJWs9jC2kEVXgtOUvoBqvQAaL5HXU1QgzRHQcIezTNIjn/Q1bR4YlmwsaYjuZDk/r3XBIaqY CeiIQFeW9KRHxdQ2m+K+PAO/j4+fDNbUjqlvs27GKZF0gVmerNcy/P3VwKhmL/ztbZ4clrQMbpgLg p2GVIRgP4dZWV50dnX9X0DzuNLt5bWEy/WePNSsHvqd/bXM7jK53wyiIyN8xpESIZNbF0nWQrpxiW 0VZVlAGknICvwg+w35dKXRokBAhdUb8awb614hdLbPCUCrmzal5oE4JisVGmTLmqzeWb5KLtW8t0E lq2zTf+bw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lX0Hm-00FyxH-NV; Thu, 15 Apr 2021 11:35:50 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lX0Hh-00FywP-7j for linux-arm-kernel@desiato.infradead.org; Thu, 15 Apr 2021 11:35:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=+Dud4UY0cgOdr5KV1F1Du/NHhBxXZS4O4G9qdOaVT+A=; b=rS5ZktY/FbUrzURp82VAr/rWP2 IuDzvHvRqB6tIxZZiiR7YAFoVH3NJfHY24sHSllxG8z90Rszh0Jit7eyIXJI5iOwE2wC54jUsSyyE YibGRCRdj+fSBbq8kV9njnpUmHcqDPA9JCKTYz/i61YDl1qo9VtluDPTfjW9zUBheLqItS5SuNUDD ydGAPMMs2kyrj1GrTKy8WvRrFrSYSJ7Rka0mVJFGSZTwGkzq22NKptJWwZrgJiQGMMjIApAqdrxXa XvDJwdb5RGCGC8qFrcdamVQdIYOOOP/vu9elN3ZBQuV+Zi9k6+Qg4KQbtOJJhyxfbWMsYnkDGRsDI bGzTPdwA==; Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lX0He-008XBg-6K for linux-arm-kernel@lists.infradead.org; Thu, 15 Apr 2021 11:35:43 +0000 Received: by mail-wm1-x32d.google.com with SMTP id o9-20020a1c41090000b029012c8dac9d47so5035001wma.1 for ; Thu, 15 Apr 2021 04:35:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=+Dud4UY0cgOdr5KV1F1Du/NHhBxXZS4O4G9qdOaVT+A=; b=YmfQ0vxcMsp1IA5c9AhpCv+ZsM11PSIycWI0aMqWoHqUhi6qZ+J4W8vuszQZHCyjfU 1UfqYWo5NDdmd2GNKq18jFvcGudTHUvRgLHufzZidAG+ArSKuiMbecUQdI8wRTw4nOry 9V/E7+84rdIsFssrvt4phBzndFEdmuYBqIpS4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+Dud4UY0cgOdr5KV1F1Du/NHhBxXZS4O4G9qdOaVT+A=; b=hpiTRNtrC7MV9Y4YwR25CIWiA4YmF9P+t9BtyaWvzC0T1OdaVAMaLEHwMy6OqkTKko 38jPDEcQKk5n9s7p0k7kf4Mm6rcj8Mcx4ImTMWXxKcT7z+P8aAV1mtfLU+OFcNSwsgLb 9N7RqxvmDTo3MikAs0oHtzF/jMXUdt89FKmpVpEK4ak3luYAWOiHUuG99jiSrCq1bgmI HxdM45mDjQspaiGKbU28k/Ur2wQvOWcnsc414JJOy9iPE/sBvMsexXao4YLTFJam4m3S Z+KEmbVcKSDP2JXeqH7G5s4YtwsvJQB2SHGIfkFLEaCNdB/rbs/F9B2RbGrZp5QygbTD OuAw== X-Gm-Message-State: AOAM532jcaDN9wLctFVIT5i0QniK1Gkq2uuMe6tHTQqmrjGWXqooaN/v eAWdmMQgWLzz9SlV2OT3jRs2/A== X-Google-Smtp-Source: ABdhPJxxSzwwyMvxVgC5ujTI/MK9RoqYpuNmkKUbB6zBEA0UZIIGvwC9mGZYt7wlzokscmS9/B1IUw== X-Received: by 2002:a05:600c:410c:: with SMTP id j12mr2649400wmi.112.1618486538703; Thu, 15 Apr 2021 04:35:38 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id x8sm2539759wru.70.2021.04.15.04.35.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Apr 2021 04:35:38 -0700 (PDT) Date: Thu, 15 Apr 2021 13:35:36 +0200 From: Daniel Vetter To: Lucas Stach Cc: Daniel Vetter , DRI Development , Pengutronix Kernel Team , Intel Graphics Development , NXP Linux Team , Daniel Vetter , Shawn Guo , Sascha Hauer , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly Message-ID: References: <20210413094904.3736372-1-daniel.vetter@ffwll.ch> <20210413094904.3736372-5-daniel.vetter@ffwll.ch> <290aef5ed13749d465eb19235aa87a2cef63dd2a.camel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <290aef5ed13749d465eb19235aa87a2cef63dd2a.camel@pengutronix.de> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210415_043542_257050_DB1A7628 X-CRM114-Status: GOOD ( 26.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 13, 2021 at 01:47:28PM +0200, Lucas Stach wrote: > Am Dienstag, dem 13.04.2021 um 11:48 +0200 schrieb Daniel Vetter: > > Since > > = > > commit 890880ddfdbe256083170866e49c87618b706ac7 > > Author: Paul Kocialkowski > > Date: Fri Jan 4 09:56:10 2019 +0100 > > = > > =A0=A0=A0=A0drm: Auto-set allow_fb_modifiers when given modifiers at pl= ane init > > = > > this is done automatically as part of plane init, if drivers set the > > modifier list correctly. Which is the case here. > > = > > This one actually set it twice on top of what drm_plane_init does, so > > double-redundant! > = > That's not true. imx-dcss and imx-drm are two totally separate drivers. > Maybe we should move imx-drm into its own ipuv3 directory one day to > make this more clear. Change is still correct, though. I've fixed the commit message to reflect reality and merged to drm-misc-next. Thanks for taking a look. -Daniel > = > Reviewed-by: Lucas Stach > = > > Signed-off-by: Daniel Vetter > > Cc: Philipp Zabel > > Cc: Shawn Guo > > Cc: Sascha Hauer > > Cc: Pengutronix Kernel Team > > Cc: Fabio Estevam > > Cc: NXP Linux Team > > Cc: linux-arm-kernel@lists.infradead.org > > --- > > =A0drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 - > > =A0drivers/gpu/drm/imx/imx-drm-core.c | 1 - > > =A02 files changed, 2 deletions(-) > > = > > diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/= dcss/dcss-kms.c > > index b549ce5e7607..37ae68a7fba5 100644 > > --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c > > +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c > > @@ -52,7 +52,6 @@ static void dcss_kms_mode_config_init(struct dcss_kms= _dev *kms) > > =A0 config->min_height =3D 1; > > =A0 config->max_width =3D 4096; > > =A0 config->max_height =3D 4096; > > - config->allow_fb_modifiers =3D true; > > =A0 config->normalize_zpos =3D true; > > =A0 > > = > > = > > = > > =A0 config->funcs =3D &dcss_drm_mode_config_funcs; > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/i= mx-drm-core.c > > index 2ded8e4f32d0..8be4edaec958 100644 > > --- a/drivers/gpu/drm/imx/imx-drm-core.c > > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > > @@ -209,7 +209,6 @@ static int imx_drm_bind(struct device *dev) > > =A0 drm->mode_config.max_height =3D 4096; > > =A0 drm->mode_config.funcs =3D &imx_drm_mode_config_funcs; > > =A0 drm->mode_config.helper_private =3D &imx_drm_mode_config_helpers; > > - drm->mode_config.allow_fb_modifiers =3D true; > > =A0 drm->mode_config.normalize_zpos =3D true; > > =A0 > > = > > = > > = > > =A0 ret =3D drmm_mode_config_init(drm); > = > = -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel