* [PATCH] iommu: exynos: remove unneeded local variable initialization @ 2021-04-08 20:16 ` Krzysztof Kozlowski 2021-04-09 12:17 ` Marek Szyprowski 2021-04-15 13:36 ` Joerg Roedel 0 siblings, 2 replies; 3+ messages in thread From: Krzysztof Kozlowski @ 2021-04-08 20:16 UTC (permalink / raw) To: Marek Szyprowski, Joerg Roedel, Will Deacon, Krzysztof Kozlowski, iommu, linux-arm-kernel, linux-samsung-soc, linux-kernel The initialization of 'fault_addr' local variable is not needed as it is shortly after overwritten. Addresses-Coverity: Unused value Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- drivers/iommu/exynos-iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index de324b4eedfe..8fa9a591fb96 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -407,7 +407,7 @@ static irqreturn_t exynos_sysmmu_irq(int irq, void *dev_id) struct sysmmu_drvdata *data = dev_id; const struct sysmmu_fault_info *finfo; unsigned int i, n, itype; - sysmmu_iova_t fault_addr = -1; + sysmmu_iova_t fault_addr; unsigned short reg_status, reg_clear; int ret = -ENOSYS; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu: exynos: remove unneeded local variable initialization 2021-04-08 20:16 ` [PATCH] iommu: exynos: remove unneeded local variable initialization Krzysztof Kozlowski @ 2021-04-09 12:17 ` Marek Szyprowski 2021-04-15 13:36 ` Joerg Roedel 1 sibling, 0 replies; 3+ messages in thread From: Marek Szyprowski @ 2021-04-09 12:17 UTC (permalink / raw) To: Krzysztof Kozlowski, Joerg Roedel, Will Deacon, iommu, linux-arm-kernel, linux-samsung-soc, linux-kernel On 08.04.2021 22:16, Krzysztof Kozlowski wrote: > The initialization of 'fault_addr' local variable is not needed as it is > shortly after overwritten. > > Addresses-Coverity: Unused value > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Acked-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/iommu/exynos-iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > index de324b4eedfe..8fa9a591fb96 100644 > --- a/drivers/iommu/exynos-iommu.c > +++ b/drivers/iommu/exynos-iommu.c > @@ -407,7 +407,7 @@ static irqreturn_t exynos_sysmmu_irq(int irq, void *dev_id) > struct sysmmu_drvdata *data = dev_id; > const struct sysmmu_fault_info *finfo; > unsigned int i, n, itype; > - sysmmu_iova_t fault_addr = -1; > + sysmmu_iova_t fault_addr; > unsigned short reg_status, reg_clear; > int ret = -ENOSYS; > Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu: exynos: remove unneeded local variable initialization 2021-04-08 20:16 ` [PATCH] iommu: exynos: remove unneeded local variable initialization Krzysztof Kozlowski 2021-04-09 12:17 ` Marek Szyprowski @ 2021-04-15 13:36 ` Joerg Roedel 1 sibling, 0 replies; 3+ messages in thread From: Joerg Roedel @ 2021-04-15 13:36 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Marek Szyprowski, Will Deacon, iommu, linux-arm-kernel, linux-samsung-soc, linux-kernel On Thu, Apr 08, 2021 at 10:16:22PM +0200, Krzysztof Kozlowski wrote: > drivers/iommu/exynos-iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-15 13:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20210408201630eucas1p25551bcecf0073ac0361cfc03a4ef124a@eucas1p2.samsung.com>
2021-04-08 20:16 ` [PATCH] iommu: exynos: remove unneeded local variable initialization Krzysztof Kozlowski
2021-04-09 12:17 ` Marek Szyprowski
2021-04-15 13:36 ` Joerg Roedel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).