From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF45EC43600 for ; Thu, 15 Apr 2021 15:41:33 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35B3461158 for ; Thu, 15 Apr 2021 15:41:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35B3461158 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aarUyRYmYoDOwrY3Z1glPcvmbVRyDnpF2NIqi6mIxNs=; b=o1GCyFEDz1NWJbuMH1RTc2fQo +3QokRCdppzFBzd4+Mev4HWmXp+/R6EMF1DQ1/rfJHWzbFEIZvBvqcNmiELnEmlIqAcPAFjqC8EXJ f9zjDabV4cZvOdBd7Yk5+SveZwPDIIMGBAL6MOC/ami9D4Tt4cER11I5jr6cdgfg5MLROTggW4Dil NVB3q1R94gRTpezPq3Kzhb+p0uA5xGE+EuNnwc8cg60G6c6rLMyYnyRkoCQ+AVt2qSiY8fq1hvMWj TQM5RMqvjkp6zYoKUZlLECzg8mLG6IhFslFLstxskvhYbjY6m4S0hAWqYqvX71SgYS+itrO/ajuFY Qjx6NcAWw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lX45u-00Gdy8-Tr; Thu, 15 Apr 2021 15:39:51 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lX45s-00Gdxq-Ar for linux-arm-kernel@desiato.infradead.org; Thu, 15 Apr 2021 15:39:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XSCsclVlGcjE/3n2VHF66XJpI7uBMlI8sjreDxm42bQ=; b=ddAvz1+w7xR5GcmwgSyDZwmzUH RUVZ8upBQDXN46jHsBXOCRih7h9Ev1y3Vrd6YhYFGxGR9MmiklGCQpaxqC3rV0fgE2r2VB3c/yjp2 mcgcO1y/qr7adR+Dd4WMKpOn3RbHSeK+m7U2wu0/DZzpIkQWMQVfzqzp0uVqddyLP2Fvbcs+EFhV8 huQLH/cuwL94Cjx42QtdUHKfX6Cm86ZGbVRTKcZeJUc25WX78iNgid0qWzti069vet+q/2QFD+fOK LaOPnt5lXytrPMIT1N6FrYNlRt/4rPZnBFJVInUeAF6+27xY9SwT9YYWhCfDZPx8v2v0pDFLIi3UF cJ9gsrUw==; Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lX45p-008iNA-88 for linux-arm-kernel@lists.infradead.org; Thu, 15 Apr 2021 15:39:46 +0000 Received: by mail-wr1-x434.google.com with SMTP id 12so23774590wrz.7 for ; Thu, 15 Apr 2021 08:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XSCsclVlGcjE/3n2VHF66XJpI7uBMlI8sjreDxm42bQ=; b=cBGi61gIsnbTHhD2mXwwYuiXLUzuneTFEMKIfvQPiPJ2hS5WHVmXTF8y5ig/iSGgfJ IpMobIWVPLAxYI9btQyAP5/vQ8YaCuWy6eMCJVJBGJ3xrr+1dcie8nQAmWqp8fZbMeHv ezmqWpyrwlVczGNX8JADJqyzSYb/VcDTKu06c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XSCsclVlGcjE/3n2VHF66XJpI7uBMlI8sjreDxm42bQ=; b=fJ3/psHUT5aLX/OHSOpaGqN5uWe/I6gvfIFpeNmBBRPNTOlIcORUvjRxqeoUQxKwGS LwVbsODJ8sKO8ZpAjj4lt1lPTl7OzL53GIUA6dneGKlnyxOGgdgD2ywVvtlQWRDTrOW1 b2m9dvQDbsmjspAHCIwlCaghhnRkykzkHoFHNniLyv715o2xBtUYt/u3oysxEPKXQ8Oi wsqK7FUWbVG97I1UcLzofVH9RqX6+yxocqfSBfNN0d86X2hfS8tI1HlApy29a9bFjQpM JVFDMLQTzfTMqYPiiW7+bB5C5FOLlr3rIbt2N0OHwipMhdZqkGkYf0fLwa2VU/7AKTMe NBtg== X-Gm-Message-State: AOAM530EN4kDE2/ONAQiZoNZY4lCuPwD43eGIV47LqZWMB/09BZCaIaZ lS/Cu+m3qWvR05/wzZ5TKysF/g== X-Google-Smtp-Source: ABdhPJxuGJBUrUov6tav3dzBAB0Nmjs31lo2ZDkoMbFv/w3IXmQK1LERgvEtsv0USSugxMC1h1eJHQ== X-Received: by 2002:a5d:564b:: with SMTP id j11mr4288509wrw.307.1618501183832; Thu, 15 Apr 2021 08:39:43 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id g3sm4063869wrp.46.2021.04.15.08.39.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Apr 2021 08:39:43 -0700 (PDT) Date: Thu, 15 Apr 2021 17:39:40 +0200 From: Daniel Vetter To: Thomas Zimmermann Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@linux.ie, daniel@ffwll.ch, marex@denx.de, stefan@agner.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-graphics-maintainer@vmware.com, sroland@vmware.com, zackr@vmware.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/4] drm: Remove DRM_KMS_FB_HELPER Kconfig option Message-ID: References: <20210415110040.23525-1-tzimmermann@suse.de> <20210415110040.23525-5-tzimmermann@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210415110040.23525-5-tzimmermann@suse.de> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210415_083945_313126_4F03683C X-CRM114-Status: GOOD ( 21.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 15, 2021 at 01:00:40PM +0200, Thomas Zimmermann wrote: > It's only used by DRM_FBDEV_EMULATION, so inline it there. > > Signed-off-by: Thomas Zimmermann I'm not sure on patch 1, I'll leave that to Zack, but I think 2-4 would work alone too. On those: Acked-by: Daniel Vetter > --- > drivers/gpu/drm/Kconfig | 28 +++++++++++----------------- > 1 file changed, 11 insertions(+), 17 deletions(-) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index 3c16bd1afd87..d3a9ca4b1cec 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -80,23 +80,6 @@ config DRM_KMS_HELPER > help > CRTC helpers for KMS drivers. > > -config DRM_KMS_FB_HELPER > - bool > - depends on DRM_KMS_HELPER > - select FB > - select FRAMEBUFFER_CONSOLE if !EXPERT > - select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE > - select FB_SYS_FOPS > - select FB_SYS_FILLRECT > - select FB_SYS_COPYAREA > - select FB_SYS_IMAGEBLIT > - select FB_CFB_FILLRECT > - select FB_CFB_COPYAREA > - select FB_CFB_IMAGEBLIT > - select FB_DEFERRED_IO > - help > - FBDEV helpers for KMS drivers. > - > config DRM_DEBUG_DP_MST_TOPOLOGY_REFS > bool "Enable refcount backtrace history in the DP MST helpers" > depends on STACKTRACE_SUPPORT > @@ -117,6 +100,17 @@ config DRM_FBDEV_EMULATION > depends on DRM > select DRM_KMS_HELPER > select DRM_KMS_FB_HELPER > + select FB > + select FB_CFB_FILLRECT > + select FB_CFB_COPYAREA > + select FB_CFB_IMAGEBLIT > + select FB_DEFERRED_IO > + select FB_SYS_FOPS > + select FB_SYS_FILLRECT > + select FB_SYS_COPYAREA > + select FB_SYS_IMAGEBLIT > + select FRAMEBUFFER_CONSOLE if !EXPERT > + select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE > default y > help > Choose this option if you have a need for the legacy fbdev > -- > 2.31.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel