From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F813C433B4 for ; Thu, 22 Apr 2021 10:06:08 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19AD961131 for ; Thu, 22 Apr 2021 10:06:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19AD961131 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sdombt5HMUZuMjTP3NijzCo5gEukLZnS/TKO8g9y+90=; b=pcjG+AHegnJvyieEcdaHU5J3/ M9OKFzGcZzXeAPWMNGA7wNeE5HiydW5vUUUsDH8bgmAY6716SIO/W58xnobHzFpJj4oj0kkGt7Ylr v3ky8GkOrygHhzNSr/w6heeQKB92OvvHWxHVzB0qeyaAGfcJSqjk6fMl39DGwskZK8Ni8tgfi4uEW MprKRwgKbVI+ZuICH0h9YLnR/Gs854vIu+Ve/XWSKd0bOZHDyxxSZqaGF7yUnC1zFT1gLfHjmSBh1 ZL+lWmv+wkfKiygsIyA9qHPrnHVJElj5DX4WRH+8hsGDKbZEEQzxh88eQpVYriMjyg4F37UJNDfDG 8nSwhe58Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZWBv-00GPtY-Hl; Thu, 22 Apr 2021 10:04:12 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZWBt-00GPsU-0z for linux-arm-kernel@desiato.infradead.org; Thu, 22 Apr 2021 10:04:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YzPJCQuiYs/xrt5gO8WKHjz7qGpEFx6fOGB2yWKfScU=; b=GkwJLQuwx5rBzWLqgva5R9eLo1 qq7kae4NH0ehiZYhswkkMMeuuJBEeEAj8ov8WLG6V1UO6XDjoQ1XKg1zm3ignfEPjDqQIxxiALGRA 8frYJBP6PPIfNMNouwhhR/HUBYy5W+YksPLpOkvQnEK1Njp01BzSy8JJClhRFg77H5OMsL8AgX0r/ sb3fyeEAFtEAjmzbuGw0djKZZL0do8GP52KOqJbFQJ8CHSLC2pj7nfJEuZ1Lh2luiLGM7fGjj6W7+ Eh4XqOW63/wQQk6600WLHb8K9x0CNwqIV8SBqAZojnwyEOSKIPe4BK9798/SsvDRWAwmh2SBsU6uT B4r1v17Q==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZWBq-00DZ9p-Ha for linux-arm-kernel@lists.infradead.org; Thu, 22 Apr 2021 10:04:07 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0402F613F2; Thu, 22 Apr 2021 10:04:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619085845; bh=IRoMB5T0HjVZPko4a93wd1DTQr7V5iRUr5V9MLSeMXU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TdCbNPMG1OgSoEWz6JHR1/0oq7859Zo3OIjVU2zV0vPRzzKqgm1AdP8rSrMgw6YUZ 4CPkIJYkxFEiNcbEMjDAcnr97CA3rd4Mnt3gQfjLivjGvZPBxTc+Lepc6dzrAFRkMg QxzkqLudSYG2QDwV7osarzrtL1K9uAGirns7s7K+/1x0wkIDBfNRlDuWFagvNt4hpH fjG9tt7XyyZzeCUFoM8FeSg6Sg7Q0hyTh8rYicCRE8jungk5SUzDgr+ZdbVrmhjklY Ypz765TFR6gciYE2viQShYYRcKoTyDX8EwgjvY94jnyCLuYdjiaxHevjipkbffIXI/ qGjSdVztO0Fpw== Date: Thu, 22 Apr 2021 13:03:58 +0300 From: Mike Rapoport To: David Hildenbrand Cc: Anshuman Khandual , linux-mm@kvack.org, akpm@linux-foundation.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC V2] mm: Enable generic pfn_valid() to handle early sections with memmap holes Message-ID: References: <20210422061902.21614-1-rppt@kernel.org> <1619077823-3819-1-git-send-email-anshuman.khandual@arm.com> <61523566-f302-1051-9565-b1e129c6cac0@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <61523566-f302-1051-9565-b1e129c6cac0@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210422_030406_645824_5766AD02 X-CRM114-Status: GOOD ( 12.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 22, 2021 at 11:48:58AM +0200, David Hildenbrand wrote: > > > > > IOW, avoiding having to adjust generic pfn_valid()/pfn_to_online_page() at > > > all. Am i missing something or should that be possible? > > > > We are back again to the question "should arm64 free its memmap". > > If the answer is no, we don't need arm64::pfn_valid() for SPARSEMEM at all. > > If the answer is yes, Anshuman's patch is way better than a custom > > pfn_valid(). > > Well, I propose something in between: stop freeing with SPARSEMEM, continue > freeing with FLATMEM. I'm all for it. -- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel