From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A32E6C433ED for ; Mon, 26 Apr 2021 12:20:09 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11B17610A2 for ; Mon, 26 Apr 2021 12:20:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11B17610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HB3isU26bqunf0Zs08uGZOm9zGBc0spheZxSYEKw6tc=; b=OgP3/pU1pUXMzlMmHuVNGJKP5 rqaxYfRR7Kg2PZ0yb/XfR/fEbEhHPiwvTnXTXgEqwjW0W9EkQH9Y8fmEBuR2U4g/ophSeKu7lgShJ T2DyKzMZPsbuF9Arlqzzuo9ynIVrIk9qOnhx3NAd80de5BN0wuiwlyDtHckkLK8Y5e5913xdv9xHO EquFH8udbJ2KjjPLNkXjfSjbiuDVtjCVSaejnW4Rh3DOkvbrAzSS1hDRfdQgJRRK6/3uRt/y+OP9W kJLOQy2Y5Twthp6qMS7R7p7ejOGPPMxlfRUUDw+YQjp0lmagLM9VuKsM0GgnS1NChyw1G/CXseREe 8B6aU2inw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lb0C3-007aMT-2Y; Mon, 26 Apr 2021 12:18:27 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lb0Bx-007aLA-Qg for linux-arm-kernel@desiato.infradead.org; Mon, 26 Apr 2021 12:18:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tK15BlmvmIRcfhgXosCMmTiD+iicYMVtt9PlUH1r5cQ=; b=rzEK/yZCkmQ/CKQfYX8pDkf0Re kwoRJMu2DCDM1QcqjWX9ctuSja64DUM7yg4l/oE1HT/ZWE+xclreE82aHSJhm4MA3MO1vJZMkC/Nv jxOFieItivhqL1MILmhTAGuHn46Ca0Fh7k3O5YTMShrrDnrHcaPTaOpfIf72VxUGsTSCiSS6U4eN+ ofLUs7TQtjE8MMebH8hAgFzTNNFH/4JNMjV2mkYDeFa/euTyjVe/qrnPRxrNVtqE69rwCJeL1b+56 bJeMe/ZMO4nyrS42CAkMlrKvJpYPUp/q3Imv1UvEAntaATLZK64s1TEI3CWKhcOZQdKagg01/pEUL 0Hi/dMww==; Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lb0Bt-00FwxG-6q for linux-arm-kernel@lists.infradead.org; Mon, 26 Apr 2021 12:18:19 +0000 Received: by mail-wr1-x435.google.com with SMTP id c4so16749892wrt.8 for ; Mon, 26 Apr 2021 05:18:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tK15BlmvmIRcfhgXosCMmTiD+iicYMVtt9PlUH1r5cQ=; b=RXOekx7IaygSvK2lipN3ycXY5+ah7vdVbcnRy7yyxmuDwoDiPXgNpQI1ZUym6o1idk 1BLpZw1DPaHGhInxsveUS1hiR7DpLXStvt80AV+neFgjDzX3vgLRrORtnZWsIWCsaNA2 PHhGLWa+RWtObO0iVxVtzqecLy1UNPh0f7cxTuOmmn185Z/Gr7SO8Oq7e8b9hBHaPbw/ tmIz3fLxTJgxTIMetZtuPTHTv0FmU9hcMzRvhkLcoVjK8ckGEB8R7BSMR2bCzrSQwYsL FlgFvtHgNGJ7ndoyBKBlT64K4k/o1nWdJWgeYUD04mGuVcqCtXvhKwEYCQiGzceI4isb xjmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tK15BlmvmIRcfhgXosCMmTiD+iicYMVtt9PlUH1r5cQ=; b=JkbSkI4egXpKJOob5AXPBPuCUFNuwF3z6D326HZQuU63uHHU1n6Ojf39QJAzmaUhiK QkrmYjpyQRotc2UCwFKsjglcpu80wBX4fgR43pNTBpz3w1Cjq6f11RbZ3ILHq7jB4kjv GZ46nIJSJ/ZCSE0QRZcxeq7DceeKF+Qac0SvD6LAwRCnptC7b1l6vslJ/3N0EuV0e/IX HVvJ+2QBYiQ+cGNijkGz0EGD3IzSajzwXBbehvC3X3OkZv9YVuleT2V2c1nxzI8+S3Pn Sp41YIAqPE8EFfbGYwhyaWph8lxl56a26EBLXNv9nRN6s3tJnnEeKENiq5EogA3cqyuk gnMg== X-Gm-Message-State: AOAM532xRGMc+AeNl6uSXmFdh0xnoNKrhyxaB4Ng3jz3SiLzMEkbf8n0 wKx4xlD0mipVHFxMG3BfeQA= X-Google-Smtp-Source: ABdhPJylzE4JXtBqaLpMFyW67e4U9xwgihBq8qjF2G1I7X4Fzewl8hTbyZoHFDlcTKaEvJOpyBW1MQ== X-Received: by 2002:a05:6000:1561:: with SMTP id 1mr22840333wrz.72.1619439494628; Mon, 26 Apr 2021 05:18:14 -0700 (PDT) Received: from localhost ([62.96.65.119]) by smtp.gmail.com with ESMTPSA id q7sm20118478wrr.62.2021.04.26.05.18.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Apr 2021 05:18:13 -0700 (PDT) Date: Mon, 26 Apr 2021 14:19:06 +0200 From: Thierry Reding To: Krzysztof Kozlowski Cc: Jon Hunter , Dmitry Osipenko , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 06/10] memory: tegra: Parameterize interrupt handler Message-ID: References: <20210420165237.3523732-1-thierry.reding@gmail.com> <20210420165237.3523732-7-thierry.reding@gmail.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.6 (98f8cb83) (2021-03-06) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210426_051817_286778_7A20D8E2 X-CRM114-Status: GOOD ( 16.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1934357388381222638==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1934357388381222638== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/L89aHPukja1BO3w" Content-Disposition: inline --/L89aHPukja1BO3w Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 26, 2021 at 11:01:00AM +0200, Krzysztof Kozlowski wrote: > On 20/04/2021 18:52, Thierry Reding wrote: > > From: Thierry Reding > >=20 > > Tegra20 requires a slightly different interrupt handler than Tegra30 and > > later, so parameterize the handler, so that each SoC implementation can > > provide its own. > >=20 > > While at it, also make IRQ support optional, which will help unify the > > Tegra186 memory controller driver with this one. >=20 > Please split making it optional to separate patch. Looking at the code > should be possible and not affect bisectability. Technically that means I'd have to add a check for valid callback, otherwise it'd risks oopsing if for whatever reason that's passed in as NULL. It shouldn't be a problem in practice because it'll be valid in all cases, at least until the unification patch, so perhaps there's no need for the check if it's made optional in a subsequent patch anyway. Thierry --/L89aHPukja1BO3w Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmCGr7oACgkQ3SOs138+ s6FNgBAAuBiq1nkhhxw6MLmZspeT3IqosXzWYAOEKRyvv85sRPetzv/C4esS45vw HIWo5Fpvcms3ge4F4jFCGApbI/I1DhTD4Tj5uX6aUvN/SudxFelghptq/lze0MKo nAfwJte/jh+VNrPqTw+c1eOtb3dBH6C3efrwzRfuEX1q9tFSU4TI/KO0D/wdQczJ r3xwTjEn7jHHNZPtzRIjhN/CSralCXEH6mvmZ+SySleYDgNZXLZBclzX6t2Ux5Xv sTk3mtIOZiP5oyRrwHoqZbnQCMj7GmhnZZ3llXyUuAdJK9LwirS4iqCPtHJVVn0k 86UsjoSY6v7B1KZJLr+LxXTatWireent2/OYALsrZgmdLEV3plp5PP9diFNU8ZDs bxxkQr4SQs4HcXp1wdGHzWg9WHoZER0kPSylEVRRSavCRdRmyuYaCSWwRdujXXMC MkORODMoBkWd+KO7QXlI5HKQvV67ybK1kp7eB8L4YhoJczQABUOHS1un7YaNQAAV jGzU2APuiaAj9dQtghOw4eQ5oKA6Kb8z8FHRD0agaAmBvFo0nvARKkpCGbmzGKbR yupcv04pxVIkH5f7KtRkE2KhphwcA9136Po1zM4kyYgR+pImyOArIwSeR9q8FvaS kj+VHHCLg0pS9L3sj/PnosYQzQgIrzE+GYBN+As88Df9Qda9Ikw= =gYUS -----END PGP SIGNATURE----- --/L89aHPukja1BO3w-- --===============1934357388381222638== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1934357388381222638==--