From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE158C433ED for ; Wed, 28 Apr 2021 06:02:26 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C9D261420 for ; Wed, 28 Apr 2021 06:02:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C9D261420 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7Pv3b5sEO9MGsAV9O4hZpFKn8UM99XlfCy7jZMmJvco=; b=gGJY7KJRdrgAseJHEeLXb/N6r /vdUnfP8lqRD8asyzuQ+EH/IWwc1Mnq/8TleQ59B2SkmN0QvE6nyPmMe8Gz3AiqjTuOiGrdgCnoPP SJwDSFT0t6TlOXD6fIsvodx8G6YYQc2azrUP4A7qEQcdxmpYd+l5AwOlP61Ax1ho/bmM/D9V792Uf Ow3BtE5ORXODfsnSBd6g7NZWbZ0ilFl+nOga3rIUdTzyzs4J4C+2HtZZaEIiguStMI0Um9mfkEipy gkokqsLJ2A2CQ6o7IH/tby8qQRi7J5BQwH2ZraFUprv1Gi1u0VURcBTub8kyHVtHjPJ7HrpTHtsU8 1akJzl22Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbdEf-002sSw-Pr; Wed, 28 Apr 2021 05:59:47 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbdEX-002sRm-Dz for linux-arm-kernel@desiato.infradead.org; Wed, 28 Apr 2021 05:59:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ej7KJhgoHiDHjYr7d5rgDHAmtrpNZFAKw26eq/AWM7w=; b=jUzcLQzMFT9xkXFXQrpTtZFCYZ 7b9sJoHRganFDIsHSp9OoiW9bnt3jk6oFRdfagEFpeNakteSl2m3ZsHcWfd/ClBAKqMLQd2L0zwub y8c/JfN/L2PelObV8tpxaTNaRDRJiUlvKMOb2Fwcd/gdNV3BdMfjzI7m1Ve5u4oGp3xhb4pR6Im+b Cr4DN2jqINkfp9J9zENAE3SnidYWyhUfeiFUaG7vcR9lmYykjBLYlIQlYMt2Bd0G2QotGA10ElV/V vdBNeAen7CuclZ21fi5/nDb+AZ01HLMmbfdpWhOBvZASrOPxYL3OUOsIpT+vrPU0sJx1qHOJ1KDMK i6VDAcfQ==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbdEU-00HCUm-HN for linux-arm-kernel@lists.infradead.org; Wed, 28 Apr 2021 05:59:35 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E6EB5613FB; Wed, 28 Apr 2021 05:59:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619589573; bh=PzXRzqyaN0AHEgEDWQ7ORDtLyuOZqfpRHAtszxM+aMo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=15ttKwTuuNivW2WUxOzPsphx0FRf9V1T8rt8jHcNnVVId6Lvj5uNEq3xV/c5gCrt8 kUKvwWswbZa1rZYStYXr3DoADlotDZXvS1mi3zdsqzkseIBK48Yce+nLvCDqZtFmnq u1wakr7dYWCrxLNgwu1w0kUdlF1b42NPjmrWwnYo= Date: Wed, 28 Apr 2021 07:59:28 +0200 From: Greg KH To: Timo Sigurdsson Cc: axboe@kernel.dk, mripard@kernel.org, wens@csie.org, jernej.skrabec@siol.net, linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, oliver@schinagl.nl, stable@vger.kernel.org Subject: Re: [PATCH] ata: ahci_sunxi: Disable DIPM Message-ID: References: <20210427230537.21423-1-public_timo.s@silentcreek.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210427230537.21423-1-public_timo.s@silentcreek.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210427_225934_617755_B1063AE1 X-CRM114-Status: GOOD ( 21.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 28, 2021 at 01:05:37AM +0200, Timo Sigurdsson wrote: > DIPM is unsupported or broken on sunxi. Trying to enable the power > management policy med_power_with_dipm on an Allwinner A20 SoC based board > leads to immediate I/O errors and the attached SATA disk disappears from > the /dev filesystem. A reset (power cycle) is required to make the SATA > controller or disk work again. The A10 and A20 SoC data sheets and manuals > don't mention DIPM at all [1], so it's fair to assume that it's simply not > supported. But even if it were, it should be considered broken and best be > disabled in the ahci_sunxi driver. > > Fixes: c5754b5220f0 ("ARM: sunxi: Add support for Allwinner SUNXi SoCs sata to ahci_platform") > > [1] https://github.com/allwinner-zh/documents/tree/master/ > > Signed-off-by: Timo Sigurdsson > Tested-by: Timo Sigurdsson > --- > drivers/ata/ahci_sunxi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ata/ahci_sunxi.c b/drivers/ata/ahci_sunxi.c > index cb69b737cb49..56b695136977 100644 > --- a/drivers/ata/ahci_sunxi.c > +++ b/drivers/ata/ahci_sunxi.c > @@ -200,7 +200,7 @@ static void ahci_sunxi_start_engine(struct ata_port *ap) > } > > static const struct ata_port_info ahci_sunxi_port_info = { > - .flags = AHCI_FLAG_COMMON | ATA_FLAG_NCQ, > + .flags = AHCI_FLAG_COMMON | ATA_FLAG_NCQ | ATA_FLAG_NO_DIPM, > .pio_mask = ATA_PIO4, > .udma_mask = ATA_UDMA6, > .port_ops = &ahci_platform_ops, > -- > 2.26.2 > This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel