From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6833C433ED for ; Tue, 4 May 2021 09:19:55 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41601613AA for ; Tue, 4 May 2021 09:19:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41601613AA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Rmntrh+7LFuiRBPUOJCWB8d1itKWQTdLfgyeY0pxeVY=; b=kszagRLFG3r5JCIxVJaDzMNmi 3BPY+vOMWuhtfuAv6k8Uds5VB7H6AgH/YlILkczTkVyCrkA/HWMPDGF6IyVIpfNMp/us8nG/+un/l lewpf2o0EAeiLyIc0cUEPshlw3SO/DsDX7ibF21VCfmRc+8xw+vC4obO0kZ6GqpLag11nOmn7STqf 4i5y7JWKv0nn/VI+++Ub0CK9XJoMYrYNQjh7/WYmvxBuPQgJe9ddu3VZTGvSPNCQ8U5L894H6iII4 l5SvB6qmAZI+Sxo4IQiW9T3zu5pssq/HliZ5BHrW2wqQe4AHc/l/1y3sqYeLdM5cA1xABGMNMgoEC ZaP2ZoYmg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ldrBw-00Friy-Fv; Tue, 04 May 2021 09:18:09 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldrBt-00FriZ-Li for linux-arm-kernel@desiato.infradead.org; Tue, 04 May 2021 09:18:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wrGbrvQNE2uI558GeLzrHQyGjw7JzT4ndS2ymwSVbGQ=; b=2eIOUPGpHwwX2JZmGmhkrzmTLh mp0SL5wJHoLSiKq6F5yL2IRneXbAVPQZMm6sW3uZH1XtbM87H1IdIqI5XYPMNCUU08VrgkrIG+CGr rwqOl/npQNq0VL6tZwELcpFLvRtiEspQIjtQ+SjEjWq+Wx0BA47Chbc91+NuaYwE+6Rr/AT/t+aJn /iambkSYzClM0Lbbc0BOVM+e5/Mq2PfGPbL5Je6Xr8iiIZ3R4Ya++tqFtMuc5G4YQrJ25jxrMm9JA 4UskozxYHP6SSNrC4zAKBh1II8TGgZlsbztk1ztMJvKeirE51mxwmGjB+XjTGaM4RLi8K4Liay3Fu 7zgzZQtQ==; Received: from mga01.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldrBr-003qoZ-1k for linux-arm-kernel@lists.infradead.org; Tue, 04 May 2021 09:18:04 +0000 IronPort-SDR: NWWMQf6JxhMr6g9XfCE6JIORuClSWdy4eiThZI4vuLtYA5sYj3jm3aReAQs5QJ1FbyUrBLRn03 KpN75XBtV/gg== X-IronPort-AV: E=McAfee;i="6200,9189,9973"; a="218741960" X-IronPort-AV: E=Sophos;i="5.82,272,1613462400"; d="scan'208";a="218741960" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2021 02:18:00 -0700 IronPort-SDR: 7draSFrfvY/hi9a8M9XFlwwgRXE1qfj2CvQILS/v7WyYJkAJ8oSaPm5EuEcdH+6i7wDqYGwWcB KAWKm7gjPL2Q== X-IronPort-AV: E=Sophos;i="5.82,272,1613462400"; d="scan'208";a="396062620" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2021 02:17:58 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1ldrBj-009VMz-Qd; Tue, 04 May 2021 12:17:55 +0300 Date: Tue, 4 May 2021 12:17:55 +0300 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Yicong Yang , Wei Xu , Wolfram Sang , Dmitry Osipenko , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] i2c: I2C_HISI should depend on ACPI Message-ID: References: <22d124a7f12f2c8b280a9cc7f3b766351c9a8d64.1620119167.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <22d124a7f12f2c8b280a9cc7f3b766351c9a8d64.1620119167.git.geert+renesas@glider.be> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210504_021803_161200_C60AD867 X-CRM114-Status: GOOD ( 20.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 04, 2021 at 11:06:32AM +0200, Geert Uytterhoeven wrote: > The HiSilicon Kunpeng I2C controller driver relies on ACPI to probe for > its presence. Hence add a dependency on ACPI, to prevent asking the > user about this driver when configuring a kernel without ACPI firmware > support. As promised, okay from me. Thanks! > Fixes: d62fbdb99a85730a ("i2c: add support for HiSilicon I2C controller") > Signed-off-by: Geert Uytterhoeven > --- > v2: > - Drop dependency on ARCH_HISI, as this is a public IP which doesn't > specifically depend on ARCH_HISI. > --- > drivers/i2c/busses/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index b5b4e0d0ff4dd0bc..226c0b79eac030fa 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -647,7 +647,7 @@ config I2C_HIGHLANDER > > config I2C_HISI > tristate "HiSilicon I2C controller" > - depends on ARM64 || COMPILE_TEST > + depends on (ARM64 && ACPI) || COMPILE_TEST > help > Say Y here if you want to have Hisilicon I2C controller support > available on the Kunpeng Server. > -- > 2.25.1 > -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel