From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9164DC433B4 for ; Fri, 7 May 2021 08:04:32 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DAAA3613C8 for ; Fri, 7 May 2021 08:04:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DAAA3613C8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PP3yvf9VCHA+T9d5lHYnLCGszPE1a4advMMV+s66IOY=; b=FGx4zNK79qTdTir1Mcgy1PmR1 qztXCm33tA5UPC+IKXLfouDkJgNo4MuXM/60NmNW5lX1aIN7TlkFDRvNYAs+BgGwW6qlxVNidCcJz z8SmscwfXzXcHGSDfS29IWbbYsQvkmA+Uf9BG9PVoWrlmMbcWSMU/JXPlDrugXIsbjv28HoS8J0tF fSi6If/kJh9MgMrZl2wM6zNNAZEA0Jr3ATbcYJwWUY7CdoZ4nVrF4iMELeAsXXZO2xjxoCnppsNkl N0iOrbRr4UGFW2ELH77St9B0KYpxF/0rj597rJqMXNMXViedOWL3UO/0JyaleUcuEJTH1vfT4pk+6 M8KJWu9yw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1levRD-006Sgk-6O; Fri, 07 May 2021 08:02:20 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1levRA-006SgX-VC for linux-arm-kernel@desiato.infradead.org; Fri, 07 May 2021 08:02:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dle947dfh/ZEo+RNLFL2uEXWuEpLebYY9EfJo7X9198=; b=RGH7pHprYKJAs6X96gtAf7y2bw +lvL7plhzMD2LoRZYK5s3Q0txdRtBtKnPKi7cQs9Cepxx76eM82m1bHSwryXsABDGD2B4ue0YdYTa xDPCgWL3Q8lB+GzVeS6BNX6VG3mL5Yv5M3gGwllMWwFrxIIws21n7p0e/3XiYpSshszjTNodOWYAb ih0Jw7/l3Te4KSg7Y3yvQAVpF6EB0AEonB7ToNGrc3K0IXJAABHgy/Pnku9WEkEEFR1Bjh8BVZRbd dlrCQ65DPq5tcHo9FbLvageC4YJ0YuSnTd2Veow20DFd4tPn97729RQ6nAxofW5mXcLhF46ZGkccL 7ai36xyA==; Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1levR7-006frH-Vi for linux-arm-kernel@lists.infradead.org; Fri, 07 May 2021 08:02:15 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 1A4F180E0; Fri, 7 May 2021 08:02:05 +0000 (UTC) Date: Fri, 7 May 2021 11:02:00 +0300 From: Tony Lindgren To: Naresh Kamboju Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , lkft-triage@lists.linaro.org, Linux ARM , Linux-OMAP , regressions@lists.linux.dev, Benoit Cousson , Kishon Vijay Abraham I , Vignesh Raghavendra , Viresh Kumar , Rob Herring Subject: Re: #regzb introduced: 98feab31ac49 ("ARM: OMAP2+: Drop legacy platform data for dra7 sata") Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210507_010214_084766_AE1FB729 X-CRM114-Status: GOOD ( 18.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Naresh Kamboju [210506 15:19]: > On Thu, 6 May 2021 at 17:23, Tony Lindgren wrote: > > > > Hi, > > > > * Naresh Kamboju [210506 11:00]: > > > Our bisect script pointed this as the first bad commit on linux > > > mainline master branch. > > > > > > Full test log: > > > ---------------- > > > SATA detection failed log link, > > > https://lkft.validation.linaro.org/scheduler/job/2580998#L1973 > > > > > > -- > > > commit 98feab31ac491400f28b76a04dabd18ce21e91ba > > > Author: Tony Lindgren > > > Date: Wed Mar 10 14:03:51 2021 +0200 > > > > > > ARM: OMAP2+: Drop legacy platform data for dra7 sata > > > > Thanks for the report, looks like we are now missing the sata related > > quirk flags compared to the patch above. > > > > Below is a quick patch to add the missing quirk flags that might help > > if you can give it a try. > > The reported problem was solved by this patch. Thank you. > Please add reported and tested by tags. > > Reported-by: Naresh Kamboju > Tested-by: Naresh Kamboju OK good to hear and thanks for testing. Will send out a proper patch. Regards, Tony > > 8< -------------------------- > > diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c > > --- a/drivers/bus/ti-sysc.c > > +++ b/drivers/bus/ti-sysc.c > > @@ -1459,6 +1459,8 @@ static const struct sysc_revision_quirk sysc_revision_quirks[] = { > > SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY), > > SYSC_QUIRK("tptc", 0, 0, -ENODEV, -ENODEV, 0x40007c00, 0xffffffff, > > SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY), > > + SYSC_QUIRK("sata", 0, 0xfc, 0x1100, -ENODEV, 0x5e412000, 0xffffffff, > > + SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY), > > SYSC_QUIRK("usb_host_hs", 0, 0, 0x10, 0x14, 0x50700100, 0xffffffff, > > SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_SWSUP_MSTANDBY), > > SYSC_QUIRK("usb_host_hs", 0, 0, 0x10, -ENODEV, 0x50700101, 0xffffffff, > > @@ -1524,7 +1526,6 @@ static const struct sysc_revision_quirk sysc_revision_quirks[] = { > > SYSC_QUIRK("prcm", 0, 0, -ENODEV, -ENODEV, 0x40000400, 0xffffffff, 0), > > SYSC_QUIRK("rfbi", 0x4832a800, 0, 0x10, 0x14, 0x00000010, 0xffffffff, 0), > > SYSC_QUIRK("rfbi", 0x58002000, 0, 0x10, 0x14, 0x00000010, 0xffffffff, 0), > > - SYSC_QUIRK("sata", 0, 0xfc, 0x1100, -ENODEV, 0x5e412000, 0xffffffff, 0), > > SYSC_QUIRK("scm", 0, 0, 0x10, -ENODEV, 0x40000900, 0xffffffff, 0), > > SYSC_QUIRK("scm", 0, 0, -ENODEV, -ENODEV, 0x4e8b0100, 0xffffffff, 0), > > SYSC_QUIRK("scm", 0, 0, -ENODEV, -ENODEV, 0x4f000100, 0xffffffff, 0), > > -- > > 2.31.1 > > > Tested full log, > https://lkft.validation.linaro.org/scheduler/job/2641881#L1940 > > - Naresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel