From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC5F4C433ED for ; Tue, 11 May 2021 11:59:18 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24F2061007 for ; Tue, 11 May 2021 11:59:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24F2061007 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Fe5kOt0DCoa2Q7+mIrw8PIZUtLQEbLmqPW3gR6mgrpM=; b=DVhQ5AkXYy/dTOxJFMqNAvKuZ lZK18vpx7Tw5ez7ud4BhugtT53HUQV5qNafICB49VON3mVxAsB9oYpXo5pRtdm3idHDsOLfoAmBQZ +Zi+h7gWqb+GNpHFHjzg0RBNEoTzJ6ddf8A9LwQCBOc5nbKNdpACLnuqKNhnCJcKn0T0y/shUJ/pu 6adZWvL6I2L11odT5ueSo4udjChtwd8cV8AArHW4wGJgKYoNiuwOPT6dnsNn+gTukbFUhLiRWfWGb IprsuKdogfGoc22XqPypk2hVQkgT9YUhzCgbIvkta5sd42r5aU0gWz19x3iGFUh5sH2bP6gX7Pot/ 2cQ5v/7Gw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgR1U-00HFri-Tj; Tue, 11 May 2021 11:58:01 +0000 Received: from [2607:7c80:54:e::133] (helo=bombadil.infradead.org) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgNGl-00GYH7-8s for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 07:57:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=S/QitPv103F5Fk6w9tFGA9scLWKx6oxLZ4e1nVahMtw=; b=dgWYhfH6fQH/15fhqAEvkvkwxl ThPR6k7WYvGjmgKzrw41cSW2eveYDcKFD/pA/TaC1Hx8IaCn+7kFgEe9YDXSf17e5tKcMsb1aaNTw ww0UJR9RfEqsdf3IkfSxOuDnyokDasg2amXRNHRfaoYdtZNHujyfma/Cc0C8FhpBn+BCRaFE+edRH rTFo4eT+jGDt777caTVmxNi2nDiDi7/RcgDpkd4tdmRYsB9/DuG307SfCT+bAItBVQzGyELWrJwB4 Cml6XReRjfxH0oVLO7ItxmFwNXBwmh2HirwnRyIJU0bw2tEkX87cokZtvzpKM1/EPJE9vdC1Wh5PF qjEaesyQ==; Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgNGf-009NQK-Vl for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 07:57:27 +0000 Received: by mail-wr1-x42e.google.com with SMTP id m9so19125704wrx.3 for ; Tue, 11 May 2021 00:57:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=S/QitPv103F5Fk6w9tFGA9scLWKx6oxLZ4e1nVahMtw=; b=axsYHDrBYk9E/3NeWYW7ESe28m0wldJ8ylDI9300hs3QE24udpCkECgjFy53F45wax e5Oe+MUMZo8/v2kkYplL9VVt2Y+l+yNdn+EwQRvZCoHFiyCOTz1tgNweo+rV7i46tz+Z sVvythHQ8qfNTZ4VkoHFeYIoquxoAfYtmN80XpSKJFDLb6FWtO1u4nAzVyVdwe9fSb/s UP44KYTFwB1yhXxon6HSvKzEklWxei5bF6Y32VCQ7OozAXdhwqC78BAZJoBirdA2uUkD bVS2pYYz9GWx2RpJ02g+dR/CIJZFmsjIhcpzYDG7Z6ealA4cxwauxjm7N3oRXN4S5D7n NbqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=S/QitPv103F5Fk6w9tFGA9scLWKx6oxLZ4e1nVahMtw=; b=m9rlcWD84BUK3kGjiXxZ5iT9ysQ4sXaIuWoPaJ5VldbhM1ioav6xs3hHcGqfVQ42Xd 1bDbEl92NMTtzZP8wwihcHuPl8Gvb57NwRjvDNTO4zyvNgfzojVIs10aCkTwqdAVt5p4 DRKFjKMJFMnkKi2g1c+hvyf2LppfKd3MvkxjhtmYbj5KkI6LsbopmGLMjsOdCvrRdTDX dQc/V2MKb6AVwpS/1hJA2ZfFVzpiVGPSMu3W7i0UXgaisQCHH24qqif1pxuYjrmfnZy2 LZoFbfrIyMEllAe+wGCU8+AzRJAy/qtjMdh0b0o4gY66kM9yuFrGo3ESh8BkVy13DOpb 8kEQ== X-Gm-Message-State: AOAM530/s5VAapbHnLXGDPMuq8iVC/OK2Pwwa94ikq/mgbVtopPMXn4v KEzuJnRpqD5zmi54u58h5Hk= X-Google-Smtp-Source: ABdhPJypstYo5SbEWz2FNAXbRyfCjQSW/kTphjD6yGe/pk7eM2R+CJ/GoT4HhddoEyak3CI0Wz7GpQ== X-Received: by 2002:a5d:5310:: with SMTP id e16mr35088107wrv.321.1620719843880; Tue, 11 May 2021 00:57:23 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id y14sm26225211wrs.64.2021.05.11.00.57.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 00:57:23 -0700 (PDT) Date: Tue, 11 May 2021 09:57:21 +0200 From: Corentin Labbe To: Linus Walleij Cc: linux-crypto@vger.kernel.org, Herbert Xu , "David S . Miller" , linux-arm-kernel@lists.infradead.org, Imre Kaloz , Krzysztof Halasa , Arnd Bergmann Subject: Re: [PATCH 1/3] crypto: ixp4xx: convert to platform driver Message-ID: References: <20210510213634.600866-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210510213634.600866-1-linus.walleij@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_005726_070702_A22386DA X-CRM114-Status: GOOD ( 22.15 ) /bin/ln: failed to access 'reaver_cache/texts/20210511_005726_070702_A22386DA': No such file or directory X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_005726_070702_A22386DA X-CRM114-Status: GOOD ( 18.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Le Mon, May 10, 2021 at 11:36:32PM +0200, Linus Walleij a =E9crit : > From: Arnd Bergmann > = > The ixp4xx_crypto driver traditionally registers a bare platform > device without attaching it to a driver, and detects the hardware > at module init time by reading an SoC specific hardware register. > = > Change this to the conventional method of registering the platform > device from the platform code itself when the device is present, > turning the module_init/module_exit functions into probe/release > driver callbacks. > = > This enables compile-testing as well as potentially having ixp4xx > coexist with other ARMv5 platforms in the same kernel in the future. > = > Signed-off-by: Arnd Bergmann > Signed-off-by: Linus Walleij > --- > Herbert, David: I am looking for an ACK to take this > into the ARM SoC tree as we want to change more stuff in > the machine at the same time that we want to resolve > there. > --- > arch/arm/mach-ixp4xx/common.c | 26 ++++++++++++++++++++++++ > drivers/crypto/Kconfig | 3 ++- > drivers/crypto/ixp4xx_crypto.c | 37 ++++++++++++---------------------- > 3 files changed, 41 insertions(+), 25 deletions(-) > = Hello With minor editing I successfully added this series on top of my fix series= https://lore.kernel.org/patchwork/cover/1421865/ With the following patch, I successfully booted my epbx100 board and the cr= ypto driver loaded. --- a/arch/arm/boot/dts/intel-ixp4xx.dtsi +++ b/arch/arm/boot/dts/intel-ixp4xx.dtsi @@ -61,9 +61,16 @@ timer@c8005000 { interrupts =3D <5 IRQ_TYPE_LEVEL_HIGH>; }; = - npe@c8006000 { + npe: npe@c8006000 { compatible =3D "intel,ixp4xx-network-processing-eng= ine"; reg =3D <0xc8006000 0x1000>, <0xc8007000 0x1000>, <= 0xc8008000 0x1000>; + + crypto { + compatible =3D "intel,ixp4xx-crypto"; + intel,npe-handle =3D <&npe 2>; + queue-rx =3D <&qmgr 30>; + queue-txready =3D <&qmgr 29>; + }; }; }; }; So you could add Tested-by: Corentin Labbe Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel