From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2919CC433ED for ; Wed, 12 May 2021 20:08:33 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFBF161408 for ; Wed, 12 May 2021 20:08:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFBF161408 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k5FNaesY/VYxlZ4op2ELTNgRDpFMYwXOfAEMBJrU9aM=; b=I0CXAMcwGPsHTBzxiQKJ5NfOn 9Ro8NcK65880kWkw1uFV/Bz6FoT4VcbjhKW2mJPGQGuEyuCRjLV32VuzLHyLYQBvbIGUIrqxYNA2P 22X1bthL40n/xjWzq5GPTIW974j7rUPIKQxkhCT4C1wKmBF5klVU6pahv7VM0LIdXS8Y3QM0AXiNJ vBx5+WckdGKfm76a8yMLt1EfIXM+bhcRzALJiVtDnRuUCVtZueo73JN2DGZQNYlGOWCLnDKYoJOQz 3jVlYArKp8eAfSznlmdBKNlitI3vxPCDuw7HkxDpP2Ua4OI+UBeejo2Frj2vUuplA7TPz41dB9ZUi j5Cm6+tmA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgv7S-003qoE-IE; Wed, 12 May 2021 20:06:10 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgv7N-003qnV-M7 for linux-arm-kernel@desiato.infradead.org; Wed, 12 May 2021 20:06:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tyzZG/2NfEJlWglY8IDKCitTdk46LqnDd7RcMasonWM=; b=OOQj4/qQwjnPXzOjVp6+sdCMA3 vr/Q89cglzbnOUYZ5cAFGNat2JR2MIRC7ugK5KccWmhTzD5eH/ShTpkDRcJidUA9P9psIvH2T/MTt oxqafg+RtXXqScUTEEIrU6HsY4Guq2B1bRPuwF1dmt8ctx7JIiDaFWCs8rqT1wMNtjLYmLJboNn/1 HqjUJZEMjS36DsZ6Nrea91KRJ7oY4bQZiWM95mM5XQBOViUUTrU3UNPSukH4Z0UfOvIAq+FnF8PyH jAk6WBCO1DvpfbHmC0PWnnaOh1iP9RacW60lHJ3woKboPkW1p7Z2Q0b9kYkVR/b1txTP8f3MJTbJ5 BFpsY1iw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgv7L-00AmiM-81 for linux-arm-kernel@lists.infradead.org; Wed, 12 May 2021 20:06:04 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7028C61408; Wed, 12 May 2021 20:06:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620849962; bh=QQfyPA2bVAhyX/rOl9YJ4esWVuFWaoi+C+eJcg9P1ZI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qPbmnlRzEOq2EYn0QnCivlyyxTPzs67SCwCKbY/BC0Hec2HrNRKomvk/+GKtXsTKC gdGL9CDENOLpR/PxmhMdJc1iuwAobNUVf7Rr6E/fPItTVPkXY3Cmz4IZAN7xfwtAwG MGoRPT1Illjx+wtlYVEQUjbQkeoKq/xnCTf2FZL6tW2ZejnDJCRpZRiku9NgIfDqR9 UiYkwC8TBrGvEo/b94tjKQua+0oDSeEtMF5lQVw0SwliIZli+amH1/HrqtGIGzvjP7 DDxRm7JopOF3o3Jv+9BFaYZTHJEnZJyMcnT918RItEKTUFNYc6X4AxFvbC5vs0kF4e zQSFZN5WwAnvw== Date: Wed, 12 May 2021 13:06:00 -0700 From: Eric Biggers To: Ard Biesheuvel Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, herbert@gondor.apana.org.au, will@kernel.org, kernel-team@android.com Subject: Re: [PATCH v3 2/7] crypto: aead - disallow en/decrypt for non-task or non-softirq context Message-ID: References: <20210512184439.8778-1-ardb@kernel.org> <20210512184439.8778-3-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210512184439.8778-3-ardb@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210512_130603_335880_D8A5B542 X-CRM114-Status: GOOD ( 16.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 12, 2021 at 08:44:34PM +0200, Ard Biesheuvel wrote: > In order to ensure that kernel mode SIMD routines will not need a scalar > fallback if they run with softirqs disabled, disallow any use of the > AEAD encrypt and decrypt routines from outside of task or softirq context. > > Signed-off-by: Ard Biesheuvel > --- > crypto/aead.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/crypto/aead.c b/crypto/aead.c > index 16991095270d..b5304b3d3314 100644 > --- a/crypto/aead.c > +++ b/crypto/aead.c > @@ -87,6 +87,11 @@ int crypto_aead_encrypt(struct aead_request *req) > unsigned int cryptlen = req->cryptlen; > int ret; > > + if (!(alg->cra_flags & CRYPTO_ALG_ASYNC) && > + WARN_ONCE(!in_task() && !in_serving_softirq(), > + "synchronous call from invalid context\n")) > + return -EBUSY; > + > crypto_stats_get(alg); > if (crypto_aead_get_flags(aead) & CRYPTO_TFM_NEED_KEY) > ret = -ENOKEY; > @@ -104,6 +109,11 @@ int crypto_aead_decrypt(struct aead_request *req) > unsigned int cryptlen = req->cryptlen; > int ret; > > + if (!(alg->cra_flags & CRYPTO_ALG_ASYNC) && > + WARN_ONCE(!in_task() && !in_serving_softirq(), > + "synchronous call from invalid context\n")) > + return -EBUSY; > + > crypto_stats_get(alg); > if (crypto_aead_get_flags(aead) & CRYPTO_TFM_NEED_KEY) > ret = -ENOKEY; This probably should go after crypto_stats_get() so that the error gets counted in the stats (if stats are enabled) -- analogous to how the ENOKEY error is counted. Likewise for the skcipher patch. - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel