From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87842C433B4 for ; Wed, 12 May 2021 20:14:19 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2851D60BBB for ; Wed, 12 May 2021 20:14:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2851D60BBB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eWUeGhXV8duU/XWek25Mrobh4PReLHOYOCDxq6s9UjE=; b=S5A3QsvIh9BnfWuvZYyg0cN36 JRbNx9KuafFLrRBlqxanfLKTUdkckFgMlT6REMZqGW+nQljWZ0nEZm1UMa4omVRZ4YIfSReRn3OHV etSAJBtnGYOjBh9UIezbXMETgNkk70sz/KElEeQnMrNx56QtBjSyFTJCfrhGUd8DUfPn6opzXOOP2 HWDdetsou1bvAYD474pwy+P7sFTjPHs0JoLF4T7KL8fK5in64yTkceiMcTz2mhVYNF6CTsM3effD0 4HWxHsWQzaXVYyJ46/6QkLlzKKlA2IvV241ZTCAKD1FGiMefdLcQUB7ArSLfh3lucLCAy76q9skHD 5xB2SBHNw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgvDE-003sVl-BH; Wed, 12 May 2021 20:12:08 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgvA3-003rVH-7D for linux-arm-kernel@desiato.infradead.org; Wed, 12 May 2021 20:08:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lAujjZ3K+53xSYr8nXfEmNZM9gZsdcBcSRruj2w/jBI=; b=kqL2IwsRt9fkfCSgI6wA+fIiSk /ATcR8DvSsprdn/l9bJlyA51WUHYVcxldkb0S7TnF+gpR3+N3BChBiMkqfOCeHBDf1NxLBZ8oEiX/ ZPcacXJ9AmnxizpCeROxDzr4eoqv/LxDtFiTVTrPlFAqAPQrnGT5XQ9hd6/uYhkqJrp7jj3ML1Zhn mMw3slMqyBBRBKPi3Ozl3DWjWGXwx2yOHex8AsFoQny7Q6+V8w0CpYzIe6HJDU+xscWoytZ2qMmG0 cS+CDDVM5S4ymqWmOU76HqNfkmvzhiAKmhXY7GCEvP7oZsyqVuw24n+PArl8YAmovRkWjlzTABETX VEG/TvnQ==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgvA0-00AmtN-PZ for linux-arm-kernel@lists.infradead.org; Wed, 12 May 2021 20:08:49 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id EC11C613FB; Wed, 12 May 2021 20:08:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620850128; bh=36cqi9wAZ8Ti0+6IfUg3LWypVtFAf7LGyg3uyNPITkA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KYbCW6+aTm/son93aWv64TKSMBBME5E+nrCtN9bBV8C5t1WAHNrX5H7in5bmyP2EZ FWqRXEY4/g8oQgFGXvdI8W4/HJeWlXdYaQKVxHj10sZxlSY58GwviPrxFoSOfOo4HP Sp7jeMP7Phj41bTDubxjzc84fmQR2DiwKu5ydi3NTjTgJO/fRU8QYwAeZ+8eQwH/DB XZsGDxzK9S76TUixPlEFvOTxJLVlksn+3KISOt+CS59tdXB8mTGCrMTe861Z/z2K77 RIVVCiMiDwsyvn/j91S4qkDxs7XjRn0uPS2XY3hInuVJlBSViDIJEQ8+0u7CETX2zC 1pzW5h1II+asQ== Date: Wed, 12 May 2021 13:08:46 -0700 From: Eric Biggers To: Ard Biesheuvel Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, herbert@gondor.apana.org.au, will@kernel.org, kernel-team@android.com Subject: Re: [PATCH v3 5/7] crypto: arm64/aes-neonbs - stop using SIMD helper for skciphers Message-ID: References: <20210512184439.8778-1-ardb@kernel.org> <20210512184439.8778-6-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210512184439.8778-6-ardb@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210512_130848_883899_6825AD7B X-CRM114-Status: GOOD ( 10.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 12, 2021 at 08:44:37PM +0200, Ard Biesheuvel wrote: > Calls into the skcipher API can only occur from contexts where the SIMD > unit is available, so there is no need for the SIMD helper. > > Signed-off-by: Ard Biesheuvel It would be helpful if the commit message made it clear that "Calls into the skcipher API can only occur from contexts where the SIMD unit is available" is something that is now the case but wasn't the case previously. Otherwise I could see people backporting this patch without its prerequisites. Likewise for some of the other patches in this patchset. - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel