From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1226C433B4 for ; Wed, 12 May 2021 20:18:59 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B456613FB for ; Wed, 12 May 2021 20:18:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B456613FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=59zvRiznhY6RY4zsWxQMJ0/V4WBb1JVdoIIiZuyFuL8=; b=JajPq34jo236cKVjdF8bcJTvF 6jwkizH0JXkD3yRK2cFkCNzdDJgg+akNF/YUWDsB/NyOOpCubK10hHmiZCc3Ik82m2XIuNdNWJuGF OMST+FyNblQFSZaxSzgX+6xQ89O2b/z7ZKlac/3hTBK9seWB8+XaaosYCjHvUKTfsgWJjsn7ExMF6 diZXyAmU4KnaXFkLTim7zHr3Ys39em2sCPBL7tcmnm6JJyGYQmlhZ7JkhktWAEIsV4z0TdcGGY1xU i++fBoDHKdpPVIRvC17v2LPNVSoknOCnOsHnnDNkcHLxSq2YrmEj+Lk8FBZa189LNPjBNzH4DiiUK MLnZYphVw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgvHh-003tfO-TT; Wed, 12 May 2021 20:16:46 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgvCW-003sLY-F8 for linux-arm-kernel@desiato.infradead.org; Wed, 12 May 2021 20:11:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HvgbDMmgbSMPuPAkco43ngeBnP2qFxEebUsYWErODco=; b=hS+ZVh632HU0TBhT5U8BqM6K29 wsB6TltR3vkgZ3anzQ2XqJ52O8lcFPN/Hh6DmbfUl0ip0ZgHZaX04ebeiJDlKrg2VR7ZZRt5QJyHL WWYCrMsP/xCEHKEAzlQsWYCR5+Vuji5XX4QAtV4RsJv9IWyjYZVBB/G62fpqrEu7onJd6iwdIq6Dd Sscm3lHROPTum0FWRgO0U8NF8xXXNXlUhriUpcihl9P0Dbiy/gBcB1ZNyFe+vKAYROxvGN431QnVE n8D2RCJkuq1r5vmHJJstjuqicQheCEBBtDXkSw1c4agZmK4CDTq+CqD/1Ywu88orbjsthE3thaBoG aOvsqHMA==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgvCT-00An3J-JA for linux-arm-kernel@lists.infradead.org; Wed, 12 May 2021 20:11:22 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id BAA43613FB; Wed, 12 May 2021 20:11:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620850281; bh=3TFHlYbgs5TDv6kvL2Z+EmWCUhN1bJEXciDXrAKpvaw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Rdka4BjJS9gRKT1s96RPLFKpXqumhSWbtmiAwgtAtPvQBzC/DfutQrh8nkBo2UIX5 x5g9EWu3Kqo6bj5PIyBhaLECP60eGeLX2tdfHlH8+K4BWCCVQX1FQEuxYdsS5bkfy/ YDg5LXXyZzD0yewhKXuVaodgEHmWPgfiyaRTPac0RHhAoC6gDV4qugtg1rqKo6Y29w y40ut5X3jLWoqBiCKBgG8F8kNxd7cJ5cCkLOtMQf/ZQRCbbWFEmoZlmwL67nS6PDOB /YVZT/Mqlhj2h3tb7cHCRpBaeRsBGT0vZzhVaMnInn+rPX2+9PQrHhnJonvnwgdPeH /4nJqPHRhQt5w== Date: Wed, 12 May 2021 13:11:19 -0700 From: Eric Biggers To: Ard Biesheuvel Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, herbert@gondor.apana.org.au, will@kernel.org, kernel-team@android.com Subject: Re: [PATCH v3 0/7] running kernel mode SIMD with softirqs disabled Message-ID: References: <20210512184439.8778-1-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210512184439.8778-1-ardb@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210512_131121_682630_0D5E031A X-CRM114-Status: GOOD ( 16.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 12, 2021 at 08:44:32PM +0200, Ard Biesheuvel wrote: > This is a follow-up to [0], but given that the arm64 architectural > pieces have been merged for arm64, the only remaining changes are crypto > specific. Therefore, the audience has been reduced to those people who > are likely to care about these specifics. > > Patch #1 addresses an issue in the skcipher walker which doesn't handle > zero sized AEAD inputs entirely consistently, which is uncovered by the > change in patch #7. > > Patches #2 and #3 add some sanity checks to the public AEAD and skcipher > APIs to limit their availibility to either task or softirq context > (which is the only way in which they are currently being used). Adding > this restriction permits the arm64 crypto code to get rid of all scalar > fallbacks, given that on this architecture, softirqs are no longer > served while the SIMD unit is being used in kernel mode, which means > that the scalar fallbacks are never needed. These are removed in the > remaining 4 patches. > > [0] https://lore.kernel.org/linux-arm-kernel/20210302090118.30666-1-ardb@kernel.org/ Did you check whether any updates to the self-tests in testmgr.c are warranted? Specifically, is disabling the use of SIMD for testing still something that makes sense? - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel