From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C06F9C47082 for ; Wed, 26 May 2021 13:48:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EBE6610A6 for ; Wed, 26 May 2021 13:48:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EBE6610A6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+MvJWAZDjVfo2wt6ouoURwVqxz3gEqQlaYHibqKKRLA=; b=pWiPY6dHTfaotE0aPPkaJ32ZpY sF9M2ZoYEXFhhEra3PVhj+jvGdMYHXucgp8l5hj27Bmms3z4seXB+8x8hkMJoxfU51fnXymMsAOAQ vi64Y7TXGuUsFcffcciUSReaHIZBjSQS7uyXPe2pkpNq9T/37FZftGVhW/U5nPmKe2NvlFd98LNut dI4KSJ3Q4v4ituIczHRFC7e0Lq/TEZA9zWuBbjgvcCacZzICQ9bDGDsPkMgRxWv63ZVEn8UybCTdD zJCXhUhJI5wjcrB8MF2TvgQBHegZnnEeIbqiLubW2q5mL0aMMyikjDy2dUyTS08xP0ekF7KIgzuRe /MpOMWkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lltrS-00EZ0u-H2; Wed, 26 May 2021 13:46:15 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lls9n-00DkQo-0x for linux-arm-kernel@lists.infradead.org; Wed, 26 May 2021 11:57:05 +0000 Received: (Authenticated sender: paul.kocialkowski@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id A297F1BF213; Wed, 26 May 2021 11:56:52 +0000 (UTC) Date: Wed, 26 May 2021 13:56:52 +0200 From: Paul Kocialkowski To: Hans Verkuil Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devel@driverdev.osuosl.org, linux-sunxi@googlegroups.com, Yong Deng , Mauro Carvalho Chehab , Rob Herring , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Jonathan Corbet , Kishon Vijay Abraham I , Vinod Koul , Helen Koike , Dafna Hirschfeld , Greg Kroah-Hartman , Philipp Zabel , Sakari Ailus , Hans Verkuil , Thomas Petazzoni , kevin.lhopital@hotmail.com, Ezequiel Garcia Subject: Re: [PATCH v5 02/16] phy: Distinguish between Rx and Tx for MIPI D-PHY with submodes Message-ID: References: <20210115200141.1397785-1-paul.kocialkowski@bootlin.com> <20210115200141.1397785-3-paul.kocialkowski@bootlin.com> <58d6651d-09c3-2b93-bd5b-1807744b2354@xs4all.nl> MIME-Version: 1.0 In-Reply-To: <58d6651d-09c3-2b93-bd5b-1807744b2354@xs4all.nl> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210526_045703_372550_A646F7EF X-CRM114-Status: GOOD ( 26.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2228280961316840757==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2228280961316840757== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UpT672IaWUX8kc9y" Content-Disposition: inline --UpT672IaWUX8kc9y Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed 26 May 21, 13:50, Hans Verkuil wrote: > On 15/01/2021 21:01, Paul Kocialkowski wrote: > > As some D-PHY controllers support both Rx and Tx mode, we need a way for > > users to explicitly request one or the other. For instance, Rx mode can > > be used along with MIPI CSI-2 while Tx mode can be used with MIPI DSI. > >=20 > > Introduce new MIPI D-PHY PHY submodes to use with PHY_MODE_MIPI_DPHY. > > The default (zero value) is kept to Tx so only the rkisp1 driver, which > > uses D-PHY in Rx mode, needs to be adapted. > >=20 > > Signed-off-by: Paul Kocialkowski > > Acked-by: Helen Koike > > --- > > drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c | 3 ++- > > include/linux/phy/phy-mipi-dphy.h | 13 +++++++++++++ > > 2 files changed, 15 insertions(+), 1 deletion(-) > >=20 > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c b/driv= ers/media/platform/rockchip/rkisp1/rkisp1-isp.c > > index 2e5b57e3aedc..cab261644102 100644 > > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c > > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c > > @@ -948,7 +948,8 @@ static int rkisp1_mipi_csi2_start(struct rkisp1_isp= *isp, > > =20 > > phy_mipi_dphy_get_default_config(pixel_clock, isp->sink_fmt->bus_widt= h, > > sensor->lanes, cfg); > > - phy_set_mode(sensor->dphy, PHY_MODE_MIPI_DPHY); > > + phy_set_mode_ext(cdev->dphy, PHY_MODE_MIPI_DPHY, > > + PHY_MIPI_DPHY_SUBMODE_RX); >=20 > drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c: In function =E2=80= =98rkisp1_mipi_csi2_start=E2=80=99: > drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c:951:19: error: =E2=80= =98cdev=E2=80=99 undeclared (first use in this function) > 951 | phy_set_mode_ext(cdev->dphy, PHY_MODE_MIPI_DPHY, > | ^~~~ >=20 > Huh? Oh wow that's quite shameful. Apologies here. Note that I'll rebase/respin this series. I also remember that it wasn't ve= ry consensual (on IRC) to use a submode to indicate rx vs tx mode and that specifying that in the deivce-tree would be a better fit. Cheers, Paul > Regards, >=20 > Hans >=20 > > phy_configure(sensor->dphy, &opts); > > phy_power_on(sensor->dphy); > > =20 > > diff --git a/include/linux/phy/phy-mipi-dphy.h b/include/linux/phy/phy-= mipi-dphy.h > > index a877ffee845d..0f57ef46a8b5 100644 > > --- a/include/linux/phy/phy-mipi-dphy.h > > +++ b/include/linux/phy/phy-mipi-dphy.h > > @@ -6,6 +6,19 @@ > > #ifndef __PHY_MIPI_DPHY_H_ > > #define __PHY_MIPI_DPHY_H_ > > =20 > > +/** > > + * enum phy_mipi_dphy_submode - MIPI D-PHY sub-mode > > + * > > + * A MIPI D-PHY can be used to transmit or receive data. > > + * Since some controllers can support both, the direction to enable is= specified > > + * with the PHY sub-mode. Transmit is assumed by default with phy_set_= mode. > > + */ > > + > > +enum phy_mipi_dphy_submode { > > + PHY_MIPI_DPHY_SUBMODE_TX =3D 0, > > + PHY_MIPI_DPHY_SUBMODE_RX, > > +}; > > + > > /** > > * struct phy_configure_opts_mipi_dphy - MIPI D-PHY configuration set > > * > >=20 >=20 --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --UpT672IaWUX8kc9y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmCuN4QACgkQ3cLmz3+f v9G56Qf/VeVonmPZ3GPceNXtCiCz4D3aCK6rystut/m1RJlgBSNwDeUtp1Pb0PK5 tNuJ63rQ+pUuI0iFSlITn6EEQoUe6ohyMwWHSwajXbNd0hPRo0Td6pxNUpjM0/+Y S3g9L9rsAQ191UhXje7YOZnS7baMLQ4Kk6fv86zvzoSZkTFdOcbhgc4O4OhDoOee K7vqfkdk1fZdnb2RKoiET9Z2AoIomE6PmrC13LZFImyVQY10zMjmNO55pu9mscU1 YxtJpIol8m7xmRR77/8W0TMQRx7IhEsNnTEdsI+fCGov8sINrkteVLFLSwl/Y8Kc Ql608acppD8E4uziTLEqWfpEyzt5fg== =juJ8 -----END PGP SIGNATURE----- --UpT672IaWUX8kc9y-- --===============2228280961316840757== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2228280961316840757==--