From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 675ADC47089 for ; Thu, 27 May 2021 09:12:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2451D610A0 for ; Thu, 27 May 2021 09:12:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2451D610A0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8VOnm+sWER7Xbg3X/qda77WMlV2RB4oSOmhzd6IsTO8=; b=OcSpS+8simSOwR 25WAl18emwrmf+ldpxBlu4Mg9Kk0Vhk02+ono9OobDclH9o716PxpYwUTgUA+HmpJmfr7IW38d2cj yn/9HbpbqbMWEa9cCGLB2sy0xaZE8DXoyg89Nd/XC8PXzfh+jkEU3ApmIwUerVhjNtY/gCSTOfNvq vWssCDqTz7tMYXQrXlNMEfpAIvK9XItec7li9ZwMk+CnqR4dGQolCs3AdS65L8ejWvuewdAI9TVoO DqVYkFFEC+CH8v9bfIccXw3BK6Y4PW4QUSNVzFbnK+m5Ki9SYd/9OP4ILLSinTqN+AAZAApjVLihA oLBIPTfHNdPfjBVHsjHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmC1F-004AfC-0n; Thu, 27 May 2021 09:09:33 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmC19-004AcC-9a for linux-arm-kernel@lists.infradead.org; Thu, 27 May 2021 09:09:28 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id F289180A8; Thu, 27 May 2021 09:09:29 +0000 (UTC) Date: Thu, 27 May 2021 12:09:21 +0300 From: Tony Lindgren To: Grygorii Strashko Subject: Re: [PATCH v3] ARM: dts: dra7: Fix duplicate USB4 target module node Message-ID: References: <20210526213035.15448-1-g-tammana@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210527_020927_414355_BEE14FD8 X-CRM114-Status: GOOD ( 12.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nisanth Menon , devicetree@vger.kernel.org, Gowtham Tammana , linux-kernel@vger.kernel.org, robh+dt@kernel.org, bcousson@baylibre.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Grygorii Strashko [210527 09:03]: > On 27/05/2021 08:48, Tony Lindgren wrote: > > But let's keep the target-module@140000 here as it puts it in the right > > location rather than directly on the ocp. Let's mark it with > > status = "disabled" in dra7-l4.dtsi, and add a comment noting it's only > > available on dra74x. So similar to what you had in your v1 patch, except > > disabled. > > My preference would be not to mix SoC variant specific modules in common module, > and fix dra74x instead by placing usb4 node in proper place: > > &l4_per3 { /* 0x48800000 */ > segment@0 { > --> Yeah that's even better, and leaves out status = "disabled". Sounds good to me. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel