From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5F77C2B9F2 for ; Sat, 22 May 2021 06:36:21 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7534C610C8 for ; Sat, 22 May 2021 06:36:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7534C610C8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OYr/jXy0GBvAypPr3yNNe6O2UOneDCy/40tOfkvi2gA=; b=RusfP9Yf347PmjWpp4g6ECxdow ENeg3yRWFSG+qPCID3mCi7jeZZTRUbq/5sZoNDE1yZ9kkmWh/MWR1e2RIgg9/pDD4fA43qBfy9Mow 2eZnAVMABHc+Xgxtu+QnVA/J7UvHSTFaXw54PGC6bcqYYH8NZ8bXOu2f+aj6mx8Xo57ltZ/bD/EOe Yfh/36sZ+4Vfp+yzkAtJheyAEWZgLEv6dJeaWfG5bzBJcJYC17+mcA4aAMY7dzRWMzES5ohtgBjnc vo/zVKpXmBZj0pTjV32Vbb6s39ywdElo6HyNCb59GVM+YIrr3viV2NjYygeqQPauYthhjwbdDN2wx 6PxYNZ1A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkLDL-001y4u-5y; Sat, 22 May 2021 06:34:23 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkLDD-001y42-N2; Sat, 22 May 2021 06:34:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QVtzUcWT8sVNK0pY56zfNKAirb2RC6eBzB8djp3s4hE=; b=RwIlNbbEeSNRSUV9a4ncwjAKXa fqSmJjkHMlS+r/dl5IPjoL+9/i3kOV1AklVBkINaWlJP9TjIbhoDdMWVYt/entl1nhPaXdp+gg/ZE FJLqEBz9auCLl+v0+tVGaQb5lwklc0a+fTeYYxp8yQehiWVHkQLJOGBD4nZuz+5u1+t5gc/06dp0e kRg6GmdUPDZGN+hlPXeYKI8tOPt6wse5KI9XWnk1pUaKIjpx0G0lRpP9WTLwkLsNoGU8WyJ2xKdpf tLVuvcOWFFiNHgKdgoHBLm0PBrdyzmLa0UFQJGFBwOX/3vhavOYB4ncQ8PtoX8yVGrhSyD6tB6tvA elXOQtIw==; Received: from zeniv-ca.linux.org.uk ([2607:5300:60:148a::1]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lkLDA-0001ZI-Mp; Sat, 22 May 2021 06:34:14 +0000 Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkLCh-00HMua-KY; Sat, 22 May 2021 06:33:43 +0000 Date: Sat, 22 May 2021 06:33:43 +0000 From: Al Viro To: Nguyen Dinh Phi Cc: nsaenz@kernel.org, gregkh@linuxfoundation.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, phil@raspberrypi.com, amarjargal16@gmail.com, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vchiq_arm: Using copy_from_user() to copy data from userspace address Message-ID: References: <20210522053429.82710-1-phind.uet@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210522053429.82710-1-phind.uet@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_233412_764157_0E8F2BE2 X-CRM114-Status: GOOD ( 15.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, May 22, 2021 at 01:34:29PM +0800, Nguyen Dinh Phi wrote: > This commit to fix the following sparse warning: > incorrect type in assignment (different address spaces) > expected void *[assigned] userdata > got void [noderef] __user *userdata > > Signed-off-by: Nguyen Dinh Phi > --- > .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index afbf01b7364c..2a4fc599f977 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -960,7 +960,10 @@ static int vchiq_irq_queue_bulk_tx_rx(struct vchiq_instance *instance, > current->pid); > userdata = &waiter->bulk_waiter; > } else { > - userdata = args->userdata; > + if (copy_from_user(userdata, args->userdata, sizeof(args->userdata))) { The contents of userdata (local variable of type void *) is uninitialized at that point. Just what do you think that call of copy_from_user() would do? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel