From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8DCAC2B9F7 for ; Tue, 25 May 2021 02:27:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1F8C613EC for ; Tue, 25 May 2021 02:27:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1F8C613EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RLRSQ/+hpDWGX3HkoVqudavuqdumkSG3LXGO5iEWP9g=; b=h+KMoHtGTOgexP kthnuaMuUIDKT9O3+VKbZCi5cbw22K2IivEgWEAa+OLT281eCzPdPhYTug0umVLkcQaKjNUb/VH06 JBOjeD0d6YiWFe/jL2DEe9WyrswAxXFWRgH1vOch+8Dz1Bo0pPkssoAAqPifV9BmKvwSwLCW8PdzL JUZN/yy+PdnB7XFQW97GxqGhAUESGAjIXXyhJ0Fzcfue8dfIhcoXmTqOkMmnkyOcEwnZaN4VI/JRM myGp7dSIjOlEgbWePDL1awLfwtrJVKf1Jy/S+IX8VvMiLFoDPBye6VN9Ti6IwDHqwU+/ZYn1nAh8f sIxOYMxOqx/PmTBG36Rw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llMlx-002ueV-0S; Tue, 25 May 2021 02:26:22 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1llIUL-0020Ol-If for linux-arm-kernel@lists.infradead.org; Mon, 24 May 2021 21:51:54 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E90DC6140F; Mon, 24 May 2021 21:51:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621893113; bh=JwMiFlepZGdEM/tdol4UXFMcLZi3bjn72+O7tDFU0Do=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jAHeNEXojAa3f0L/BAj6/GjWI6Su8ad7XgOWUW7i3e+A/Pl/U7lMgoh/HQW/iaTAT JEPgzHGvBEom9m7oPCrrgGykdjwgiWO3PwUAD2/kiGhNPmBUEsY6d+DoEruT4oujTv +YRklIxgG6AmSBZ/2heUh30UxSRx+3bv0tlco1rtUIu3HXamxM1JUPZdTBDSDQePGa /bZGgYyOhhSk3jMm5QDlF9OgcsWiaDj9Q17lgbH/0NffMp+6ZuLNFAm1sWLM92UNNl Twhp0oeaNAMETeHeENHUBd2rmy/v61DLDS2x2dlmeOm2v12Uc9ctDca39nafp/AYu2 xT4Lrwhyjm6vQ== Date: Mon, 24 May 2021 14:51:51 -0700 From: Eric Biggers To: Ard Biesheuvel Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, herbert@gondor.apana.org.au, will@kernel.org, kernel-team@android.com Subject: Re: [PATCH v5 4/5] crypto: arm64/aes-ccm - remove non-SIMD fallback path Message-ID: References: <20210521102053.66609-1-ardb@kernel.org> <20210521102053.66609-5-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210521102053.66609-5-ardb@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_145153_681340_356B7118 X-CRM114-Status: GOOD ( 15.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 21, 2021 at 12:20:52PM +0200, Ard Biesheuvel wrote: > AES/CCM on arm64 is implemented as a synchronous AEAD, and so it is > guaranteed by the API that it is only invoked in task or softirq > context. Since softirqs are now only handled when the SIMD is not > being used in the task context that was interrupted to service the > softirq, we no longer need a fallback path. Let's remove it. > > Signed-off-by: Ard Biesheuvel > --- > arch/arm64/crypto/aes-ce-ccm-core.S | 1 + > arch/arm64/crypto/aes-ce-ccm-glue.c | 181 ++++++-------------- > 2 files changed, 53 insertions(+), 129 deletions(-) This doesn't just remove the no-SIMD fallback, but it also does some refactoring. Notably, it starts to process all the authenticated data in one kernel_neon_begin() / kernel_neon_end() pair rather than many. Can you explain why that is okay now when previously it wasn't, and also split this into two separate commits? - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel