From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 068DDC4708D for ; Fri, 28 May 2021 07:07:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0D98611C9 for ; Fri, 28 May 2021 07:07:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0D98611C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dsXo16HYBdf1P8qeaoilcITruCZ6naBL3nrke8dh+wo=; b=V+h8zrp0guSUTT ZrBCqJEYOaF2rYXjYb4GzOwDb0sdKQVW/X/n+SnjNGcwTV5SBe7e8PrcMnxRv7rcqZV9EbI1kLMwb /iNUoMRbyEPrhgIV0W6cbc2qBGEny8D+9fvC1vx8IQQto4+/oFR4PTGf5riNd3ia8ECgR0owyggLp 6JX/1NU8CZNLKmX6MqKTkvRhSN/9dlFv4LuETwUJrLC7O0Vyl0x7eoCBZfkLP3EYKW4s8NQGl8W/5 XuZO7EFLFp71C36GFZZnG8AwYlb9P4vz1r1pmTmmC8JovHbP0l3XhVrxr4SNsIQhDwFxQp7uycpvE tke+Cc5AGFXVAT2KYMiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmWZE-00CpXX-T3; Fri, 28 May 2021 07:06:01 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmWZ7-00CpUt-GV for linux-arm-kernel@lists.infradead.org; Fri, 28 May 2021 07:05:59 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 6A6D4809F; Fri, 28 May 2021 07:05:56 +0000 (UTC) Date: Fri, 28 May 2021 10:05:47 +0300 From: Tony Lindgren To: Grygorii Strashko Cc: Vignesh Raghavendra , Greg Kroah-Hartman , Rob Herring , linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Linux ARM Mailing List , Dario Binacchi Subject: Re: [PATCH] dt-bindings: serial: Move omap-serial.txt to YAML schema Message-ID: References: <20210527165636.939-1-vigneshr@ti.com> <3760d1e6-2121-323b-d962-60e8291d0bb7@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3760d1e6-2121-323b-d962-60e8291d0bb7@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210528_000553_622530_F47E72B1 X-CRM114-Status: GOOD ( 15.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Grygorii Strashko [210527 17:49]: > > > On 27/05/2021 19:56, Vignesh Raghavendra wrote: > > Convert serial-omap.txt to YAML schema for better checks and documentation. > > > > Signed-off-by: Vignesh Raghavendra > > --- > > .../bindings/serial/omap_serial.txt | 40 ------ > > .../bindings/serial/ti,omap4-uart.yaml | 116 ++++++++++++++++++ > > 2 files changed, 116 insertions(+), 40 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/serial/omap_serial.txt > > create mode 100644 Documentation/devicetree/bindings/serial/ti,omap4-uart.yaml > > Why omap4? Seems ti,omap-uart.yaml is more suitable. Additionally omap-serial should be deprecated in favor of 8250_omap and omap-serial not used at all in general. It seems some folks still stick to omap-serial for legacy reasons when using an old .config. That's easy to fix by just changing inittab to use ttyS instead of ttyO, the kernel cmdline is already fixed up on init to use ttyS, but might as well update the bootloader cmdline too. But why do we even allow using this driver on newer SoCs when we have already planned to deprecate omap-serial.c years before the new SoCs? I suggest we make omap-serial deprecated for all SoCs, and not even allow it for am6, omap-serial.c only lists these: { .compatible = "ti,omap2-uart" }, { .compatible = "ti,omap3-uart" }, { .compatible = "ti,omap4-uart" }, And folks are also using it for some rs485 cases that should just be really fixed for 8250_omap instead.. Adding Dario to Cc because of these omap-serial patches: e2a5e8448e73 ("serial: omap: fix rs485 half-duplex filtering") 45f6b6db53c8 ("serial: omap: don't disable rs485 if rts gpio is missing") Dario, why not use 8250_omap instead? Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel