From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E147EC4708F for ; Mon, 31 May 2021 08:59:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A04D9611CA for ; Mon, 31 May 2021 08:59:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A04D9611CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FlrblnwkYIbXgmjzpN85Og/gvzO0u6i4C2O+j/np+ow=; b=WloTt9z/9t9GQy 8bLji6UqFfWwcoF/atuFJ5mQduH3UsFk6OQvwSjcM/bND7zxwzeyO2dWcfwckSSfrwVmrWmrKOSE7 qbWCJhdigpcE4vE0ynTCB9Toaa/y+0k4vbcYIYGt53zgex7pR/SCb3iTDoU+GdDcQsSzNYYj79JQd GGKt2L786tRhI4s3lLkv3HCIBe2tNWvT8ghpc2wPs4KOeae9iF6xU4x/zM9OBvM8Pcde6UOe5lo7a REx1xyTn26hhlPI84XLXUL6VjAWFkC3/BB6F+N8kTJlYeZXJXFK9scnBXtKwFlEEj6cMyA0to4CaN clZ+CRt3fyrQtGtCCc+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lndjz-00BZPa-74; Mon, 31 May 2021 08:57:43 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lndju-00BZOk-Vt for linux-arm-kernel@lists.infradead.org; Mon, 31 May 2021 08:57:40 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id BEA5160FDA; Mon, 31 May 2021 08:57:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622451458; bh=S4X7tjaYcmG+zC4vTgFFWerXX/yrMd1EXDBKdDLGVGs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NMRcfzNTf5DJGgFY0NSMAIiYMFXcMYDaaT697DypVI0j9Hxccv4uEY8ac/xGzz+Qe 4Mis69v7uQT9bbwNRONLbe4L+EHFObCfMPKoskePUeOJUNfAOCZLXqUYrrHq7BCSCV k+vgOLaaO9Uex42Y8t5GHG56ckGcRq4n8XYX4AFiL8qP7CFvpbycXG8kKMcbcDVlG/ 7Vym5LmsBxTby8imdj4THUJLALlrzWXXV4igJmYA8sFQu9WEVf+rrZvxg1mbyJSVqN ptlH5enhQUmghFUzum8tokhSMbp7ZQmI/hitv4cjZ/EwF+Lk2aY4dge8a3KbtxPS7C LElmlJPcoyTpg== Date: Mon, 31 May 2021 14:27:34 +0530 From: Vinod Koul To: "yukuai (C)" Cc: mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, michal.simek@xilinx.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, yi.zhang@huawei.com Subject: Re: [PATCH 2/3] dmaengine: usb-dmac: Fix PM reference leak in usb_dmac_probe() Message-ID: References: <20210517081826.1564698-1-yukuai3@huawei.com> <20210517081826.1564698-3-yukuai3@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210531_015739_092406_D6DFFF0E X-CRM114-Status: GOOD ( 21.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31-05-21, 14:11, yukuai (C) wrote: > On 2021/05/31 12:00, Vinod Koul wrote: > > On 17-05-21, 16:18, Yu Kuai wrote: > > > pm_runtime_get_sync will increment pm usage counter even it failed. > > > Forgetting to putting operation will result in reference leak here. > > > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > > > counter balanced. > > > > > > Reported-by: Hulk Robot > > > Signed-off-by: Yu Kuai > > > --- > > > drivers/dma/sh/usb-dmac.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c > > > index 8f7ceb698226..2a6c8fd8854e 100644 > > > --- a/drivers/dma/sh/usb-dmac.c > > > +++ b/drivers/dma/sh/usb-dmac.c > > > @@ -796,7 +796,7 @@ static int usb_dmac_probe(struct platform_device *pdev) > > > /* Enable runtime PM and initialize the device. */ > > > pm_runtime_enable(&pdev->dev); > > > - ret = pm_runtime_get_sync(&pdev->dev); > > > + ret = pm_runtime_resume_and_get(&pdev->dev); > > > > This does not seem to fix anything.. the below goto goes and disables > > the runtime_pm for this device and thus there wont be any leak > Hi, > > If pm_runtime_get_sync() fails and increments the pm.usage_count > variable, pm_runtime_disable() does not reset the counter, and > we still need to decrement the usage count when pm_runtime_get_sync() > fails. Do I miss anthing? Yes the rumtime_pm is disabled on failure here and the count would have no consequence... -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel