From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22B99C4708F for ; Wed, 2 Jun 2021 09:00:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E022C613D5 for ; Wed, 2 Jun 2021 09:00:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E022C613D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LtM1KusgKqpOBQ8VyFMhZHl0GiSBhfGUh+6caqwdoMY=; b=0L4XWvDNxSwlpFEgELLrKRPjan uzVm6H+6hzgeU4abGKxKD+NGizdrTwsMSIjzsipP2xv2T3rTNRMudNhR9xrRnnDawsr7yqBvc/WrG l1mBSK9Lt6LByQrFs+YI24NgYSPtN7SgbJhxqlke5nYpkLzxyQaiHAqYVuPXf+PN0BOh3v1kEtmt1 iLasjHcSCRe9XHpXmzKNYcsgKLLNzKKh2v3j7jdXtmPFEkSVILYTunOTphbu9scCYND7p4UvTHXXc ruwiTK8sS+XBSOu/m/sQ6MKMuNwIf9UXpCtg1BRC5ofzXPFLBjOqxY+aPHmCH6rC6f2unEbgeh5jI IvT0t13w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loMh1-002okm-Qn; Wed, 02 Jun 2021 08:57:41 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1loMSE-002jv1-7t for linux-arm-kernel@lists.infradead.org; Wed, 02 Jun 2021 08:42:23 +0000 Received: by mail-ej1-x62c.google.com with SMTP id ce15so2671207ejb.4 for ; Wed, 02 Jun 2021 01:42:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=o2VWGZw80fi/ORNN9aNTt9xwZ4Mho8m3zy0vi7dNfXY=; b=nLCe4bTY52IZ9f1ELod1EPP6noBoLKD7++U70LgMjxoB2bR/iIhUrSM943ZsH+ofmu SZie8h05bezf7J8VMZRMJaQc5PC+OfxiKowF6swWPD8JJ9jW2uiHeQ+QXGdxQGQh0PeM XQ9qIs4F39iP/czyDDWw/YJFqiS/cDy0Gj4efy8XXcgkxbHSaGrsPpbi/6XBd5UGNHFj Ucga3jLRtrGlUCuhykm/3FirHH00GLriA6uyPK6arZyIwYWjO3jLZu9B0KDseZxCLh3E MvZWrFMM8tOgOt8QsLj7hXgQxvbngSdKhArlnhRIlVtPGPVXJxj0IJ9m73ALA7057bwa OUUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=o2VWGZw80fi/ORNN9aNTt9xwZ4Mho8m3zy0vi7dNfXY=; b=KY+uqqOR6mxxLawL+O0rpDdfsaM6CC880CIj3d1PLdYiLb1avUTr0jyQC0gC0/fvvD zVvvkAtq0rifADs/V58rfcxAX3JYcKKtFM7N3igEz9vI4qGv3uNBA3zn4XNh1R5XB1ee OKvJStCVH7qJxvdZzZNYrPecyw9qPK14YvkYtcQnPWEP3f+pEETYCvPX/QPxrlsEcEkq vNa63HWKPG2MNDr0tkC1BqksA2smFdgv4c121dB1XC8VQCnGWWgkgN+3P03TCVihCWTW BH5llNSCVXBBIbGPT0ci6Qf83U3WDYy1LgQ+EyleB+66eiEJmyp7OXYHmDfj42iq3ENI WtQQ== X-Gm-Message-State: AOAM533hw28NW3tnQcKfzJ3ZZ0WJSiOMYZ5/sKLrUpK9OgtVGmhmywiK 4XhrLJmdItIxo6JWxtzoC3c= X-Google-Smtp-Source: ABdhPJwiFX+l5JLUT1A9I3QDlR1r8bGfS+ts965NMyqGTmnIAmG5df3C6FaP/RonAlrDNYxb1H1PQQ== X-Received: by 2002:a17:906:5210:: with SMTP id g16mr33499211ejm.116.1622623340456; Wed, 02 Jun 2021 01:42:20 -0700 (PDT) Received: from localhost ([62.96.65.119]) by smtp.gmail.com with ESMTPSA id y25sm862336edt.17.2021.06.02.01.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 01:42:18 -0700 (PDT) Date: Wed, 2 Jun 2021 10:43:54 +0200 From: Thierry Reding To: Dmitry Osipenko Cc: Krzysztof Kozlowski , Jon Hunter , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 07/12] memory: tegra: Parameterize interrupt handler Message-ID: References: <20210601175942.1920588-1-thierry.reding@gmail.com> <20210601175942.1920588-8-thierry.reding@gmail.com> <9ce2210f-538d-607a-10e4-802ab849deb5@gmail.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.6 (98f8cb83) (2021-03-06) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210602_014222_337400_DF5A2220 X-CRM114-Status: GOOD ( 18.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6713097901722653751==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6713097901722653751== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Z0GfQ1CHflwURXnn" Content-Disposition: inline --Z0GfQ1CHflwURXnn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 01, 2021 at 10:37:19PM +0300, Dmitry Osipenko wrote: > 01.06.2021 21:53, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > 01.06.2021 20:59, Thierry Reding =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > >> --- a/drivers/memory/tegra/mc.h > >> +++ b/drivers/memory/tegra/mc.h > >> @@ -135,9 +135,13 @@ extern const struct tegra_mc_soc tegra210_mc_soc; > >> defined(CONFIG_ARCH_TEGRA_132_SOC) || \ > >> defined(CONFIG_ARCH_TEGRA_210_SOC) > >> int tegra30_mc_probe(struct tegra_mc *mc); > >> +irqreturn_t tegra30_mc_handle_irq(int irq, void *data); > >=20 > > tegra30_mc_handle_irq() doesn't need to be made global, it's defined and > > used only within mc.h. > >=20 >=20 > You could make this function static and annotate it with maybe_unused. This doesn't even need to be __maybe_unused because it's declared in the same #if/#endif block as tegra30_mc_ops. But yeah, I can make this static to mc.c. Initially I had thought that this was going to be used by tegra186_mc_ops as well, but we can always export it if necessary when that work materializes. Thanks, Thierry --Z0GfQ1CHflwURXnn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmC3RMgACgkQ3SOs138+ s6HnvxAAtNoU8iQ9GIyvOLXXag0pvmeRLISKyjMHGXaPo39Ejqx3/OT7QePRjWzD YYDMU9kadlKQm6L0RKxA7ZOX2FcAmYdS6BYQmnacAetRNUnD1/TRszZ8XMYGIxYp HW6dQ/PsDTuiLyD508dMF87rbqJZ06hI4vmxkIJQ+ELFk67jLDuY19A/a4p9ici2 z05Q0aYAyvKaYIXk1k1X8XMez9LqMdvdk09WHJi8yxMC6CCUrJDHyBszEGkLdTUO mvctolE4HjoaxmJlZK/WeC4CSN7Wlp+Gi5HeZCytYnpdefgSayaoPnvXEjOSL4C7 XifDqtaAcJhuvKfQzG5E/G8WSYHG40Q4/X/puqUmyFGvE2Ncz/kTa9uy5NpLe0Mu rkziNXqXLQoOBtn77suwrubeT3SAJGQe7BbKBQ4YidndCH3aX2UewxsePeAQ9Uph M19NGCBd/l5HESVTV1Ek8t1bMxoiV61lIZLvJAZGcHAnKyEepXV8ly7Y+bZ2Haaw wPYPZC1qZZ3AXAxEfdKcUg9b/Lm8N0Eq36rxrlu5IrjXCUoaG1UhTorlh/q9A76a P/EQNAN/ww5i/MDi2GCfm0KFo3Bgfrh5+jbY9OZKmY/kD0qhdU/kn1W2RK+KuCAd m8hnhuwL8xLjHIqvmNClGEQgHrn4VbVWhiRpQp0uYto3IZVo5HQ= =Ag6Y -----END PGP SIGNATURE----- --Z0GfQ1CHflwURXnn-- --===============6713097901722653751== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6713097901722653751==--