From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6F28C4708F for ; Wed, 2 Jun 2021 16:25:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 895A76195D for ; Wed, 2 Jun 2021 16:25:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 895A76195D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XvPchrn7qNzylLaIXtySxz+HkmErKPa7XBEB1vqVb5M=; b=pFIfGYFw6I/Ysz EAsrfgkAa7wsrr28DrKE/fqGTsr8r+urmL0YfrO1BfQMhxkLaSTs1POL8+ttKEKbvosHhg3UuYAdA DneDwhcE26vre7AV2m/JPZ1tgj/wE5X+eWaYiEtALSNOCXTABPS5Jh79vs4APhvQuMvBnIKtAkl2r gJWw3ZQm1K5frFUpS5SdIp854uTDUzjzHhqTkMlUADUNBa5/E8n1KFf31gX73QtrVXcfxOlVRAhuX PcCKz+iTqbo9PwWTpTaHWUlaeVsjyo+FJOiV9QTh1Sqx6unk2MlPLetuX3mOFv+HoES8w/vwcgpuN I90PBHR53YThanNVK8zg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loTem-0057s0-ME; Wed, 02 Jun 2021 16:23:48 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1loTeh-0057qX-Lu for linux-arm-kernel@lists.infradead.org; Wed, 02 Jun 2021 16:23:45 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BF8D5D97; Wed, 2 Jun 2021 18:23:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1622651021; bh=ktVh8oqCTxXbo8Ng4kZbtq18cRRXXX8vW5zxhH3w6x0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=INzKlSMZHVUz11YqbR2GYjXngapsiK0xMha72MmBxNDUHAlF/bcWEA5H4lyuICbEx 8s9it1L/XMBPHen+/93+Hl6moa2ulLe+xxFS25cvQS1VdGwXpMAkpScg+m7dGUBrqP e2783QLi3CwEQ4YM09dZhg6p9oNf1HK9U+uYPN18= Date: Wed, 2 Jun 2021 19:23:30 +0300 From: Laurent Pinchart To: Lee Jones Cc: linux-kernel@vger.kernel.org, Hyun Kwon , David Airlie , Daniel Vetter , Michal Simek , Philipp Zabel , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND 18/26] drm/xlnx/zynqmp_dp: Fix incorrectly name function 'zynqmp_dp_train()' Message-ID: References: <20210602143300.2330146-1-lee.jones@linaro.org> <20210602143300.2330146-19-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210602143300.2330146-19-lee.jones@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210602_092343_907476_9119C4D1 X-CRM114-Status: GOOD ( 17.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Lee, Thank you for the patch. On Wed, Jun 02, 2021 at 03:32:52PM +0100, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/xlnx/zynqmp_dp.c:806: warning: expecting prototype for zynqmp_dp_link_train(). Prototype was for zynqmp_dp_train() instead > > Cc: Hyun Kwon > Cc: Laurent Pinchart > Cc: David Airlie > Cc: Daniel Vetter > Cc: Michal Simek > Cc: Philipp Zabel > Cc: dri-devel@lists.freedesktop.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Lee Jones > --- > drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c > index 82430ca9b9133..a1055d5055eab 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c > +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c > @@ -797,7 +797,7 @@ static int zynqmp_dp_link_train_ce(struct zynqmp_dp *dp) > } > > /** > - * zynqmp_dp_link_train - Train the link > + * zynqmp_dp_train - Train the link The driver has other functions related to link training that start with the zynqmp_dp_link_train_* prefix. I'd prefer renaming this function to zynqmp_dp_link_train(). Bonus points if the same patch could rename zynqmp_dp_train_loop() to zynqmp_dp_link_train_loop() too :-) > * @dp: DisplayPort IP core structure > * > * Return: 0 if all trains are done successfully, or corresponding error code. -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel